[GitHub] [incubator-doris] SaintBacchus commented on a diff in pull request #9725: [Enhancement] Add a ProfileStorage interface to support record all the querylog in persist storage.

[GitBox <gi...@apache.org>]

SaintBacchus commented on code in PR #9725:
URL: https://github.com/apache/incubator-doris/pull/9725#discussion_r878979650


##########
fe/fe-core/src/main/java/org/apache/doris/common/Pair.java:
##########
@@ -22,14 +22,15 @@
 
 import com.google.gson.annotations.SerializedName;
 
+import java.io.Serializable;
 import java.util.Comparator;
 
 /**
  * The equivalent of C++'s std::pair<>.
  *
  * Notice: When using Pair for persistence, users need to guarantee that F and S can be serialized through Gson
  */
-public class Pair<F, S> {
+public class Pair<F, S> implements Serializable {

Review Comment:
   I planned to seriable profile to bytes. And now I will remove this 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org