You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/07/12 03:33:30 UTC
Review Request 67891: Added multi-framework scalability guidelines to
the documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-8238
https://issues.apache.org/jira/browse/MESOS-8238
Repository: mesos
Description
-------
Running multiple frameworks requires co-operation from framework
developers; this outlines some initial guidelines that should be
followed to ensure running multiple frameworks together performs
well.
Diffs
-----
docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
Diff: https://reviews.apache.org/r/67891/diff/1/
Testing
-------
N/A
Thanks,
Benjamin Mahler
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
> On July 12, 2018, 4:56 p.m., Meng Zhu wrote:
> > docs/app-framework-development-guide.md
> > Lines 70-74 (patched)
> > <https://reviews.apache.org/r/67891/diff/1/?file=2058589#file2058589line70>
> >
> > I think it is not easy to explain the starvation issue in a few words. How about providing a link to the doc or the ticket about starvation as optional furhter reading for sophisticated readers.
Added a link at the end.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review206014
-----------------------------------------------------------
On July 12, 2018, 3:33 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 3:33 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
> On July 12, 2018, 4:56 p.m., Meng Zhu wrote:
> > docs/app-framework-development-guide.md
> > Lines 59-75 (patched)
> > <https://reviews.apache.org/r/67891/diff/1/?file=2058589#file2058589line59>
> >
> > These should (also) be in "Operational Guide" (or at least link to there).
Hm.. will put some thought into this and leave open until I figure something out. Thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review206014
-----------------------------------------------------------
On July 12, 2018, 3:33 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 3:33 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review206014
-----------------------------------------------------------
Thanks for adding this!
docs/app-framework-development-guide.md
Lines 52-53 (patched)
<https://reviews.apache.org/r/67891/#comment288966>
We probably also want to point out that, since offered resources are counted as allocated from the allocator perspective, declining quickly could also increase the chance that the framework will get a usable offer soon.
docs/app-framework-development-guide.md
Lines 59-75 (patched)
<https://reviews.apache.org/r/67891/#comment288967>
These should (also) be in "Operational Guide" (or at least link to there).
docs/app-framework-development-guide.md
Lines 60 (patched)
<https://reviews.apache.org/r/67891/#comment288968>
"Competing" may imply over-subscribed (thus operator with under-subscribed cluster may ignore), how about just "sharing the cluster" or "co-existing with other scheudlers".
docs/app-framework-development-guide.md
Lines 70-71 (patched)
<https://reviews.apache.org/r/67891/#comment288969>
"If running an undercommitted cluster, then DRF is not needed."
I suggest to remove this, it is not entirely true and definitely not easy for the operators to understand.
docs/app-framework-development-guide.md
Lines 70-74 (patched)
<https://reviews.apache.org/r/67891/#comment288970>
I think it is not easy to explain the starvation issue in a few words. How about providing a link to the doc or the ticket about starvation as optional furhter reading for sophisticated readers.
docs/app-framework-development-guide.md
Lines 73-74 (patched)
<https://reviews.apache.org/r/67891/#comment288971>
add "weighted"? so that readers know they could set weights for random sorter as well?
- Meng Zhu
On July 11, 2018, 8:33 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 11, 2018, 8:33 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review205996
-----------------------------------------------------------
PASS: Mesos patch 67891 was successfully built and tested.
Reviews applied: `['67891']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1904/mesos-review-67891
- Mesos Reviewbot Windows
On July 12, 2018, 3:33 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 12, 2018, 3:33 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/1/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
> On July 20, 2018, 3:49 p.m., Vinod Kone wrote:
> > docs/app-framework-development-guide.md
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/67891/diff/2/?file=2059405#file2059405line55>
> >
> > Do we want to give any guidance on what values we considere large? Otherwise, it might add more confusion than necessary?
Added an example timeout of 1 hour, also added a 4th guideline about not reviving frequently.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review206283
-----------------------------------------------------------
On July 13, 2018, 9:33 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 9:33 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, Meng Zhu, and Vinod Kone.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review206283
-----------------------------------------------------------
docs/app-framework-development-guide.md
Lines 55 (patched)
<https://reviews.apache.org/r/67891/#comment289182>
Do we want to give any guidance on what values we considere large? Otherwise, it might add more confusion than necessary?
- Vinod Kone
On July 13, 2018, 9:33 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 9:33 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, Meng Zhu, and Vinod Kone.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/#review206084
-----------------------------------------------------------
PASS: Mesos patch 67891 was successfully built and tested.
Reviews applied: `['67891']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1925/mesos-review-67891
- Mesos Reviewbot Windows
On July 13, 2018, 9:33 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67891/
> -----------------------------------------------------------
>
> (Updated July 13, 2018, 9:33 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, Meng Zhu, and Vinod Kone.
>
>
> Bugs: MESOS-8238
> https://issues.apache.org/jira/browse/MESOS-8238
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Running multiple frameworks requires co-operation from framework
> developers; this outlines some initial guidelines that should be
> followed to ensure running multiple frameworks together performs
> well.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
>
>
> Diff: https://reviews.apache.org/r/67891/diff/2/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67891: Added multi-framework scalability
guidelines to the documentation.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67891/
-----------------------------------------------------------
(Updated July 13, 2018, 9:33 p.m.)
Review request for mesos.
Changes
-------
Updates from meng's feedback.
Bugs: MESOS-8238
https://issues.apache.org/jira/browse/MESOS-8238
Repository: mesos
Description
-------
Running multiple frameworks requires co-operation from framework
developers; this outlines some initial guidelines that should be
followed to ensure running multiple frameworks together performs
well.
Diffs (updated)
-----
docs/app-framework-development-guide.md 035ac1f80e063c75786845475d573c1ee03570c0
Diff: https://reviews.apache.org/r/67891/diff/2/
Changes: https://reviews.apache.org/r/67891/diff/1-2/
Testing
-------
N/A
Thanks,
Benjamin Mahler