[jira] [Comment Edited] (SOLR-7614) Distributed Pivot Facet not thread safe

["Yonik Seeley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566557#comment-14566557 ] 

Yonik Seeley edited comment on SOLR-7614 at 5/31/15 2:53 PM:
-------------------------------------------------------------

This may be the root cause of SOLR-7605

edit: nope... something else is wrong as well since the patch didn't fix those fails.


was (Author: yseeley@gmail.com):
This may be the root cause of SOLR-7605

> Distributed Pivot Facet not thread safe
> ---------------------------------------
>
>                 Key: SOLR-7614
>                 URL: https://issues.apache.org/jira/browse/SOLR-7614
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>         Attachments: SOLR-7614.patch
>
>
> I just happened to notice the following added to FacetComponent:
> {code}
>   /**
>    * Incremented counter used to track the values being refined in a given request.
>    * This counter is used in conjunction with {@link PivotFacet#REFINE_PARAM} to identify
>    * which refinement values are associated with which pivots.
>    */
>   int pivotRefinementCounter = 0;
> {code}
> That counter is incremented for each refinement request for correlation, and then reset to 0 at the end.  This will obviously break for concurrent distributed pivot facet requests.
> pivotRefinementCounter should be moved to per-request storage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org