You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "alesharik (via GitHub)" <gi...@apache.org> on 2023/06/05 11:53:10 UTC

[GitHub] [bookkeeper] alesharik opened a new pull request, #3978: Add tls config to etcd metadata driver

alesharik opened a new pull request, #3978:
URL: https://github.com/apache/bookkeeper/pull/3978

   Descriptions of the changes in this PR:
   
   ### Motivation
   
   Etcd metadata driver should support TLS connections to etcd.
   
   ### Changes
   
   - Add `metadataServiceConfig` config parameter to specify the path for the metadata service configuration file
   - Add `EtcdConfig` to parse metadata service configuration file and extract TLS config from it
   - Add support to configure TLS connection to `EtcdMetadataDriverBase`
   - Add smoke test to check if logic above works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] dlg99 commented on pull request #3978: Add tls config to etcd metadata driver

Posted by "dlg99 (via GitHub)" <gi...@apache.org>.
dlg99 commented on PR #3978:
URL: https://github.com/apache/bookkeeper/pull/3978#issuecomment-1585473649

   Please fix checkstyle errors to let CI run


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add tls config to etcd metadata driver [bookkeeper]

Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #3978:
URL: https://github.com/apache/bookkeeper/pull/3978#issuecomment-2093944474

   @alesharik Sorry for my late reply, I recenlty come back to actively work in BookKeeper project. I think we also need documentation about how to config like in #4256 .
   
   Also you need to rebase the code, so we can move forward with this PR.
   
   Thanks for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] alesharik commented on pull request #3978: Add tls config to etcd metadata driver

Posted by "alesharik (via GitHub)" <gi...@apache.org>.
alesharik commented on PR #3978:
URL: https://github.com/apache/bookkeeper/pull/3978#issuecomment-1585592967

   @dlg99 done, checkstyle errors fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add tls config to etcd metadata driver [bookkeeper]

Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #3978:
URL: https://github.com/apache/bookkeeper/pull/3978#issuecomment-2092337134

   @alesharik Thanks for your contribution. Any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add tls config to etcd metadata driver [bookkeeper]

Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on code in PR #3978:
URL: https://github.com/apache/bookkeeper/pull/3978#discussion_r1589846518


##########
metadata-drivers/etcd/src/test/resources/ssl/.gitignore:
##########
@@ -0,0 +1 @@
+cfssl

Review Comment:
   why we need this in `.gitignore`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add tls config to etcd metadata driver [bookkeeper]

Posted by "alesharik (via GitHub)" <gi...@apache.org>.
alesharik commented on PR #3978:
URL: https://github.com/apache/bookkeeper/pull/3978#issuecomment-2093200605

   @shoothzj it is ready. CI failed because of other error, and it may be fixed now 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org