You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by LucVL <gi...@git.apache.org> on 2014/11/25 15:47:16 UTC

[GitHub] lucene-solr pull request: o.a.l.queryparser.flexible.standard.Stan...

GitHub user LucVL opened a pull request:

    https://github.com/apache/lucene-solr/pull/108

    o.a.l.queryparser.flexible.standard.StandardQueryParser cleanup

    * Removed unused, but confusing code (CONJ_AND == CONJ_OR == 2 ???). Unfortunately, the code generated by JavaCC from the updated StandardSyntaxParser.jj differs in more places than necessary.
    * Replaced Vector by List/ArrayList.
    * Corrected the javadoc for StandardQueryParser.setLowercaseExpandedTerms
    
    ant test in the queryparser directory runs successfully

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LucVL/lucene-solr queryparser

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 1c8fa2287975853a53ab42f93a0e32f421e63442
Author: Luc Vanlerberghe <lu...@bvdinfo.com>
Date:   2014-11-25T10:45:19Z

    Removed obsolete (and confusing) code from queryparser/flexible/standard/parser/StandardSyntaxParser.jj

commit 97f1f4d5ca89d3e093671eb0adeee30a31033187
Author: Luc Vanlerberghe <lu...@bvdinfo.com>
Date:   2014-11-25T10:51:51Z

    Replaced Vector by List/ArrayList

commit 153ea3c63a14313308b5657bc351e197360cbe2a
Author: Luc Vanlerberghe <lu...@bvdinfo.com>
Date:   2014-11-25T11:04:01Z

    Changed to using diamond operator again

commit 0e0ad5fda13b82a12703ed3780337d6d247767c4
Author: Luc Vanlerberghe <lu...@bvdinfo.com>
Date:   2014-11-25T14:34:04Z

    Corrected javadoc for StandardQueryParser.setLowercaseExpandedTerms

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[GitHub] lucene-solr pull request: o.a.l.queryparser.flexible.standard.Stan...

Posted by LucVL <gi...@git.apache.org>.
Github user LucVL closed the pull request at:

    https://github.com/apache/lucene-solr/pull/108


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org