You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TheBosZ <gi...@git.apache.org> on 2015/04/24 00:15:57 UTC
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
GitHub user TheBosZ opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Add fullscreen options
This change adds settings to hide the navigation and status bars while the splash screen is displayed. Full-screen apps aren't affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TheBosZ/cordova-plugin-splashscreen add-fullscreen-options
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit 5969cfae37beab6944b768b16365d011055d9991
Author: Nathan Kerr <na...@gmail.com>
Date: 2015-03-11T16:32:29Z
Hide nav bar while showing splash screen
commit 891cbf29bf0a7194f637fac4987c1ff4da97f146
Author: Nathan Kerr <na...@gmail.com>
Date: 2015-03-11T17:32:40Z
Hide status bar as well
commit dc5e8ea5aa2d83fe510f7be286455f97adbee3f7
Author: Nathan Kerr <na...@manifestwebdesign.com>
Date: 2015-04-23T20:55:44Z
Merge remote-tracking branch 'cordova/master' into add-fullscreen-options
commit 2cd8e1affdadc238c56dffa085e80b93c8b9bd0c
Author: Nathan Kerr <na...@manifestwebdesign.com>
Date: 2015-04-23T20:56:55Z
Make the fullscreen settings be options
commit 1d47ba4b2a9579e48240c8db530b8aef67ef7c6f
Author: Nathan Kerr <na...@manifestwebdesign.com>
Date: 2015-04-23T21:03:33Z
Fix syntax error
commit 4f0a3f2d0e088acd830b90a662f54a0d243f3d7a
Author: Nathan Kerr <na...@manifestwebdesign.com>
Date: 2015-04-23T22:12:42Z
Documentation and namespace the preferences to match the other ones
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166910285
@TheBosZ, I would just document that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373317
--- Diff: src/android/SplashScreen.java ---
@@ -255,6 +259,10 @@ public void run() {
}
splashDialog.setContentView(splashImageView);
splashDialog.setCancelable(false);
+ if (isForceFullScreen()) {
--- End diff --
Does it make sense to move this to `// check to see if the splash screen should be full screen` condition above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #45: CB-10255 Add options to hide splashsc...
Posted by charlesbodman <gi...@git.apache.org>.
Github user charlesbodman commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Yeah, no doubt.
Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r48373738
--- Diff: src/android/SplashScreen.java ---
@@ -255,6 +259,10 @@ public void run() {
}
splashDialog.setContentView(splashImageView);
splashDialog.setCancelable(false);
+ if (isForceFullScreen()) {
--- End diff --
I was thinking about the same thing myself. The problem I think is how the full screen is implemented. The way it's done there is the old-style (pre-4.1) way and I don't think it hides the navigation bar.
I unfortunately don't have access to a device that old so I didn't want to cause an error with older phones.
With some experimentation we could probably combine them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #45: CB-10255 Add options to hide splashsc...
Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Reading through the comments there seem to be problems with the functionality, right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166574655
Tested, works well on Android 5.1.1.
On Android 4.3 `<preference name="SplashHideNavigationBar" value="true" />` results in a black strip in the top of the screen, i.e. the splashscreen is not being stretched (setting `BackgroundColor` preference does not solve the issue as well).
@TheBosZ - do you know how this can be fixed?
Also I don't see you in the [Cordova contributors list](http://people.apache.org/committer-index.html), could you please sign an [ICLA](http://www.apache.org/dev/new-committers-guide.html#cla)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by thom7kick <gi...@git.apache.org>.
Github user thom7kick commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-220321857
can u Add options to change colors of the splashscreen navigation and status bars on Android
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167591082
Sounds good to me :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166966495
If we do the workaround, there's no sense in having 2 separate preferences. What about rolling them into a "SplashFullScreen" preference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by dokterbob <gi...@git.apache.org>.
Github user dokterbob commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166317340
@TheBosZ Thanks so much! :dancer:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045852
--- Diff: README.md ---
@@ -54,12 +54,18 @@ In your `config.xml`, you need to add the following preferences:
<preference name="SplashScreen" value="foo" />
<preference name="SplashScreenDelay" value="10000" />
<preference name="SplashMaintainAspectRatio" value="true|false" />
+ <preference name="SplashHideNavigationBar" value="true|false" />
--- End diff --
Do these do the same thing as "Fullscreen" and "ShowTitle" prefs?
If so, can we make the default values for these be the values of "Fullscreen" and "ShowTitle"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-170969928
@daserge Sorry, got busy with something else.
I can duplicate the behavior on all my test devices, but I can't figure out a way to prevent it. Even if I save the window styles and change them back, it will still do the content move.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #45: CB-10255 Add options to hide splashsc...
Posted by charlesbodman <gi...@git.apache.org>.
Github user charlesbodman commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Did this ever get solved?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045956
--- Diff: src/android/SplashScreen.java ---
@@ -254,8 +262,12 @@ public void run() {
}
splashDialog.setContentView(splashImageView);
splashDialog.setCancelable(false);
- splashDialog.show();
-
+ if (isHideNavigationBar() || isHideStatusBar()) {
+ splashDialog.getWindow().getDecorView().setSystemUiVisibility(
+ (isHideNavigationBar() ? View.SYSTEM_UI_FLAG_HIDE_NAVIGATION : 0) | (isHideNavigationBar() ? View.SYSTEM_UI_FLAG_FULLSCREEN : 0));
--- End diff --
The indenting on pretty much every line you changed looks off. Likely the problem is that your editor is inserting tabs instead of spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167622467
@TheBosZ, I've tested this once more and found a bug reproducing on 4.0.3 and 5.0.1 that there is a small content movement to the bottom (in case of 5.0.1 there are even several such movements) after splashscreen is hidden. This issue does not occur on 4.3 though.
Looks like the window style changes don't get reset - could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166947682
Workaround for the 4.3 issue:
```java
if(isHideNavigationBar() && isHideStatusBar()) {
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
WindowManager.LayoutParams.FLAG_FULLSCREEN);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166968629
Yeah, this is a good idea, kills two birds with one stone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-95968778
The options are not the same as those options change the whole project while these only affect the splash screen. We have a client that's requested the splash screen behave the same as iOS, meaning the splash screen takes up the whole screen. They also don't want the app to be full screen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166976789
:+1: thanks, @TheBosZ! I will merge this tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166941739
Added a Jira issue: [CB-10255 Add options to hide splashscreen navigation and status bars on Android](https://issues.apache.org/jira/browse/CB-10255).
@TheBosZ, please squash the commits and rename the PR and the commit title to `CB-10255 Add options to hide splashscreen navigation and status bars on Android`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166668749
I've submitted the ICLA.
Looking over the [docs](http://developer.android.com/training/system-ui/navigation.html), hiding the navigation bar without hiding the status bar should be supported but is discouraged. Should we force hide the status bar if ````SplashHideNavigationBar```` is ```true```?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-166975687
Okay, it was messy but I squished it into one commit and changed it to just be a single preference to force full screen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-167118349
Combining `splashDialog.getWindow().setFlags` and `splashDialog.getWindow().getDecorView().setSystemUiVisibility` approach works on 4.0.3 (with and without soft navbar), 4.3 and 5.1.1:
```java
if (isForceFullScreen()) {
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
WindowManager.LayoutParams.FLAG_FULLSCREEN);
splashDialog.getWindow().getDecorView().setSystemUiVisibility(
View.SYSTEM_UI_FLAG_HIDE_NAVIGATION | View.SYSTEM_UI_FLAG_FULLSCREEN);
}
```
(the current code works properly only for >=Lollipop)
What do you think on updating to this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by danielreuterwall <gi...@git.apache.org>.
Github user danielreuterwall commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107930682
Shouldn't the `SYSTEM_UI_FLAG_FULLSCREEN` flag be based on the `SplashHideStatusBar` preference instead of `SplashHideNavigationBar`?
Like this on line 267:
`(isHideNavigationBar() ? View.SYSTEM_UI_FLAG_HIDE_NAVIGATION : 0) | (isHideStatusBar() ? View.SYSTEM_UI_FLAG_FULLSCREEN : 0));`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-10255 Add options to ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-170834623
Ping @TheBosZ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: Add fullscreen options
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#issuecomment-107997719
Thanks Daniel!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen issue #45: CB-10255 Add options to hide splashsc...
Posted by TheBosZ <gi...@git.apache.org>.
Github user TheBosZ commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/45
Doubt this will ever get merged since it's so old. PRs on Cordova stuff never get any attention so don't hold your breath.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org