You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/16 12:35:27 UTC
[GitHub] [ignite-3] ibessonov commented on a change in pull request #336: IGNITE-15409 Adding NamedConfigurationTree#any to listen for changes in any configuration
ibessonov commented on a change in pull request #336:
URL: https://github.com/apache/ignite-3/pull/336#discussion_r710074148
##########
File path: modules/configuration/src/main/java/org/apache/ignite/internal/configuration/util/ConfigurationNotificationsUtil.java
##########
@@ -173,19 +240,41 @@ public static void notifyListeners(
}
for (String name : deleted) {
+ for (DynamicConfiguration<InnerNode, ?> anyConfig : anyConfigs) {
+ notifyPublicListeners(
+ namedDynamicConfig(anyConfig, key).extendedListeners(),
+ oldNamedList.get(name),
+ null,
+ storageRevision,
+ futures,
+ ConfigurationNamedListListener::onDelete
+ );
+ }
+
notifyPublicListeners(
- extListeners,
+ namedDynamicConfig(cfgNode, key).extendedListeners(),
oldNamedList.get(name),
null,
storageRevision,
futures,
ConfigurationNamedListListener::onDelete
);
- var deletedProp = (ConfigurationNode<N, ?>)namedListCfgMembers.get(name);
+ // Notification for deleted configuration.
+
+ for (var anyConfig : view(anyConfigs, cfg -> any(namedDynamicConfig(cfg, key)))) {
Review comment:
Please don't use "var" this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org