You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Aaron Digulla (JIRA)" <ji...@apache.org> on 2008/04/30 16:27:58 UTC

[jira] Created: (EMAIL-78) Better error message in MultiPartEmail.attach()

Better error message in MultiPartEmail.attach()
-----------------------------------------------

                 Key: EMAIL-78
                 URL: https://issues.apache.org/jira/browse/EMAIL-78
             Project: Commons Email
          Issue Type: Improvement
    Affects Versions: 1.1
            Reporter: Aaron Digulla
            Priority: Minor


Please replace line 367 of org.apache.commons.mail.MultiPartEmail

[code]
throw new EmailException("Invalid URL set");
[code]

with

[code]
throw new EmailException("Invalid URL: "+url, e);
[code]

to generate a better error message when an IOException is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (EMAIL-78) Better error message in MultiPartEmail.attach()

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siegfried Goeschl resolved EMAIL-78.
------------------------------------

    Resolution: Fixed

Applied the patch and added the URL parameter to the exception message.

> Better error message in MultiPartEmail.attach()
> -----------------------------------------------
>
>                 Key: EMAIL-78
>                 URL: https://issues.apache.org/jira/browse/EMAIL-78
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Aaron Digulla
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: EMAIL-78-patch.txt
>
>
> Please replace line 367 of org.apache.commons.mail.MultiPartEmail
> [code]
> throw new EmailException("Invalid URL set");
> [code]
> with
> [code]
> throw new EmailException("Invalid URL: "+url, e);
> [code]
> to generate a better error message when an IOException is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (EMAIL-78) Better error message in MultiPartEmail.attach()

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/EMAIL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671202#action_12671202 ] 

Siegfried Goeschl commented on EMAIL-78:
----------------------------------------

Hi Corey, any reason why not to pass the invalid URL parameter into the exception msg?

> Better error message in MultiPartEmail.attach()
> -----------------------------------------------
>
>                 Key: EMAIL-78
>                 URL: https://issues.apache.org/jira/browse/EMAIL-78
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Aaron Digulla
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: EMAIL-78-patch.txt
>
>
> Please replace line 367 of org.apache.commons.mail.MultiPartEmail
> [code]
> throw new EmailException("Invalid URL set");
> [code]
> with
> [code]
> throw new EmailException("Invalid URL: "+url, e);
> [code]
> to generate a better error message when an IOException is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-78) Better error message in MultiPartEmail.attach()

Posted by "Corey Scott (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Corey Scott updated EMAIL-78:
-----------------------------

    Attachment: EMAIL-78-patch.txt

Re-throws exceptions as appropriate

> Better error message in MultiPartEmail.attach()
> -----------------------------------------------
>
>                 Key: EMAIL-78
>                 URL: https://issues.apache.org/jira/browse/EMAIL-78
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Aaron Digulla
>            Priority: Minor
>         Attachments: EMAIL-78-patch.txt
>
>
> Please replace line 367 of org.apache.commons.mail.MultiPartEmail
> [code]
> throw new EmailException("Invalid URL set");
> [code]
> with
> [code]
> throw new EmailException("Invalid URL: "+url, e);
> [code]
> to generate a better error message when an IOException is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-78) Better error message in MultiPartEmail.attach()

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siegfried Goeschl updated EMAIL-78:
-----------------------------------

    Fix Version/s: 1.2

> Better error message in MultiPartEmail.attach()
> -----------------------------------------------
>
>                 Key: EMAIL-78
>                 URL: https://issues.apache.org/jira/browse/EMAIL-78
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Aaron Digulla
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: EMAIL-78-patch.txt
>
>
> Please replace line 367 of org.apache.commons.mail.MultiPartEmail
> [code]
> throw new EmailException("Invalid URL set");
> [code]
> with
> [code]
> throw new EmailException("Invalid URL: "+url, e);
> [code]
> to generate a better error message when an IOException is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (EMAIL-78) Better error message in MultiPartEmail.attach()

Posted by "Corey Scott (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/EMAIL-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672114#action_12672114 ] 

Corey Scott commented on EMAIL-78:
----------------------------------

Nope, I cant think of a reason why I didnt pass it.  Thanks for catching and fixing this.

> Better error message in MultiPartEmail.attach()
> -----------------------------------------------
>
>                 Key: EMAIL-78
>                 URL: https://issues.apache.org/jira/browse/EMAIL-78
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Aaron Digulla
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: EMAIL-78-patch.txt
>
>
> Please replace line 367 of org.apache.commons.mail.MultiPartEmail
> [code]
> throw new EmailException("Invalid URL set");
> [code]
> with
> [code]
> throw new EmailException("Invalid URL: "+url, e);
> [code]
> to generate a better error message when an IOException is thrown.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.