You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tim O'Brien (JIRA)" <ji...@codehaus.org> on 2006/03/10 17:23:23 UTC

[jira] Created: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Site Plugin should work from Template.  Plugin Should not generate Markup from Java
-----------------------------------------------------------------------------------

         Key: MPIR-35
         URL: http://jira.codehaus.org/browse/MPIR-35
     Project: Maven 2.x Project Info Reports Plugin
        Type: Task

    Reporter: Tim O'Brien


The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.

There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Adam Leggett (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Leggett updated MPIR-35:
-----------------------------

    Attachment: project-info-itest.zip
                maven-project-info-reports.patch

Added a prospective patch to workaround the default vanilla text issue for project reports.

Solution is to allow a project to override the default properties file containing the messages for the reports.
I've made a change to AbstractProjectInfoReport to include an additional optional configuration element of <reportPropertiesBasename> that defaults to 'project-info-report'.
I've then done a prototype implementation  in the TeamListReport subclass and updated the corresponding Test Case.

Also attached some sample integration test projects - one that packages the property resource, which is then referenced as a dependency by the other project in the maven-project-info-reports-plugin configuration.

If the solution is deemed appropriate, i could modify the other report subclasses and make the testing more robust.

TIA

Adam

> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>             Fix For: 2.2
>
>         Attachments: maven-project-info-reports.patch, project-info-itest.zip
>
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Rodrigo Ruiz (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=131722#action_131722 ] 

nodens2k edited comment on MPIR-35 at 4/22/08 9:10 AM:
-----------------------------------------------------------

Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.

BTW, custom templates would be valid solutions for issues MPIR-78 MPIR-86 MPIR94 and MPIR-97.

      was (Author: nodens2k):
    Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.
  
> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>             Fix For: 2.x
>
>         Attachments: maven-project-info-reports.patch, project-info-itest.zip
>
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Rodrigo Ruiz (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=131722#action_131722 ] 

nodens2k edited comment on MPIR-35 at 4/22/08 9:10 AM:
-----------------------------------------------------------

Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.

BTW, custom templates would be a valid solution for issues MPIR-78, MPIR-86, MPIR-94 and MPIR-97.

      was (Author: nodens2k):
    Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.

BTW, custom templates would be valid solutions for issues MPIR-78 MPIR-86 MPIR94 and MPIR-97.
  
> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>             Fix For: 2.x
>
>         Attachments: maven-project-info-reports.patch, project-info-itest.zip
>
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Rodrigo Ruiz (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=131722#action_131722 ] 

Rodrigo Ruiz commented on MPIR-35:
----------------------------------

Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.

> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>             Fix For: 2.x
>
>         Attachments: maven-project-info-reports.patch, project-info-itest.zip
>
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MPIR-35:
--------------------------------

    Fix Version/s: 2.2

> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>             Fix For: 2.2
>
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MPIR-35:
--------------------------------

    Issue Type: New Feature  (was: Task)

> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MPIR-35) Site Plugin should work from Template. Plugin Should not generate Markup from Java

Posted by "Rodrigo Ruiz (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=131722#action_131722 ] 

nodens2k edited comment on MPIR-35 at 4/22/08 9:13 AM:
-----------------------------------------------------------

Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.

For example, I would like to merge the Organisation and Organisation URL columns of the Projet Team report into a single column with a link to the URL using the Organisation name as the link text (I don't know why it is not so). Such changes would be very easy to do with templates.

BTW, custom templates would be a valid solution for issues MPIR-78, MPIR-86, MPIR-94 and MPIR-97.

      was (Author: nodens2k):
    Having the ability to specify custom templates for the reports would be great. Much better than just the message properties.

BTW, custom templates would be a valid solution for issues MPIR-78, MPIR-86, MPIR-94 and MPIR-97.
  
> Site Plugin should work from Template.  Plugin Should not generate Markup from Java
> -----------------------------------------------------------------------------------
>
>                 Key: MPIR-35
>                 URL: http://jira.codehaus.org/browse/MPIR-35
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: New Feature
>            Reporter: Tim O'Brien
>             Fix For: 2.x
>
>         Attachments: maven-project-info-reports.patch, project-info-itest.zip
>
>
> The site plugin currently generates markup from Java.  There is logic in the team list report that prints HTML and Javascript directly to a StringBuffer and there is no facility for customization.  Because of this, every single site that uses the project info reports ends up with the same text.  Google for the text of the team-list plugin and there are at least 18,000 matching pages.
> There needs to be a facility for customization.  I propose that the default report is published from a velocity template loaded form the classpath, but the site plugin checks for the presence of an overriding velocity template in a know path (or from a URL).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira