[GitHub] [spark] huaxingao commented on a change in pull request #35823: [SPARK-38533][SQL] DS V2 aggregate push-down supports project with alias

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #35823:
URL: https://github.com/apache/spark/pull/35823#discussion_r825331821



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala
##########
@@ -234,7 +257,7 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan] with PredicateHelper {
                   // Aggregate [c2#10], [min(min(c1)#21) AS min(c1)#17, max(max(c1)#22) AS max(c1)#18]
                   // +- RelationV2[c2#10, min(c1)#21, max(c1)#22] ...
                   // scalastyle:on
-                  plan.transformExpressions {
+                  val agg = plan.transformExpressions {

Review comment:
       nit: unnecessary change?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org