You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/28 05:24:24 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #3060: [IOTDB-1306] New memory control strategy

HTHou commented on a change in pull request #3060:
URL: https://github.com/apache/iotdb/pull/3060#discussion_r621823291



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/timeindex/ITimeIndex.java
##########
@@ -76,14 +76,6 @@
   /** @return Calculate file index ram size */
   long calculateRamSize();
 
-  /**
-   * Calculate file index ram increment when insert data in TsFileProcessor
-   *
-   * @param deviceToBeChecked device to be checked
-   * @return ramIncrement
-   */
-  long estimateRamIncrement(String deviceToBeChecked);

Review comment:
       This part of memory is quite small. We can ignore it. 
   By the way, it's more necessary to control the memory of sealed TsFileResource....




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org