[GitHub] [superset] jsoref commented on a diff in pull request #25454: chore(tests): Spelling

["jsoref (via GitHub)" <gi...@apache.org>]

jsoref commented on code in PR #25454:
URL: https://github.com/apache/superset/pull/25454#discussion_r1341645778


##########
tests/integration_tests/databases/api_tests.py:
##########
@@ -2016,17 +2016,17 @@ def test_test_connection_failed_invalid_hostname(
         """
         Database API: Test test connection failed due to invalid hostname
         """
-        msg = 'psql: error: could not translate host name "locahost" to address: nodename nor servname provided, or not known'
+        msg = 'psql: error: could not translate host name "localhost_" to address: nodename nor servname provided, or not known'

Review Comment:
   The test (and I believe the one above) is trying to validate the error handling for an unreasonable domain.
   
   `locahost` is both unresolvable and misspelled, `localhost_` is only unresolvable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org