You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jasongin <gi...@git.apache.org> on 2016/04/12 23:06:42 UTC

[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

GitHub user jasongin opened a pull request:

    https://github.com/apache/cordova-cli/pull/244

    CB-11042: Add cordova run option to skip prepare

    Parse and document a --noprepare option for the cordova run command.
    
    See https://github.com/apache/cordova-lib/pull/426 for the corresponding cordova-lib change that skips the prepare step if the noprepare option is specified.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasongin/cordova-cli CB-11042

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit 053bbdf841997276112d1675913d7871792f3469
Author: Jason Ginchereau <ja...@microsoft.com>
Date:   2016-04-12T20:59:09Z

    CB-11042: Add cordova run option to skip prepare

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/244#discussion_r59599203
  
    --- Diff: doc/readme.md ---
    @@ -464,29 +464,31 @@ cordova build [<platform> [...]]
     
     ### Synopsis
     
    -Prepares, builds (unless `--nobuild` is specified) and deploys app on specified platform devices/emulators. If a device is connected it will be used, unless an eligible emulator is already running.
    +Prepares, builds, and deploys app on specified platform devices/emulators. If a device is connected it will be used, unless an eligible emulator is already running.
     
     ###Syntax
     
     ```bash
     cordova run [<platform> [...]]
    -    [--list | --nobuild ]
    +    [--list | --debug | --release]
    +    [--noprepare] [--nobuild]
         [--device|--emulator|--target=<targetName>]
         [--buildConfig=<configfile>]
         [--browserify]
         [-- <platformOpts>]
     ```
     
    -| Option     | Description
    -|------------|------------------
    +| Option      | Description
    +|-------------|------------------
     | `<platform> [..]` | Platform name(s) to run. If not specified, all platforms are run.
    -|--nobuild   | Skip building
    -|--debug     | Deploy a debug build. This is the default behavior unless `--release` is specified.
    -|--release   | Deploy a release build
    -|--device    | Deploy to a device
    -|--emulator  | Deploy to an emulator
    -|--target    | Deploy to a specific target emulator/device. Use `--list` to display target options
    -| --list     | Lists available targets. Displays both device and emulator deployment targets unless specified
    +| --list      | Lists available targets. Displays both device and emulator deployment targets unless specified
    +| --debug     | Deploy a debug build. This is the default behavior unless `--release` is specified.
    +| --release   | Deploy a release build
    +| --noprepare | Skip preparing
    --- End diff --
    
    One slight caveat - just mention something like: [Available in cordova CLI 6.2 and above]
    
    Since we have a 6.x version of the docs - new features, flags need to be versioned inline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209578035
  
    @nikhilkh , if that's the case don't we need a JIRA to track updating the docs website ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209577843
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-210666679
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209571650
  
    @omefire Isn't that covered by the update to docs/readme.md in this change? Or is it duplicated somewhere else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by jasongin <gi...@git.apache.org>.
Github user jasongin closed the pull request at:

    https://github.com/apache/cordova-cli/pull/244


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209576907
  
    Updating docs\readme.md should be sufficient - docs website publishing should take care of updating the version in cordova-docs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209578347
  
    We update website content regularly and don't need a JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209564718
  
    @jasongin consider also updating the docs: http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by jasongin <gi...@git.apache.org>.
Github user jasongin commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/244#discussion_r59906168
  
    --- Diff: doc/readme.md ---
    @@ -464,29 +464,31 @@ cordova build [<platform> [...]]
     
     ### Synopsis
     
    -Prepares, builds (unless `--nobuild` is specified) and deploys app on specified platform devices/emulators. If a device is connected it will be used, unless an eligible emulator is already running.
    +Prepares, builds, and deploys app on specified platform devices/emulators. If a device is connected it will be used, unless an eligible emulator is already running.
     
     ###Syntax
     
     ```bash
     cordova run [<platform> [...]]
    -    [--list | --nobuild ]
    +    [--list | --debug | --release]
    +    [--noprepare] [--nobuild]
         [--device|--emulator|--target=<targetName>]
         [--buildConfig=<configfile>]
         [--browserify]
         [-- <platformOpts>]
     ```
     
    -| Option     | Description
    -|------------|------------------
    +| Option      | Description
    +|-------------|------------------
     | `<platform> [..]` | Platform name(s) to run. If not specified, all platforms are run.
    -|--nobuild   | Skip building
    -|--debug     | Deploy a debug build. This is the default behavior unless `--release` is specified.
    -|--release   | Deploy a release build
    -|--device    | Deploy to a device
    -|--emulator  | Deploy to an emulator
    -|--target    | Deploy to a specific target emulator/device. Use `--list` to display target options
    -| --list     | Lists available targets. Displays both device and emulator deployment targets unless specified
    +| --list      | Lists available targets. Displays both device and emulator deployment targets unless specified
    +| --debug     | Deploy a debug build. This is the default behavior unless `--release` is specified.
    +| --release   | Deploy a release build
    +| --noprepare | Skip preparing
    --- End diff --
    
    I updated the PR with a note about requiring 6.2.
    
    ---
    In reply to: [59599203](https://github.com/apache/cordova-cli/pull/244#discussion_r59599203) [](ancestors = 59599203)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209572705
  
    It's located elsewhere, in the cordova-docs repo: https://github.com/apache/cordova-docs/blob/1f35df99b7cf77aa5889c2ecb9a3c3ab71542ee6/www/docs/en/6.x/reference/cordova-cli/index.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-211497103
  
    Merged with commit: 6e2d201. Could you please close this PR now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209579344
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-cli pull request: CB-11042: Add cordova run option to skip...

Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:

    https://github.com/apache/cordova-cli/pull/244#issuecomment-209579313
  
    ok, now I get it. apparently, the website content will be generated from this readme.md, so we're fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org