You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2020/09/15 07:46:17 UTC

[GitHub] [jmeter] vlsi opened a new pull request #620: Add validation of the third-party jars that are included to the release

vlsi opened a new pull request #620:
URL: https://github.com/apache/jmeter/pull/620


   The validation skips JMeter jars, and it helps to spot accidental third-party
   dependency addition or removal
   
   Sample failure:
   
   ```
   * What went wrong:
   Execution failed for task ':src:dist:verifyReleaseDependencies'.
   > External dependencies differ (you could update src/dist/src/dist/expected_release_jars.csv if you add -PupdateExpectedJars):
       56938605 => 55421535 bytes (-1517070 bytes)
       97 => 98 files (+1)
   
     +  137455 groovy-jmx-3.0.5.jar
     - 2137455 groovy-sql-3.0.5.jar
     - 1106993 jna-5.0.0.jar
     + 1506993 jna-5.5.0.jar
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi merged pull request #620: Add validation of the third-party jars that are included to the release

Posted by GitBox <gi...@apache.org>.
vlsi merged pull request #620:
URL: https://github.com/apache/jmeter/pull/620


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on pull request #620: Add validation of the third-party jars that are included to the release

Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #620:
URL: https://github.com/apache/jmeter/pull/620#issuecomment-694916288


   Sorry for the late reply. I think it will help us to understand our dependencies even better. So, thanks for implementing it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] vlsi commented on pull request #620: Add validation of the third-party jars that are included to the release

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #620:
URL: https://github.com/apache/jmeter/pull/620#issuecomment-692533662


   @pmouawad , @FSchumacher , it might make dependency updates slightly more complicated, however, I think it would prevent us from adding unexpected dependencies. WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org