You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 02:11:58 UTC

[GitHub] [airflow] josh-fell commented on a change in pull request #20271: Fix mypy airbyte provider errors

josh-fell commented on a change in pull request #20271:
URL: https://github.com/apache/airflow/pull/20271#discussion_r768263731



##########
File path: airflow/providers/airbyte/sensors/airbyte.py
##########
@@ -54,7 +54,7 @@ def __init__(
 
     def poke(self, context: dict) -> bool:
         hook = AirbyteHook(airbyte_conn_id=self.airbyte_conn_id, api_version=self.api_version)
-        job = hook.get_job(job_id=self.airbyte_job_id)
+        job = hook.get_job(job_id=int(self.airbyte_job_id))

Review comment:
       Looks like `airbyte_job_id` in the sensor's constructor is still typed as a `str` rather than `int`. Changing the typing there should remove the need for the cast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org