You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/09/16 21:03:33 UTC

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23432


Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli inclusion appears in a different part of the dependency
tree; all versions matched. Also ensured USE_APACHE_COMPONENTS=true
compiles.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
---
M bin/impala-config-java.sh
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
20 files changed, 214 insertions(+), 447 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/23432/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Riza Suminto, Laszlo Gaal, Jason Fehr, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23432

to look at the new patch set (#9).

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli now comes from hadoop and jersey-serv{let,er} are
effectively excluded; all versions matched. Also ensured
USE_APACHE_COMPONENTS=true compiles.

Adds com.amazonaws:aws-java-sdk-bundle to exclusion checking to ensure
it's not accidentally included alongside impala-minimal-s3a-aws-sdk.

Removes missed io.netty exclusion from IMPALA-12816.

Updates commons-dbcp2 to 2.12.0 to match Hive.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
---
M bin/impala-config.sh
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
20 files changed, 211 insertions(+), 450 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/23432/9
-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml@524
PS2, Line 524:         <plugin>
             :           <groupId>org.apache.maven.plugins</groupId>
             :           <artifactId>maven-compiler-plugin</artifactId>
             :           <version>3.14.0</version>
             :         </plugin>
> Ah, thanks for looking into that. I was seeing that pop up in some builds a
Oh, which is what's happening here. We're building with Java 17 and targeting Java 8.

JDK 8 doesn't support --add-exports, so this would have to be a profile.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 22:04:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20504/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 21:22:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG@19
PS6, Line 19: Compared before and after with dependency:tree; only difference is that
For which pom.xml files was the dependency:tree output checked?


http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml
File java/yarn-extras/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml@a79
PS6, Line 79: 
Why remove this exclusion?  It shouldn't matter either way since log4j should be defined at a higher level thus always overriding this dependency's version.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 23:14:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20520/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 19:31:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Sep 2025 02:50:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/3/java/test-hive-udfs/pom.xml
File java/test-hive-udfs/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/java/test-hive-udfs/pom.xml@a30
PS3, Line 30: 
> Does it still produce test-hive-udfs-1.0.jar? Some of our code depends on t
Ah thanks, I was trying to figure out why those versions were different. I'll restore these.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 22:57:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> > Patch Set 7:
> > 
> > (1 comment)
> 
> Thank you for checking those.  I am slightly concerned about the commons-dbcp2 version downgrade.  Per the release notes at https://commons.apache.org/proper/commons-dbcp/changes-report.html, there are no major changes between 2.9.0 and 2.12, but there are a lot of bug fixes.  Would you be ok with bumping the IMPALA_DBCP2_VERSION env var from 2.9.0 to 2.12?  My concern is introducing difficult to debug issues because a bug fix is now gone from commons-dbcp.  I know it's not a pom fix, thus tackling it in another change works too.

That changes makes sense, I'll upgrade it.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 15:59:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml@524
PS2, Line 524:     <pluginManagement>
             :       <plugins>
             :         <plugin>
             :           <groupId>org.apache.maven.plugins</groupId>
             :           <artifa
> Actually it happens because I've implicitly changed maven.compiler.source b
I updated to use maven.compiler.source and maven.compiler.target and avoid changing the source version in this patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 20:57:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 6:

(2 comments)

> Patch Set 5:
> 
> (2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a183
PS3, Line 183: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
> Yes, both CDP and Apache Ranger versions didn't trigger the ban rules and I
Thanks! I don't have additional questions.


http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a198
PS3, Line 198: 
             : 
             : 
             : 
> With our direct dependency on orc-core, the exclusion is no longer necessar
Thanks! I don't have additional questions.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 19:53:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG@19
PS6, Line 19: Compared before and after with dependency:tree; only difference is that
> For which pom.xml files was the dependency:tree output checked?
`mvn -f fe`. I should probably do `mvn -f java` to check each subproject.


http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml
File java/yarn-extras/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml@a79
PS6, Line 79: 
> Why remove this exclusion?  It shouldn't matter either way since log4j shou
Because it's no longer part of hadoop-yarn-common, and we have a bannedDependencies check that it's not present.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 23:21:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23432

to look at the new patch set (#3).

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli inclusion appears in a different part of the dependency
tree; all versions matched. Also ensured USE_APACHE_COMPONENTS=true
compiles.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
---
M bin/impala-config-java.sh
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
20 files changed, 216 insertions(+), 447 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/23432/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

Thanks for cleaning this up!

http://gerrit.cloudera.org:8080/#/c/23432/2/java/shaded-deps/hive-exec/pom.xml
File java/shaded-deps/hive-exec/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/shaded-deps/hive-exec/pom.xml@a137
PS2, Line 137: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
I don't see this change mentioned in the commit message - why can we remove it, is it the default value?



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 08:36:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Riza Suminto, Laszlo Gaal, Jason Fehr, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23432

to look at the new patch set (#8).

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli inclusion appears in a different part of the dependency
tree and jersey-serv{let,er} are effectively excluded; all versions
matched. Also ensured USE_APACHE_COMPONENTS=true compiles.

Adds com.amazonaws:aws-java-sdk-bundle to exclusion checking to ensure
it's not accidentally included alongside impala-minimal-s3a-aws-sdk.

Removes missed io.netty exclusion from IMPALA-12816.

Updates commons-dbcp2 to 2.12.0 to match Hive.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
---
M bin/impala-config.sh
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
20 files changed, 210 insertions(+), 443 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/23432/8
-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 18:07:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20511/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 23:37:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> (1 comment)

Thank you for checking those.  I am slightly concerned about the commons-dbcp2 version downgrade.  Per the release notes at https://commons.apache.org/proper/commons-dbcp/changes-report.html, there are no major changes between 2.9.0 and 2.12, but there are a lot of bug fixes.  Would you be ok with bumping the IMPALA_DBCP2_VERSION env var from 2.9.0 to 2.12?  My concern is introducing difficult to debug issues because a bug fix is now gone from commons-dbcp.  I know it's not a pom fix, thus tackling it in another change works too.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 15:37:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20532/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 16:30:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 9: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 20:27:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/20496/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 21:29:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml@524
PS2, Line 524:         <plugin>
             :           <groupId>org.apache.maven.plugins</groupId>
             :           <artifactId>maven-compiler-plugin</artifactId>
             :           <version>3.14.0</version>
             :         </plugin>
> Oh, which is what's happening here. We're building with Java 17 and targeti
Doesn't work, Java complains

  error: option --add-exports not allowed with target 8

The only solution I've found is to match compiler to target version. Which looks like it'll be a pre-requisite of this patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 22:20:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23432

to look at the new patch set (#4).

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli inclusion appears in a different part of the dependency
tree; all versions matched. Also ensured USE_APACHE_COMPONENTS=true
compiles.

Adds com.amazonaws:aws-java-sdk-bundle to exclusion checking to ensure
it's not accidentally included alongside impala-minimal-s3a-aws-sdk.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
---
M bin/impala-config-java.sh
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
20 files changed, 215 insertions(+), 443 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/23432/4
-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a198
PS3, Line 198: 
             : 
             : 
             : 
> Are notes like this important to preserve, or they does not matter anymore?
The question is does Ranger include anything besides orc-core, since we include it explicitly. I didn't see evidence they did. It wouldn't hurt to add it back I suppose.


http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@794
PS3, Line 794: <exclude>com.amazonaws:aws-java-sdk-bundle</exclude>
> Why is this added?
I'll note it in the commit message. This should be excluded since we use our own minimal s3a jar instead. Just making sure it doesn't accidentally creep in.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 23:03:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml@524
PS2, Line 524:         <plugin>
             :           <groupId>org.apache.maven.plugins</groupId>
             :           <artifactId>maven-compiler-plugin</artifactId>
             :           <version>3.14.0</version>
             :         </plugin>
> Doesn't work, Java complains
Actually it happens because I've implicitly changed maven.compiler.source by using release.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 22:22:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml@524
PS2, Line 524:         <plugin>
             :           <groupId>org.apache.maven.plugins</groupId>
             :           <artifactId>maven-compiler-plugin</artifactId>
             :           <version>3.14.0</version>
             :         </plugin>
Looks like this require some tweak to allow using sun.misc.Unsafe

        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-compiler-plugin</artifactId>
            <version>3.14.0</version>
            <configuration>
                <compilerArgs>
                    <!-- Replace 'my.module' with your project's module name -->
                    <arg>--add-exports</arg>
                    <arg>java.base/sun.misc=my.module</arg>
                </compilerArgs>
            </configuration>
        </plugin>



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 22:00:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12519/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 22:00:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 22:00:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/3/java/test-hive-udfs/pom.xml
File java/test-hive-udfs/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/java/test-hive-udfs/pom.xml@a30
PS3, Line 30: 
Does it still produce test-hive-udfs-1.0.jar? Some of our code depends on that specific version: https://github.com/apache/impala/blob/master/testdata/bin/copy-udfs-udas.sh#L56

Same thing with test-corrupt-hive-udfs and external-frontend.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 22:56:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a198
PS3, Line 198: 
             : 
             : 
             : 
Are notes like this important to preserve, or they does not matter anymore?
Might want to ask Fang-Yu about this.


http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@794
PS3, Line 794: <exclude>com.amazonaws:aws-java-sdk-bundle</exclude>
Why is this added?



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 23:00:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 4:

(2 comments)

Thanks for taking care of this Michael! I left 2 minor comments.

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a183
PS3, Line 183: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
This is just for my own understanding. Is it true that the current Ranger dependency no longer pulls in log4j-1.2-api or log4j, so it's safe to remove these 2 exclusions? I am asking this because it seems these 2 artifacts are still banned. Not very sure if I missed something.


http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a198
PS3, Line 198: 
             : 
             : 
             : 
> Are notes like this important to preserve, or they does not matter anymore?

If we remove this exclusion then the note about RANGER-1837 won't matter anymore.

> The question is does Ranger include anything besides orc-core, since we include it explicitly. I didn't see evidence they did. It wouldn't hurt to add it back I suppose.

Laszlo authored https://github.com/apache/impala/commit/85e1a3e33b9a3f55684e321f5ad180d4fc04c5ad that added this exclusion. It seems the Ranger dependency could pull in a different version of ORC that might not be compatible with the Iceberg dependency needed by Impala.

I guess we want to keep this exclusion? Maybe we should consult Laszlo about this too.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 00:41:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG@19
PS6, Line 19: Compared before and after with dependency:tree; only difference is that
> `mvn -f fe`. I should probably do `mvn -f java` to check each subproject.
The fe project is the big one.  Checking 'java' would be good, although that shouldn't show any changes since updates were in <dependencyManagement>.  I would prefer to have some of the subprojects' dependency:tree checked.

Would also be good to spot check the effective poms to make sure the changes in <pluginManagement> did not cause any changes:
mvn -f fe help:effective-pom


http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml
File java/yarn-extras/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/6/java/yarn-extras/pom.xml@a79
PS6, Line 79: 
> Because it's no longer part of hadoop-yarn-common, and we have a bannedDepe
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 23:28:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 20:52:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml
File java/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/pom.xml@524
PS2, Line 524:         <plugin>
             :           <groupId>org.apache.maven.plugins</groupId>
             :           <artifactId>maven-compiler-plugin</artifactId>
             :           <version>3.14.0</version>
             :         </plugin>
> Looks like this require some tweak to allow using sun.misc.Unsafe
Ah, thanks for looking into that. I was seeing that pop up in some builds and thought it was related to using different Java compiler and target.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Sep 2025 22:03:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@794
PS3, Line 794: <exclude>com.amazonaws:aws-java-sdk-bundle</exclude>
> I'll note it in the commit message. This should be excluded since we use ou
Done


http://gerrit.cloudera.org:8080/#/c/23432/3/java/test-hive-udfs/pom.xml
File java/test-hive-udfs/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/java/test-hive-udfs/pom.xml@a30
PS3, Line 30: 
> Ah thanks, I was trying to figure out why those versions were different. I'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 23:12:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/2/java/shaded-deps/hive-exec/pom.xml
File java/shaded-deps/hive-exec/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/2/java/shaded-deps/hive-exec/pom.xml@a137
PS2, Line 137: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
> I don't see this change mentioned in the commit message - why can we remove
I moved it to https://gerrit.cloudera.org/c/23432/2/java/pom.xml#547.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Sep 2025 20:55:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/20537/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 19:51:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Riza Suminto, Laszlo Gaal, Csaba Ringhofer, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23432

to look at the new patch set (#5).

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli inclusion appears in a different part of the dependency
tree and jersey-serv{let,er} are effectively excluded; all versions
matched. Also ensured USE_APACHE_COMPONENTS=true compiles.

Adds com.amazonaws:aws-java-sdk-bundle to exclusion checking to ensure
it's not accidentally included alongside impala-minimal-s3a-aws-sdk.

Removes missed io.netty exclusion from IMPALA-12816.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
---
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
19 files changed, 209 insertions(+), 442 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/23432/5
-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a183
PS3, Line 183: 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
             : 
> This is just for my own understanding. Is it true that the current Ranger d
Yes, both CDP and Apache Ranger versions didn't trigger the ban rules and I didn't see them in the dependency tree.


http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a198
PS3, Line 198: 
             : 
             : 
             : 
> > Are notes like this important to preserve, or they does not matter anymor
With our direct dependency on orc-core, the exclusion is no longer necessary. And there's an enforcement rule to make sure all org.apache.orc dependencies match orc.version, so we shouldn't have surprises there.



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 19:04:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23432/6//COMMIT_MSG@19
PS6, Line 19: Compared before and after with dependency:tree; only difference is that
> The fe project is the big one.  Checking 'java' would be good, although tha
Raw output: https://gist.github.com/MikaelSmith/d38f0e97cccd73135c52796da58bd360.

For dependency tree, differences are:
- maven-dependency-plugin 2.8 -> 3.5.0
- io.netty no longer excluded (as expected)
- commons-dbcp2 version 2.9.0 globally enforced. This does backtrack from 2.12 from hive-exec.
- datasketches-java version 6.0.0 globally enforced
- commons-cli dependency now comes from hadoop (as expected)

For effective pom, plugin differences are:
- maven-compiler-plugin 3.11.0 -> 3.14.0
- maven-dependency-plugin 2.8 -> 3.5.0



-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 13:42:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14446: Clean up pom.xml

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23432 )

Change subject: IMPALA-14446: Clean up pom.xml
......................................................................

IMPALA-14446: Clean up pom.xml

Cleans up repetitive patterns in pom.xml.

Centralize plugin configuration in pluginManagement. Replace inline
maven-compiler-plugin configuration with newer maven.compiler.release
and update to latest plugin version.

Centralize common dependencies in dependencyManagement, including
exclusions when appropriate. Remove exclusions that are no longer
relevant.

Compared before and after with dependency:tree; only difference is that
commons-cli now comes from hadoop and jersey-serv{let,er} are
effectively excluded; all versions matched. Also ensured
USE_APACHE_COMPONENTS=true compiles.

Adds com.amazonaws:aws-java-sdk-bundle to exclusion checking to ensure
it's not accidentally included alongside impala-minimal-s3a-aws-sdk.

Removes missed io.netty exclusion from IMPALA-12816.

Updates commons-dbcp2 to 2.12.0 to match Hive.

Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Reviewed-on: http://gerrit.cloudera.org:8080/23432
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M java/TableFlattener/pom.xml
M java/calcite-planner/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/jdbc/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/external-frontend/pom.xml
M java/iceberg-rest-catalog-test/pom.xml
M java/pom.xml
M java/puffin-data-generator/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
20 files changed, 211 insertions(+), 450 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0
Gerrit-Change-Number: 23432
Gerrit-PatchSet: 11
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>