You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/21 20:48:23 UTC

[GitHub] anirudhacharya commented on a change in pull request #13357: Add imresize and copyMakeBorder to mx.image

anirudhacharya commented on a change in pull request #13357: Add imresize and copyMakeBorder to mx.image
URL: https://github.com/apache/incubator-mxnet/pull/13357#discussion_r235534522
 
 

 ##########
 File path: python/mxnet/image/image.py
 ##########
 @@ -178,6 +233,59 @@ def scale_down(src_size, size):
     return int(w), int(h)
 
 
+def copyMakeBorder(src, top, bot, left, right, *args, **kwargs):
 
 Review comment:
   No, that would break the API, as said in the PR description
   
   > Though mx.image.imresize and mx.image.copyMakeBorder is currently available for external use, it does not show up in the docs because it was hidden behind an internal function call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services