You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2016/08/29 13:57:44 UTC

Review Request 51492: ATLAS-1141: UI-Issue - Tag with spaces, when searched, then it is wrongly set in search textbox.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51492/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.


Bugs: ATLAS-1141
    https://issues.apache.org/jira/browse/ATLAS-1141


Repository: atlas


Description
-------

Patch includes fix for below issues - 

* If a Tag is created with space i.e "Tags for Test" and through "Search Tag" link it is searched, then in search box it only displays "for Test" instead of whole Tag name.
* In firefox and safari the date is showing invaid on taxonomy page.


Diffs
-----

  dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js d592d1e 
  dashboardv2/public/js/views/business_catalog/TreeLayoutView.js be47725 
  dashboardv2/public/js/views/tag/TagLayoutView.js b1cb6cc 

Diff: https://reviews.apache.org/r/51492/diff/


Testing
-------

Tested following scenarios : 

* The Date on business taxonomy page is showing in proper format on firefox and safari browser.
* The whole tag is set with space after searched through "search tag" and tag search page results is showing properly.


Thanks,

Kalyani Kashikar


Re: Review Request 51492: ATLAS-1141: UI-Issue - Tag with spaces, when searched, then it is wrongly set in search textbox.

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51492/#review147412
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 30, 2016, 12:24 p.m., Kalyani Kashikar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51492/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 12:24 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1141
>     https://issues.apache.org/jira/browse/ATLAS-1141
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Patch includes fix for below issues - 
> 
> * If a Tag is created with space i.e "Tags for Test" and through "Search Tag" link it is searched, then in search box it only displays "for Test" instead of whole Tag name.
> * In firefox and safari the date is showing invaid on taxonomy page.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js d592d1e 
>   dashboardv2/public/js/views/business_catalog/TreeLayoutView.js be47725 
>   dashboardv2/public/js/views/tag/TagLayoutView.js b1cb6cc 
> 
> Diff: https://reviews.apache.org/r/51492/diff/
> 
> 
> Testing
> -------
> 
> Tested following scenarios : 
> 
> * The Date on business taxonomy page is showing in proper format on firefox and safari browser.
> * The whole tag is set with space after searched through "search tag" and tag search page results is showing properly.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>


Re: Review Request 51492: ATLAS-1141: UI-Issue - Tag with spaces, when searched, then it is wrongly set in search textbox.

Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51492/
-----------------------------------------------------------

(Updated Aug. 30, 2016, 12:24 p.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Suma Shivaprasad.


Bugs: ATLAS-1141
    https://issues.apache.org/jira/browse/ATLAS-1141


Repository: atlas


Description
-------

Patch includes fix for below issues - 

* If a Tag is created with space i.e "Tags for Test" and through "Search Tag" link it is searched, then in search box it only displays "for Test" instead of whole Tag name.
* In firefox and safari the date is showing invaid on taxonomy page.


Diffs (updated)
-----

  dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js d592d1e 
  dashboardv2/public/js/views/business_catalog/TreeLayoutView.js be47725 
  dashboardv2/public/js/views/tag/TagLayoutView.js b1cb6cc 

Diff: https://reviews.apache.org/r/51492/diff/


Testing
-------

Tested following scenarios : 

* The Date on business taxonomy page is showing in proper format on firefox and safari browser.
* The whole tag is set with space after searched through "search tag" and tag search page results is showing properly.


Thanks,

Kalyani Kashikar