You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/24 08:20:54 UTC

[GitHub] [airflow] aneesh-joseph opened a new pull request #8995: fix initdb for mssql

aneesh-joseph opened a new pull request #8995:
URL: https://github.com/apache/airflow/pull/8995


   
   Fix https://github.com/apache/airflow/issues/8993
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Target Github ISSUE in description if exists
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #8995: fix initdb for mssql on airflow-v1.10.10

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #8995:
URL: https://github.com/apache/airflow/pull/8995#issuecomment-633288048


   Thanks for the PR but the original PR #8385 that fixes the issue is marked for 1.10.11 (using Milestone), so I will cherry-pick that one when releasing 1.10.11 .
   
   Closing this one but thanks for taking the effort and rest assured that this would be fixed in 1.10.11


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] aneesh-joseph commented on pull request #8995: fix initdb for mssql on airflow-v1.10.10

Posted by GitBox <gi...@apache.org>.
aneesh-joseph commented on pull request #8995:
URL: https://github.com/apache/airflow/pull/8995#issuecomment-633197300


   just realised that it's already fixed on master via https://github.com/apache/airflow/pull/8385/files


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed pull request #8995: fix initdb for mssql on airflow-v1.10.10

Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #8995:
URL: https://github.com/apache/airflow/pull/8995


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] aneesh-joseph commented on pull request #8995: fix initdb for mssql on airflow-v1.10.10

Posted by GitBox <gi...@apache.org>.
aneesh-joseph commented on pull request #8995:
URL: https://github.com/apache/airflow/pull/8995#issuecomment-633370200


   awesome, thank you @kaxil , can you also cherrypick the fix for https://github.com/apache/airflow/pull/8684 if possible , that is also on master already 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org