You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2022/08/22 13:03:40 UTC

[tomcat] branch 8.5.x updated: Log a warning rather than throw for an unrecognised action type

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new aef3b97177 Log a warning rather than throw for an unrecognised action type
aef3b97177 is described below

commit aef3b97177de2c010248e8f1b6db79a710d1e0de
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Aug 22 14:02:51 2022 +0100

    Log a warning rather than throw for an unrecognised action type
    
    This will facilitate future additions of new functionality.
---
 java/org/apache/catalina/ha/session/DeltaRequest.java |  2 +-
 webapps/docs/changelog.xml                            | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/ha/session/DeltaRequest.java b/java/org/apache/catalina/ha/session/DeltaRequest.java
index c691e6d1f9..4a5c65792f 100644
--- a/java/org/apache/catalina/ha/session/DeltaRequest.java
+++ b/java/org/apache/catalina/ha/session/DeltaRequest.java
@@ -218,7 +218,7 @@ public class DeltaRequest implements Externalizable {
                     }
                     break;
                 default:
-                    throw new IllegalArgumentException(sm.getString("deltaRequest.invalidAttributeInfoType", info));
+                    log.warn(sm.getString("deltaRequest.invalidAttributeInfoType", info));
             }//switch
         }//for
         session.endAccess();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 7abdc17294..2925eeda67 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -141,6 +141,16 @@
       </fix>
     </changelog>
   </subsection>
+  <subsection name="Cluster">
+    <changelog>
+      <fix>
+        To aid future additions of new functionality, rather than throw an
+        <code>IllegalArgumentException</code> if a <code>DeltaRequest</code> is
+        passed an unrecognised action type, a warning message will now be
+        logged. (markt)
+      </fix>
+    </changelog>
+  </subsection>
   <subsection name="Other">
     <changelog>
       <fix>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org