You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "toyboxman (via GitHub)" <gi...@apache.org> on 2024/07/21 08:44:57 UTC
[PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
toyboxman opened a new pull request, #658:
URL: https://github.com/apache/griffin/pull/658
1.Catch up with Apache parent build latest update version-33.
2.Resolve warnings in maven build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on code in PR #658:
URL: https://github.com/apache/griffin/pull/658#discussion_r1687374157
##########
griffin-metric/pom.xml:
##########
@@ -17,24 +17,23 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache</groupId>
- <artifactId>apache</artifactId>
- <version>17</version>
- <relativePath />
+ <groupId>org.apache.griffin</groupId>
+ <artifactId>griffin</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
</parent>
- <groupId>org.apache.griffin</groupId>
+ <groupId>org.apache.griffin.metric</groupId>
Review Comment:
I think we'd better to keep the group id of all components to be `org.apache.griffin`, otherwise there will be some trouble when locating artifacts in Maven Central.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on code in PR #658:
URL: https://github.com/apache/griffin/pull/658#discussion_r1688122219
##########
griffin-metric/pom.xml:
##########
@@ -17,24 +17,23 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache</groupId>
- <artifactId>apache</artifactId>
- <version>17</version>
- <relativePath />
+ <groupId>org.apache.griffin</groupId>
+ <artifactId>griffin</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
</parent>
- <groupId>org.apache.griffin</groupId>
+ <groupId>org.apache.griffin.metric</groupId>
Review Comment:
Splitting modules makes sense to me, but I don't think it's necessary to change the group id, using different artifact id should be enough here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on PR #658:
URL: https://github.com/apache/griffin/pull/658#issuecomment-2241531532
@guoyuepeng,
the 2.0.0 pom structure has been revised and passed the compiling, could you review it?
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Griffin 2.0.0-SNAPSHOT [pom]
[INFO] griffin-connectors-2.0.0-SNAPSHOT [pom]
[INFO] griffin-metric-2.0.0-SNAPSHOT [pom]
[INFO] griffin-dqc-2.0.0-SNAPSHOT [pom]
[INFO] griffin-schedulers-2.0.0-SNAPSHOT [pom]
[INFO]
[INFO] ---------------------< org.apache.griffin:griffin >---------------------
[INFO] Building Apache Griffin 2.0.0-SNAPSHOT 2.0.0-SNAPSHOT [1/5]
[INFO] from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-maven-version) @ griffin ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion passed
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-java-version) @ griffin ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
[INFO]
[INFO] --- remote-resources:3.2.0:process (process-resource-bundles) @ griffin ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] ----------< org.apache.griffin.connectors:griffin-connectors >----------
[INFO] Building griffin-connectors-2.0.0-SNAPSHOT 2.0.0-SNAPSHOT [2/5]
[INFO] from griffin-connectors/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-maven-version) @ griffin-connectors ---
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-java-version) @ griffin-connectors ---
[INFO]
[INFO] --- remote-resources:3.2.0:process (process-resource-bundles) @ griffin-connectors ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --------------< org.apache.griffin.metric:griffin-metric >--------------
[INFO] Building griffin-metric-2.0.0-SNAPSHOT 2.0.0-SNAPSHOT [3/5]
[INFO] from griffin-metric/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-maven-version) @ griffin-metric ---
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-java-version) @ griffin-metric ---
[INFO]
[INFO] --- remote-resources:3.2.0:process (process-resource-bundles) @ griffin-metric ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] -------------< org.apache.griffin.dataquality:griffin-dqc >-------------
[INFO] Building griffin-dqc-2.0.0-SNAPSHOT 2.0.0-SNAPSHOT [4/5]
[INFO] from griffin-dqc/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-maven-version) @ griffin-dqc ---
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-java-version) @ griffin-dqc ---
[INFO]
[INFO] --- remote-resources:3.2.0:process (process-resource-bundles) @ griffin-dqc ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --------------< org.apache.griffin.schedulers:schedulers >--------------
[INFO] Building griffin-schedulers-2.0.0-SNAPSHOT 2.0.0-SNAPSHOT [5/5]
[INFO] from schedulers/pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-maven-version) @ schedulers ---
[INFO]
[INFO] --- enforcer:3.5.0:enforce (enforce-java-version) @ schedulers ---
[INFO]
[INFO] --- remote-resources:3.2.0:process (process-resource-bundles) @ schedulers ---
[INFO] Preparing remote bundle org.apache.apache.resources:apache-jar-resource-bundle:1.5
[INFO] Copying 3 resources from 1 bundle.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Griffin 2.0.0-SNAPSHOT 2.0.0-SNAPSHOT:
[INFO]
[INFO] Apache Griffin 2.0.0-SNAPSHOT ...................... SUCCESS [ 1.613 s]
[INFO] griffin-connectors-2.0.0-SNAPSHOT .................. SUCCESS [ 0.082 s]
[INFO] griffin-metric-2.0.0-SNAPSHOT ...................... SUCCESS [ 0.055 s]
[INFO] griffin-dqc-2.0.0-SNAPSHOT ......................... SUCCESS [ 0.041 s]
[INFO] griffin-schedulers-2.0.0-SNAPSHOT .................. SUCCESS [ 0.046 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.209 s
[INFO] Finished at: 2024-07-21T16:36:06+08:00
[INFO] ------------------------------------------------------------------------
Process finished with exit code 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on code in PR #658:
URL: https://github.com/apache/griffin/pull/658#discussion_r1689778186
##########
griffin-metric/pom.xml:
##########
@@ -17,24 +17,23 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache</groupId>
- <artifactId>apache</artifactId>
- <version>17</version>
- <relativePath />
+ <groupId>org.apache.griffin</groupId>
+ <artifactId>griffin</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
</parent>
- <groupId>org.apache.griffin</groupId>
+ <groupId>org.apache.griffin.metric</groupId>
Review Comment:
@whhe , agree with you. I'll keep them using a same group id.
make another PR to revise. close this one.
appreciate your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "guoyuepeng (via GitHub)" <gi...@apache.org>.
guoyuepeng commented on PR #658:
URL: https://github.com/apache/griffin/pull/658#issuecomment-2241620039
LGTM
i will update metric module this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman commented on code in PR #658:
URL: https://github.com/apache/griffin/pull/658#discussion_r1688005810
##########
griffin-metric/pom.xml:
##########
@@ -17,24 +17,23 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
-
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache</groupId>
- <artifactId>apache</artifactId>
- <version>17</version>
- <relativePath />
+ <groupId>org.apache.griffin</groupId>
+ <artifactId>griffin</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
</parent>
- <groupId>org.apache.griffin</groupId>
+ <groupId>org.apache.griffin.metric</groupId>
Review Comment:
@whhe ,
Now we are dividing the whole package into 4 individuals. those below are separated libs to offer. By @guoyuepeng new architecture, we should split the them. If you have any concern, let us know.
[INFO] griffin-connectors-2.0.0-SNAPSHOT .................. SUCCESS [ 0.082 s]
[INFO] griffin-metric-2.0.0-SNAPSHOT ...................... SUCCESS [ 0.055 s]
[INFO] griffin-dqc-2.0.0-SNAPSHOT ......................... SUCCESS [ 0.041 s]
[INFO] griffin-schedulers-2.0.0-SNAPSHOT .................. SUCCESS [ 0.046 s]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "toyboxman (via GitHub)" <gi...@apache.org>.
toyboxman closed pull request #658: Update the whole pom structure of Griffin-2.0.0
URL: https://github.com/apache/griffin/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update the whole pom structure of Griffin-2.0.0 [griffin]
Posted by "whhe (via GitHub)" <gi...@apache.org>.
whhe commented on PR #658:
URL: https://github.com/apache/griffin/pull/658#issuecomment-2244187611
I am not familiar with the previous checkstyle configuration, but I wonder if we can introduce the spotless plugin to automatically format the code, xml and markdown files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org