You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/12/04 11:03:40 UTC
[Apache Bloodhound] #285: Create prototype for improved search
archetecture
#285: Create prototype for improved search archetecture
------------------------+----------------------
Reporter: andrej | Owner: nobody
Type: enhancement | Status: new
Priority: major | Component: plugins
Version: | Resolution:
------------------------+----------------------
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004) (was: Create prototype for improved search
archetecture)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+----------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search
--------------------------+----------------------
Changes (by andrej):
* status: new => assigned
* owner: nobody => andrej
* keywords: => search
Old description:
New description:
Implement prototype phase of the improved search architecture described in
https://issues.apache.org/bloodhound/wiki/Proposals/BEP-0004#steps
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by rjollos):
r1417813 added a dependency for the tests `dutest >= 2.4`. The latest
version on PyPI is 2.3. Was this a typo, or is there a 2.4 version
available that we need to ask Olemis to upload to the
[http://pypi.python.org/pypi/dutest PyPI page]?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by olemis):
Replying to [comment:4 rjollos]:
> r1417813 added a dependency for the tests `dutest >= 2.4`. The latest
version on PyPI is 2.3. Was this a typo, or is there a 2.4 version
available that we need to ask Olemis to upload to the
[http://pypi.python.org/pypi/dutest PyPI page]?
Done !
http://pypi.python.org/pypi/dutest/0.2.4
'''PS''': I noticed that I have to document what's new in version 0.2.4
... maybe later
;)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by gjm):
I should have spotted that. I am not sure that andrej intended to specify
the testing framework and I am not convinced that we should be using
dutest anyway. Sorry olemis!
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by rjollos):
Replying to [comment:8 gjm]:
> I should have spotted that. I am not sure that andrej intended to
specify the testing framework and I am not convinced that we should be
using dutest anyway. Sorry olemis!
I had similar concerns about tossing in another dependency without at
least a thorough discussion on the mailing list of what our approach will
be for testing. I'd have the same concerns under any scenario in which we
were adding an external dependency to the project.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by peter):
r1431350 applies bloodhound_search_plugin_prototype_phase_2_-
_towards_#285.patch
There are some coding standard issues in the code outside of the patched
lines reported by pylint which should be addressed by next patch.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by gjm):
r1417813 commits patch from andrej with minor changes
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: gjm
Type: enhancement | Status: review
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Changes (by andrej):
* owner: andrej => gjm
* status: assigned => review
Comment:
r1437987 contains base prototype functionality for Bloodhound Search
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Gary Martin <ga...@wandisco.com>.
On 05/12/12 16:57, Gary Martin wrote:
> On 05/12/12 16:17, Andrej Golcov wrote:
>> Hi,
>>
>> I attached patch for initial setup of Bloodhound Search plugin. It is
>> just initial skeleton:
>> https://issues.apache.org/bloodhound/attachment/ticket/285/bloodhound_search_plugin_skeleton_towards_%23285.patch
>>
>> The idea is that, until code is stable enough, plugin exists only in
>> development environment and must be disabled by default. A developer
>> have to enable it manually.
>>
>> This is my first Bloodhound plugin and I would kindly ask to review it
>> before any additional logic is added.
>>
>> Regards, Andrej
>
> Cool.. on my habitual search for license headers, I note that
> bloodhound_search/bhsearch/templates/bhsearch.html is lacking one.
> Only a reminder really.. I'll be happy to add the appropriate text for
> you.
>
> Anyway, I'll give it a quick look over and see if I can commit it a
> bit later.
>
> Cheers,
> Gary
Right.. happy for that to go in as a start - I hope you don't mind that
I included a quick fix to make sure that the empty query doesn't result
in a complaint about concatenating strings with None.
So, that is committed in revision 1417813.
Cheers,
Gary
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Gary Martin <ga...@wandisco.com>.
On 05/12/12 16:17, Andrej Golcov wrote:
> Hi,
>
> I attached patch for initial setup of Bloodhound Search plugin. It is
> just initial skeleton:
> https://issues.apache.org/bloodhound/attachment/ticket/285/bloodhound_search_plugin_skeleton_towards_%23285.patch
> The idea is that, until code is stable enough, plugin exists only in
> development environment and must be disabled by default. A developer
> have to enable it manually.
>
> This is my first Bloodhound plugin and I would kindly ask to review it
> before any additional logic is added.
>
> Regards, Andrej
Cool.. on my habitual search for license headers, I note that
bloodhound_search/bhsearch/templates/bhsearch.html is lacking one. Only
a reminder really.. I'll be happy to add the appropriate text for you.
Anyway, I'll give it a quick look over and see if I can commit it a bit
later.
Cheers,
Gary
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Andrej Golcov <an...@digiverse.si>.
Hi,
I attached patch for initial setup of Bloodhound Search plugin. It is
just initial skeleton:
https://issues.apache.org/bloodhound/attachment/ticket/285/bloodhound_search_plugin_skeleton_towards_%23285.patch
The idea is that, until code is stable enough, plugin exists only in
development environment and must be disabled by default. A developer
have to enable it manually.
This is my first Bloodhound plugin and I would kindly ask to review it
before any additional logic is added.
Regards, Andrej
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Changes (by olemis):
* keywords: search => search bep-0004
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by peter):
An issue found with code review: TicketIndex._load_ticket_ids() uses
trac.ticket.quer.Quer() ignoring it's default paging behavior. As a result
only first 100 tickets will be indexed.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:16>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: gjm
Type: enhancement | Status: review
Priority: major | Milestone:
Component: search | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Changes (by andrej):
* component: plugins => search
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:18>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by olemis):
Replying to [comment:4 rjollos]:
> r1417813 added a dependency for the tests `dutest >= 2.4`. The latest
version on PyPI is 2.3. Was this a typo,
No .
> or is there a 2.4 version available
Yes .
> that we need to ask Olemis to upload to the
[http://pypi.python.org/pypi/dutest PyPI page]?
I'll get that done asap .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: gjm
Type: enhancement | Status: closed
Priority: major | Milestone:
Component: search | Version:
Resolution: fixed | Keywords: search bep-0004
--------------------------+-----------------------------
Changes (by gjm):
* status: review => closed
* resolution: => fixed
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:19>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by andrej):
added patch for prototype phase 2:
bloodhound_search_plugin_prototype_phase_2_-_towards_#285.patch.
What's new:
* Wiki indexing and search
* Facets support in API
* Simple tabs for different resource types e.g. Ticket, Wiki etc.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Olemis Lang <ol...@gmail.com>.
On 12/17/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #285: Create prototype for improved search architecture (BEP-0004)
> --------------------------+-----------------------------
> Reporter: andrej | Owner: andrej
> Type: enhancement | Status: assigned
> Priority: major | Milestone:
> Component: plugins | Version:
> Resolution: | Keywords: search bep-0004
> --------------------------+-----------------------------
>
> Comment (by andrej):
>
> Referencing of dutest was not intentional. That was copy-paste effect. I
> will remove referencing to dutest in next pacth.
cool
:)
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by andrej):
Referencing of dutest was not intentional. That was copy-paste effect. I
will remove referencing to dutest in next pacth. We can add dutest
reference later when it we need it.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by jure):
r1425649 commits the second patch
(bloodhound_search_plugin_prototype_phase_1_-_towards_#285.patch)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by olemis):
Replying to [comment:9 rjollos]:
> Replying to [comment:8 gjm]:
> > I should have spotted that. I am not sure that andrej intended to
specify the testing framework
that's what I thought in first place , but I had to do so anyway .
> I am not convinced that we should be using dutest anyway. Sorry olemis!
>
sorry ? I use it and it's great
;)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Changes (by olemis):
* cc: olemis+bh@… (added)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #285: Create prototype for improved search
architecture (BEP-0004)
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#285: Create prototype for improved search architecture (BEP-0004)
--------------------------+-----------------------------
Reporter: andrej | Owner: andrej
Type: enhancement | Status: assigned
Priority: major | Milestone:
Component: plugins | Version:
Resolution: | Keywords: search bep-0004
--------------------------+-----------------------------
Comment (by andrej):
added patch for prototype phase 1 implementation, more details on dev
mailing list
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/285#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker