You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "bhor-sanket (via GitHub)" <gi...@apache.org> on 2026/04/29 07:13:35 UTC
[PR] ATLAS-5279: changes for handling rename propagation [atlas]
bhor-sanket opened a new pull request, #609:
URL: https://github.com/apache/atlas/pull/609
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. ATLAS-XXXX: Fix a typo in YYY))
## How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "rkundam (via GitHub)" <gi...@apache.org>.
rkundam commented on PR #609:
URL: https://github.com/apache/atlas/pull/609#issuecomment-4633224758
Workflow triggered: https://github.com/apache/atlas/actions/runs/26159858214/job/79760865544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "pinal-shah (via GitHub)" <gi...@apache.org>.
pinal-shah commented on PR #609:
URL: https://github.com/apache/atlas/pull/609#issuecomment-4488902871
Good work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "bhor-sanket (via GitHub)" <gi...@apache.org>.
bhor-sanket commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3231420246
##########
addons/models/6000-Trino/6000-trino_model.json:
##########
@@ -25,6 +25,12 @@
"superTypes": [ "Asset" ],
"serviceType": "trino",
"typeVersion": "1.0",
+ "attributeDefOverrides": [
Review Comment:
updated ...please review now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "bhor-sanket (via GitHub)" <gi...@apache.org>.
bhor-sanket commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3231425472
##########
intg/src/main/java/org/apache/atlas/type/RenamePropagationTarget.java:
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.atlas.type;
+
+import org.apache.atlas.model.typedef.AtlasRelationshipDef.RelationshipCategory;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+
+/**
+ * Typedef-time representation of a rename propagation target for an entity type.
+ */
+public class RenamePropagationTarget {
+ private final String targetTypeName;
+ private final RelationshipCategory category;
Review Comment:
removed this unused field..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "bhor-sanket (via GitHub)" <gi...@apache.org>.
bhor-sanket commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3231429674
##########
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java:
##########
@@ -1179,6 +1180,120 @@ public PatchStatus applyPatch(TypeDefPatch patch) throws AtlasBaseException {
}
}
+ /**
+ * Applies {@code SET_ATTRIBUTE_DEF_OVERRIDES} on entity typedefs and {@code SET_PROPAGATE_RENAME} on relationship typedefs.
+ */
+ static class SetAttributeDefOverridesPatchHandler extends PatchHandler {
Review Comment:
renamed this classed as "AttributeDefOverridesAndPropagateRenamePatchHandler"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "pinal-shah (via GitHub)" <gi...@apache.org>.
pinal-shah commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3218844694
##########
addons/models/6000-Trino/patches/001-rename_propagation_typedef_patch.json:
##########
@@ -0,0 +1,29 @@
+{
Review Comment:
Do you need patch? since trino models are not yet released.
##########
addons/models/6000-Trino/6000-trino_model.json:
##########
@@ -25,6 +25,12 @@
"superTypes": [ "Asset" ],
"serviceType": "trino",
"typeVersion": "1.0",
+ "attributeDefOverrides": [
Review Comment:
Please update to trino_columns typeDef
##########
addons/models/6000-Trino/6000-trino_model.json:
##########
@@ -25,6 +25,12 @@
"superTypes": [ "Asset" ],
"serviceType": "trino",
"typeVersion": "1.0",
+ "attributeDefOverrides": [
+ {
+ "name": "qualifiedName",
+ "autoComputeFormat": "{table.trinoschema.catalog.name}.{table.trinoschema.name}.{table.name}.{name}@{table.trinoschema.catalog.instance.name}"
Review Comment:
Since ".name" we have hardcoded as the name attribute of a particular type in the processing os autoComputeFormat, Please highlight or create a doc, on how to add the format for an entityType
##########
intg/src/main/java/org/apache/atlas/type/RenamePropagationTarget.java:
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.atlas.type;
+
+import org.apache.atlas.model.typedef.AtlasRelationshipDef.RelationshipCategory;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+
+/**
+ * Typedef-time representation of a rename propagation target for an entity type.
+ */
+public class RenamePropagationTarget {
+ private final String targetTypeName;
+ private final RelationshipCategory category;
Review Comment:
please review, if this is needed.
##########
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java:
##########
@@ -1179,6 +1180,120 @@ public PatchStatus applyPatch(TypeDefPatch patch) throws AtlasBaseException {
}
}
+ /**
+ * Applies {@code SET_ATTRIBUTE_DEF_OVERRIDES} on entity typedefs and {@code SET_PROPAGATE_RENAME} on relationship typedefs.
+ */
+ static class SetAttributeDefOverridesPatchHandler extends PatchHandler {
Review Comment:
Since this class handles different actions, not just SetAttributeDefOverrides, Please rename accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "bhor-sanket (via GitHub)" <gi...@apache.org>.
bhor-sanket commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3231423907
##########
addons/models/6000-Trino/6000-trino_model.json:
##########
@@ -25,6 +25,12 @@
"superTypes": [ "Asset" ],
"serviceType": "trino",
"typeVersion": "1.0",
+ "attributeDefOverrides": [
+ {
+ "name": "qualifiedName",
+ "autoComputeFormat": "{table.trinoschema.catalog.name}.{table.trinoschema.name}.{table.name}.{name}@{table.trinoschema.catalog.instance.name}"
Review Comment:
added section "Configuring autoComputeFormat on an entity type" in readme file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "bhor-sanket (via GitHub)" <gi...@apache.org>.
bhor-sanket commented on code in PR #609:
URL: https://github.com/apache/atlas/pull/609#discussion_r3231419291
##########
addons/models/6000-Trino/patches/001-rename_propagation_typedef_patch.json:
##########
@@ -0,0 +1,29 @@
+{
Review Comment:
As discussed offline, keeping this file to support upgrade scenarios for environments already running with the Trino setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ATLAS-5279: changes for handling rename propagation [atlas]
Posted by "chaitalicod (via GitHub)" <gi...@apache.org>.
chaitalicod merged PR #609:
URL: https://github.com/apache/atlas/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@atlas.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org