You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2012/07/11 12:22:33 UTC
Review Request: CS-15048: Log rotation functionality in system VMs is broken
resuting in 100% of disk space getting consumed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5907/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Changes done: Modified log4j.xml to restrict the growing of file size depending upon the total size.Defaulting it to 10MB for each log file and keeping a maximum backup of 4 files.
(Path for the log files and rotation policy was not configured correctly).
Diffs
-----
build/deploy/production/server/conf/log4j-cloud.xml 1b56396
Diff: https://reviews.apache.org/r/5907/diff/
Testing
-------
Tested the same changes on log4j-cloud.xml config file present in the system vms.Verified the 3 files /var/log/cloud.log, /var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
were rotated correctly.
Thanks,
Saksham Srivastava
Re: Review Request: CS-15048: Log rotation functionality in system VMs is
broken resuting in 100% of disk space getting consumed.
Posted by disheng su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5907/#review9420
-----------------------------------------------------------
Ship it!
Ship It!
- disheng su
On July 11, 2012, 10:23 a.m., Saksham Srivastava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5907/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 10:23 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Changes done: Modified log4j.xml to restrict the growing of file size depending upon the total size.Defaulting it to 10MB for each log file and keeping a maximum backup of 4 files.
> (Path for the log files and rotation policy was not configured correctly).
>
>
> Diffs
> -----
>
> build/deploy/production/server/conf/log4j-cloud.xml 1b56396
>
> Diff: https://reviews.apache.org/r/5907/diff/
>
>
> Testing
> -------
>
> Tested the same changes on log4j-cloud.xml config file present in the system vms.Verified the 3 files /var/log/cloud.log, /var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
> were rotated correctly.
>
>
> Thanks,
>
> Saksham Srivastava
>
>
Re: system vm logging
Posted by Chiradeep Vittal <Ch...@citrix.com>.
It has been considered, not implemented yet
http://bugs.cloudstack.org/browse/CS-9669
On 7/12/12 11:45 AM, "David Nalley" <da...@gnsa.us> wrote:
>On Thu, Jul 12, 2012 at 2:42 PM, Chiradeep Vittal
><Ch...@citrix.com> wrote:
>> According to
>>
>>https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=tree
>>;f
>>
>>=patches/systemvm/debian/config/etc/cron.daily;h=e28877633af747315ca525d8
>>66
>> 208bc6f8bfae03;hb=HEAD
>>
>>
>> All log files in /var/log/cloud that are older than 7 days will be
>> deleted.
>> Logrotate has been configured to roll over other system logs (e.g.,
>> HAProxy)
>>
>
>So just a nitpicking tangent/question. Why do we maintain stateful
>data (logs) on VMs that are effectively designed to be
>stateless....should our preference become to send those off the VM to
>a syslog server (and make that a configuration option?) and not have
>any logs on the machine at all, or perhaps just a small subset (last
>24 hours incase things go horribly wrong and network or syslog server
>dies)
>
>--David
Re: Review Request: CS-15048: Log rotation functionality in system
VMs is broken resuting in 100% of disk space getting consumed.
Posted by David Nalley <da...@gnsa.us>.
On Thu, Jul 12, 2012 at 2:42 PM, Chiradeep Vittal
<Ch...@citrix.com> wrote:
> According to
> https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=tree;f
> =patches/systemvm/debian/config/etc/cron.daily;h=e28877633af747315ca525d866
> 208bc6f8bfae03;hb=HEAD
>
>
> All log files in /var/log/cloud that are older than 7 days will be
> deleted.
> Logrotate has been configured to roll over other system logs (e.g.,
> HAProxy)
>
So just a nitpicking tangent/question. Why do we maintain stateful
data (logs) on VMs that are effectively designed to be
stateless....should our preference become to send those off the VM to
a syslog server (and make that a configuration option?) and not have
any logs on the machine at all, or perhaps just a small subset (last
24 hours incase things go horribly wrong and network or syslog server
dies)
--David
Re: Review Request: CS-15048: Log rotation functionality in system
VMs is broken resuting in 100% of disk space getting consumed.
Posted by Chiradeep Vittal <Ch...@citrix.com>.
According to
https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=tree;f
=patches/systemvm/debian/config/etc/cron.daily;h=e28877633af747315ca525d866
208bc6f8bfae03;hb=HEAD
All log files in /var/log/cloud that are older than 7 days will be
deleted.
Logrotate has been configured to roll over other system logs (e.g.,
HAProxy)
On 7/12/12 3:52 AM, "Somesh Naidu" <So...@citrix.com> wrote:
>That's true. Since you don't have any Cloudstack agent/service running on
>the VR you won't find any Cloudstack specific log files on it.
>
>Regards,
>Somesh
>
>
>-----Original Message-----
>From: Saksham Srivastava [mailto:saksham.srivastava@citrix.com]
>Sent: Thursday, July 12, 2012 3:50 PM
>To: Sanjeev Neelarapu
>Cc: cloudstack-dev@incubator.apache.org
>Subject: Re: Review Request: CS-15048: Log rotation functionality in
>system VMs is broken resuting in 100% of disk space getting consumed.
>
>Currently I didn't find log4j configuration file on virtual router so it
>should not be applicable to Virtual Router.The bug and the fixes are
>particular to Secondary storage VM and Console proxy VM.
>
>Thanks,
>Saksham
>
>On Thursday 12 July 2012 02:48 PM, Sanjeev Neelarapu wrote:
>> Is this applicable to Virtual Router as well?
>>
>> -----Original Message-----
>> From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf
>>Of Saksham Srivastava
>> Sent: Wednesday, July 11, 2012 3:53 PM
>> To: Saksham Srivastava; cloudstack
>> Subject: Re: Review Request: CS-15048: Log rotation functionality in
>>system VMs is broken resuting in 100% of disk space getting consumed.
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/5907/
>> -----------------------------------------------------------
>>
>> (Updated July 11, 2012, 10:23 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Description (updated)
>> -------
>>
>> Changes done: Modified log4j.xml to restrict the growing of file size
>>depending upon the total size.Defaulting it to 10MB for each log file
>>and keeping a maximum backup of 4 files.
>> (Path for the log files and rotation policy was not configured
>>correctly).
>>
>>
>> Diffs
>> -----
>>
>> build/deploy/production/server/conf/log4j-cloud.xml 1b56396
>>
>> Diff: https://reviews.apache.org/r/5907/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested the same changes on log4j-cloud.xml config file present in the
>>system vms.Verified the 3 files /var/log/cloud.log,
>>/var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
>> were rotated correctly.
>>
>>
>> Thanks,
>>
>> Saksham Srivastava
>>
>
>
RE: Review Request: CS-15048: Log rotation functionality in system
VMs is broken resuting in 100% of disk space getting consumed.
Posted by Somesh Naidu <So...@citrix.com>.
That's true. Since you don't have any Cloudstack agent/service running on the VR you won't find any Cloudstack specific log files on it.
Regards,
Somesh
-----Original Message-----
From: Saksham Srivastava [mailto:saksham.srivastava@citrix.com]
Sent: Thursday, July 12, 2012 3:50 PM
To: Sanjeev Neelarapu
Cc: cloudstack-dev@incubator.apache.org
Subject: Re: Review Request: CS-15048: Log rotation functionality in system VMs is broken resuting in 100% of disk space getting consumed.
Currently I didn't find log4j configuration file on virtual router so it
should not be applicable to Virtual Router.The bug and the fixes are
particular to Secondary storage VM and Console proxy VM.
Thanks,
Saksham
On Thursday 12 July 2012 02:48 PM, Sanjeev Neelarapu wrote:
> Is this applicable to Virtual Router as well?
>
> -----Original Message-----
> From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf Of Saksham Srivastava
> Sent: Wednesday, July 11, 2012 3:53 PM
> To: Saksham Srivastava; cloudstack
> Subject: Re: Review Request: CS-15048: Log rotation functionality in system VMs is broken resuting in 100% of disk space getting consumed.
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5907/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 10:23 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description (updated)
> -------
>
> Changes done: Modified log4j.xml to restrict the growing of file size depending upon the total size.Defaulting it to 10MB for each log file and keeping a maximum backup of 4 files.
> (Path for the log files and rotation policy was not configured correctly).
>
>
> Diffs
> -----
>
> build/deploy/production/server/conf/log4j-cloud.xml 1b56396
>
> Diff: https://reviews.apache.org/r/5907/diff/
>
>
> Testing
> -------
>
> Tested the same changes on log4j-cloud.xml config file present in the system vms.Verified the 3 files /var/log/cloud.log, /var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
> were rotated correctly.
>
>
> Thanks,
>
> Saksham Srivastava
>
Re: Review Request: CS-15048: Log rotation functionality in system
VMs is broken resuting in 100% of disk space getting consumed.
Posted by Saksham Srivastava <sa...@citrix.com>.
Currently I didn't find log4j configuration file on virtual router so it
should not be applicable to Virtual Router.The bug and the fixes are
particular to Secondary storage VM and Console proxy VM.
Thanks,
Saksham
On Thursday 12 July 2012 02:48 PM, Sanjeev Neelarapu wrote:
> Is this applicable to Virtual Router as well?
>
> -----Original Message-----
> From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf Of Saksham Srivastava
> Sent: Wednesday, July 11, 2012 3:53 PM
> To: Saksham Srivastava; cloudstack
> Subject: Re: Review Request: CS-15048: Log rotation functionality in system VMs is broken resuting in 100% of disk space getting consumed.
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5907/
> -----------------------------------------------------------
>
> (Updated July 11, 2012, 10:23 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description (updated)
> -------
>
> Changes done: Modified log4j.xml to restrict the growing of file size depending upon the total size.Defaulting it to 10MB for each log file and keeping a maximum backup of 4 files.
> (Path for the log files and rotation policy was not configured correctly).
>
>
> Diffs
> -----
>
> build/deploy/production/server/conf/log4j-cloud.xml 1b56396
>
> Diff: https://reviews.apache.org/r/5907/diff/
>
>
> Testing
> -------
>
> Tested the same changes on log4j-cloud.xml config file present in the system vms.Verified the 3 files /var/log/cloud.log, /var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
> were rotated correctly.
>
>
> Thanks,
>
> Saksham Srivastava
>
RE: Review Request: CS-15048: Log rotation functionality in system
VMs is broken resuting in 100% of disk space getting consumed.
Posted by Sanjeev Neelarapu <sa...@citrix.com>.
Is this applicable to Virtual Router as well?
-----Original Message-----
From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On Behalf Of Saksham Srivastava
Sent: Wednesday, July 11, 2012 3:53 PM
To: Saksham Srivastava; cloudstack
Subject: Re: Review Request: CS-15048: Log rotation functionality in system VMs is broken resuting in 100% of disk space getting consumed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5907/
-----------------------------------------------------------
(Updated July 11, 2012, 10:23 a.m.)
Review request for cloudstack.
Description (updated)
-------
Changes done: Modified log4j.xml to restrict the growing of file size depending upon the total size.Defaulting it to 10MB for each log file and keeping a maximum backup of 4 files.
(Path for the log files and rotation policy was not configured correctly).
Diffs
-----
build/deploy/production/server/conf/log4j-cloud.xml 1b56396
Diff: https://reviews.apache.org/r/5907/diff/
Testing
-------
Tested the same changes on log4j-cloud.xml config file present in the system vms.Verified the 3 files /var/log/cloud.log, /var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
were rotated correctly.
Thanks,
Saksham Srivastava
Re: Review Request: CS-15048: Log rotation functionality in system VMs is
broken resuting in 100% of disk space getting consumed.
Posted by Saksham Srivastava <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5907/
-----------------------------------------------------------
(Updated July 11, 2012, 10:23 a.m.)
Review request for cloudstack.
Description (updated)
-------
Changes done: Modified log4j.xml to restrict the growing of file size depending upon the total size.Defaulting it to 10MB for each log file and keeping a maximum backup of 4 files.
(Path for the log files and rotation policy was not configured correctly).
Diffs
-----
build/deploy/production/server/conf/log4j-cloud.xml 1b56396
Diff: https://reviews.apache.org/r/5907/diff/
Testing
-------
Tested the same changes on log4j-cloud.xml config file present in the system vms.Verified the 3 files /var/log/cloud.log, /var/log/cloud/cloud.out and /usr/local/cloud/systemvm/cloud.log
were rotated correctly.
Thanks,
Saksham Srivastava