You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/03 13:21:28 UTC
[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request
#19: Add release script
kezhenxu94 commented on a change in pull request #19: Add release script
URL: https://github.com/apache/skywalking-cli/pull/19#discussion_r353173263
##########
File path: Makefile
##########
@@ -79,5 +82,29 @@ coverage: test
.PHONY: clean
clean:
$(GO_CLEAN) ./...
- -rm -rf ./bin
+ -rm -rf bin
-rm -rf coverage.txt
+ -rm -rf *.tgz
+ -rm -rf *.tgz
+ -rm -rf *.asc
+ -rm -rf *.sha512
+
+release-src: clean
+ -tar -zcvf $(RELEASE_SRC).tgz \
+ --exclude bin \
+ --exclude .git \
+ --exclude .idea \
+ --exclude .DS_Store \
+ --exclude .github \
+ --exclude $(RELEASE_SRC).tgz \
Review comment:
> Do we need any tips about this is only working in MacOS? Because AFAIK, `--exclude` is only working on MacOS. :)
I run `make release` in a Linux docker container, it works fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services