[GitHub] [incubator-shenyu] tydhot commented on a change in pull request #1722: [ISSUE #1721] Add test case for param-mapping and remove the cache module of plugins

[GitBox <gi...@apache.org>]

tydhot commented on a change in pull request #1722:
URL: https://github.com/apache/incubator-shenyu/pull/1722#discussion_r664033663



##########
File path: shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/utils/BeanHolder.java
##########
@@ -15,37 +15,58 @@
  * limitations under the License.
  */
 
-package org.apache.shenyu.plugin.waf.cache;
+package org.apache.shenyu.plugin.base.utils;
 
-import lombok.extern.slf4j.Slf4j;
-import org.apache.shenyu.common.dto.convert.WafHandle;
-import org.apache.shenyu.plugin.base.cache.BaseHandleCache;
+import java.util.function.Supplier;
 
 /**
- * The rule handle cache.
+ * Bean holder.
+ *
+ * @param <O> o
  */
-@Slf4j
-public final class WafRuleHandleCache extends BaseHandleCache<String, WafHandle> {
+public class BeanHolder<O> implements Supplier<O> {
+
+    private Supplier<O> supplier;
+
+    private O o;

Review comment:
       I think it should be volatile here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org