[jira] [Comment Edited] (YARN-6984) DominantResourceCalculator.isAnyMajorResourceZero() should test all resources

["Daniel Templeton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215716#comment-16215716 ] 

Daniel Templeton edited comment on YARN-6984 at 10/23/17 7:33 PM:
------------------------------------------------------------------

LGTM except that checkstyle has a legit gripe.  Fix that, and you're good to go.


was (Author: templedf):
LGTM +1

> DominantResourceCalculator.isAnyMajorResourceZero() should test all resources
> -----------------------------------------------------------------------------
>
>                 Key: YARN-6984
>                 URL: https://issues.apache.org/jira/browse/YARN-6984
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: scheduler
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Sunil G
>         Attachments: YARN-6984.001.patch
>
>
> The method currently tests only memory and CPU.  It looks to me like it should test all resources, i.e. it should do what {{isInvalidDivisor()}} does and should, in fact, replace that method.  [~sunilg], since you wrote the method originally, can you comment on what its intended semantics are?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org