You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/18 17:00:22 UTC
[GitHub] [helix] NealSun96 commented on issue #902: Fix setRoutingData
boolean handling; fix leader forwarding url construction
NealSun96 commented on issue #902: Fix setRoutingData boolean handling; fix leader forwarding url construction
URL: https://github.com/apache/helix/pull/902#issuecomment-600748661
This PR is ready to be merged, approved by @narendly
Final commit message:
## Fix setRoutingData boolean handling; fix leader forwarding url construction ##
This PR makes SetRoutingData respect the return value of the underlying function; it also fixes request forwarding urls, allowing ports and endpoint prefixes to be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org