You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2013/04/06 08:06:09 UTC

svn commit: r1465198 [17/41] - in /hbase/hbase.apache.org/trunk: ./ css/ hbase-assembly/ images/ xref-test/ xref-test/org/apache/hadoop/hbase/ xref-test/org/apache/hadoop/hbase/client/ xref-test/org/apache/hadoop/hbase/client/replication/ xref-test/org...

Modified: hbase/hbase.apache.org/trunk/xref-test/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html
URL: http://svn.apache.org/viewvc/hbase/hbase.apache.org/trunk/xref-test/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html?rev=1465198&r1=1465197&r2=1465198&view=diff
==============================================================================
--- hbase/hbase.apache.org/trunk/xref-test/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html (original)
+++ hbase/hbase.apache.org/trunk/xref-test/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html Sat Apr  6 06:06:07 2013
@@ -65,359 +65,361 @@
 <a class="jxr_linenumber" name="55" href="#55">55</a>  <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.Bytes;
 <a class="jxr_linenumber" name="56" href="#56">56</a>  <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.FSTableDescriptors;
 <a class="jxr_linenumber" name="57" href="#57">57</a>  <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.FSUtils;
-<a class="jxr_linenumber" name="58" href="#58">58</a>  <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.HBaseFsck;
-<a class="jxr_linenumber" name="59" href="#59">59</a>  <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.JVMClusterUtil.RegionServerThread;
-<a class="jxr_linenumber" name="60" href="#60">60</a>  <strong class="jxr_keyword">import</strong> org.apache.log4j.Level;
-<a class="jxr_linenumber" name="61" href="#61">61</a>  <strong class="jxr_keyword">import</strong> org.junit.After;
-<a class="jxr_linenumber" name="62" href="#62">62</a>  <strong class="jxr_keyword">import</strong> org.junit.AfterClass;
-<a class="jxr_linenumber" name="63" href="#63">63</a>  <strong class="jxr_keyword">import</strong> org.junit.Before;
-<a class="jxr_linenumber" name="64" href="#64">64</a>  <strong class="jxr_keyword">import</strong> org.junit.BeforeClass;
-<a class="jxr_linenumber" name="65" href="#65">65</a>  <strong class="jxr_keyword">import</strong> org.junit.Test;
-<a class="jxr_linenumber" name="66" href="#66">66</a>  <strong class="jxr_keyword">import</strong> org.junit.experimental.categories.Category;
-<a class="jxr_linenumber" name="67" href="#67">67</a>  
-<a class="jxr_linenumber" name="68" href="#68">68</a>  <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="69" href="#69">69</a>  <em class="jxr_javadoccomment"> * Test creating/using/deleting snapshots from the client</em>
-<a class="jxr_linenumber" name="70" href="#70">70</a>  <em class="jxr_javadoccomment"> * &lt;p&gt;</em>
-<a class="jxr_linenumber" name="71" href="#71">71</a>  <em class="jxr_javadoccomment"> * This is an end-to-end test for the snapshot utility</em>
-<a class="jxr_linenumber" name="72" href="#72">72</a>  <em class="jxr_javadoccomment"> *</em>
-<a class="jxr_linenumber" name="73" href="#73">73</a>  <em class="jxr_javadoccomment"> * TODO This is essentially a clone of TestSnapshotFromClient.  This is worth refactoring this</em>
-<a class="jxr_linenumber" name="74" href="#74">74</a>  <em class="jxr_javadoccomment"> * because there will be a few more flavors of snapshots that need to run these tests.</em>
-<a class="jxr_linenumber" name="75" href="#75">75</a>  <em class="jxr_javadoccomment"> */</em>
-<a class="jxr_linenumber" name="76" href="#76">76</a>  @Category(LargeTests.<strong class="jxr_keyword">class</strong>)
-<a class="jxr_linenumber" name="77" href="#77">77</a>  <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">class</strong> <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">TestFlushSnapshotFromClient</a> {
-<a class="jxr_linenumber" name="78" href="#78">78</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> Log LOG = LogFactory.getLog(TestFlushSnapshotFromClient.<strong class="jxr_keyword">class</strong>);
-<a class="jxr_linenumber" name="79" href="#79">79</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html">HBaseTestingUtility</a> UTIL = <strong class="jxr_keyword">new</strong> <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html">HBaseTestingUtility</a>();
-<a class="jxr_linenumber" name="80" href="#80">80</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> <strong class="jxr_keyword">int</strong> NUM_RS = 2;
-<a class="jxr_linenumber" name="81" href="#81">81</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String STRING_TABLE_NAME = <span class="jxr_string">"test"</span>;
-<a class="jxr_linenumber" name="82" href="#82">82</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] TEST_FAM = Bytes.toBytes(<span class="jxr_string">"fam"</span>);
-<a class="jxr_linenumber" name="83" href="#83">83</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] TABLE_NAME = Bytes.toBytes(STRING_TABLE_NAME);
-<a class="jxr_linenumber" name="84" href="#84">84</a>  
-<a class="jxr_linenumber" name="85" href="#85">85</a>    <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="86" href="#86">86</a>  <em class="jxr_javadoccomment">   * Setup the config for the cluster</em>
-<a class="jxr_linenumber" name="87" href="#87">87</a>  <em class="jxr_javadoccomment">   * @throws Exception on failure</em>
-<a class="jxr_linenumber" name="88" href="#88">88</a>  <em class="jxr_javadoccomment">   */</em>
-<a class="jxr_linenumber" name="89" href="#89">89</a>    @BeforeClass
-<a class="jxr_linenumber" name="90" href="#90">90</a>    <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">void</strong> setupCluster() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="91" href="#91">91</a>      ((Log4JLogger)HBaseServer.LOG).getLogger().setLevel(Level.ALL);
-<a class="jxr_linenumber" name="92" href="#92">92</a>      ((Log4JLogger)HBaseClient.LOG).getLogger().setLevel(Level.ALL);
-<a class="jxr_linenumber" name="93" href="#93">93</a>      ((Log4JLogger)ScannerCallable.LOG).getLogger().setLevel(Level.ALL);
-<a class="jxr_linenumber" name="94" href="#94">94</a>      setupConf(UTIL.getConfiguration());
-<a class="jxr_linenumber" name="95" href="#95">95</a>      UTIL.startMiniCluster(NUM_RS);
-<a class="jxr_linenumber" name="96" href="#96">96</a>    }
-<a class="jxr_linenumber" name="97" href="#97">97</a>  
-<a class="jxr_linenumber" name="98" href="#98">98</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">void</strong> setupConf(Configuration conf) {
-<a class="jxr_linenumber" name="99" href="#99">99</a>      <em class="jxr_comment">// disable the ui</em>
-<a class="jxr_linenumber" name="100" href="#100">100</a>     conf.setInt(<span class="jxr_string">"hbase.regionsever.info.port"</span>, -1);
-<a class="jxr_linenumber" name="101" href="#101">101</a>     <em class="jxr_comment">// change the flush size to a small amount, regulating number of store files</em>
-<a class="jxr_linenumber" name="102" href="#102">102</a>     conf.setInt(<span class="jxr_string">"hbase.hregion.memstore.flush.size"</span>, 25000);
-<a class="jxr_linenumber" name="103" href="#103">103</a>     <em class="jxr_comment">// so make sure we get a compaction when doing a load, but keep around some</em>
-<a class="jxr_linenumber" name="104" href="#104">104</a>     <em class="jxr_comment">// files in the store</em>
-<a class="jxr_linenumber" name="105" href="#105">105</a>     conf.setInt(<span class="jxr_string">"hbase.hstore.compaction.min"</span>, 10);
-<a class="jxr_linenumber" name="106" href="#106">106</a>     conf.setInt(<span class="jxr_string">"hbase.hstore.compactionThreshold"</span>, 10);
-<a class="jxr_linenumber" name="107" href="#107">107</a>     <em class="jxr_comment">// block writes if we get to 12 store files</em>
-<a class="jxr_linenumber" name="108" href="#108">108</a>     conf.setInt(<span class="jxr_string">"hbase.hstore.blockingStoreFiles"</span>, 12);
-<a class="jxr_linenumber" name="109" href="#109">109</a>     <em class="jxr_comment">// drop the number of attempts for the hbase admin</em>
-<a class="jxr_linenumber" name="110" href="#110">110</a>     conf.setInt(<span class="jxr_string">"hbase.client.retries.number"</span>, 1);
-<a class="jxr_linenumber" name="111" href="#111">111</a>     <em class="jxr_comment">// Enable snapshot</em>
-<a class="jxr_linenumber" name="112" href="#112">112</a>     conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, <strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="113" href="#113">113</a>     conf.set(HConstants.HBASE_REGION_SPLIT_POLICY_KEY,
-<a class="jxr_linenumber" name="114" href="#114">114</a>       ConstantSizeRegionSplitPolicy.<strong class="jxr_keyword">class</strong>.getName());
-<a class="jxr_linenumber" name="115" href="#115">115</a>   }
-<a class="jxr_linenumber" name="116" href="#116">116</a> 
-<a class="jxr_linenumber" name="117" href="#117">117</a>   @Before
-<a class="jxr_linenumber" name="118" href="#118">118</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> setup() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="119" href="#119">119</a>     UTIL.createTable(TABLE_NAME, TEST_FAM);
-<a class="jxr_linenumber" name="120" href="#120">120</a>   }
-<a class="jxr_linenumber" name="121" href="#121">121</a> 
-<a class="jxr_linenumber" name="122" href="#122">122</a>   @After
-<a class="jxr_linenumber" name="123" href="#123">123</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> tearDown() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="124" href="#124">124</a>     UTIL.deleteTable(TABLE_NAME);
-<a class="jxr_linenumber" name="125" href="#125">125</a>     <em class="jxr_comment">// and cleanup the archive directory</em>
-<a class="jxr_linenumber" name="126" href="#126">126</a>     <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="127" href="#127">127</a>       UTIL.getTestFileSystem().delete(<strong class="jxr_keyword">new</strong> Path(UTIL.getDefaultRootDirPath(), <span class="jxr_string">".archive"</span>), <strong class="jxr_keyword">true</strong>);
-<a class="jxr_linenumber" name="128" href="#128">128</a>     } <strong class="jxr_keyword">catch</strong> (IOException e) {
-<a class="jxr_linenumber" name="129" href="#129">129</a>       LOG.warn(<span class="jxr_string">"Failure to delete archive directory"</span>, e);
-<a class="jxr_linenumber" name="130" href="#130">130</a>     }
-<a class="jxr_linenumber" name="131" href="#131">131</a>   }
-<a class="jxr_linenumber" name="132" href="#132">132</a> 
-<a class="jxr_linenumber" name="133" href="#133">133</a>   @AfterClass
-<a class="jxr_linenumber" name="134" href="#134">134</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">void</strong> cleanupTest() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="135" href="#135">135</a>     <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="136" href="#136">136</a>       UTIL.shutdownMiniCluster();
-<a class="jxr_linenumber" name="137" href="#137">137</a>     } <strong class="jxr_keyword">catch</strong> (Exception e) {
-<a class="jxr_linenumber" name="138" href="#138">138</a>       LOG.warn(<span class="jxr_string">"failure shutting down cluster"</span>, e);
-<a class="jxr_linenumber" name="139" href="#139">139</a>     }
-<a class="jxr_linenumber" name="140" href="#140">140</a>   }
-<a class="jxr_linenumber" name="141" href="#141">141</a> 
-<a class="jxr_linenumber" name="142" href="#142">142</a>   <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="143" href="#143">143</a> <em class="jxr_javadoccomment">   * Test simple flush snapshotting a table that is online</em>
-<a class="jxr_linenumber" name="144" href="#144">144</a> <em class="jxr_javadoccomment">   * @throws Exception</em>
-<a class="jxr_linenumber" name="145" href="#145">145</a> <em class="jxr_javadoccomment">   */</em>
-<a class="jxr_linenumber" name="146" href="#146">146</a>   @Test
-<a class="jxr_linenumber" name="147" href="#147">147</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testFlushTableSnapshot() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="148" href="#148">148</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
-<a class="jxr_linenumber" name="149" href="#149">149</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
-<a class="jxr_linenumber" name="150" href="#150">150</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="151" href="#151">151</a> 
-<a class="jxr_linenumber" name="152" href="#152">152</a>     <em class="jxr_comment">// put some stuff in the table</em>
-<a class="jxr_linenumber" name="153" href="#153">153</a>     HTable table = <strong class="jxr_keyword">new</strong> HTable(UTIL.getConfiguration(), TABLE_NAME);
-<a class="jxr_linenumber" name="154" href="#154">154</a>     UTIL.loadTable(table, TEST_FAM);
-<a class="jxr_linenumber" name="155" href="#155">155</a> 
-<a class="jxr_linenumber" name="156" href="#156">156</a>     <em class="jxr_comment">// get the name of all the regionservers hosting the snapshotted table</em>
-<a class="jxr_linenumber" name="157" href="#157">157</a>     Set&lt;String&gt; snapshotServers = <strong class="jxr_keyword">new</strong> HashSet&lt;String&gt;();
-<a class="jxr_linenumber" name="158" href="#158">158</a>     List&lt;RegionServerThread&gt; servers = UTIL.getMiniHBaseCluster().getLiveRegionServerThreads();
-<a class="jxr_linenumber" name="159" href="#159">159</a>     <strong class="jxr_keyword">for</strong> (RegionServerThread server : servers) {
-<a class="jxr_linenumber" name="160" href="#160">160</a>       <strong class="jxr_keyword">if</strong> (server.getRegionServer().getOnlineRegions(TABLE_NAME).size() &gt; 0) {
-<a class="jxr_linenumber" name="161" href="#161">161</a>         snapshotServers.add(server.getRegionServer().getServerName().toString());
-<a class="jxr_linenumber" name="162" href="#162">162</a>       }
-<a class="jxr_linenumber" name="163" href="#163">163</a>     }
-<a class="jxr_linenumber" name="164" href="#164">164</a> 
-<a class="jxr_linenumber" name="165" href="#165">165</a>     LOG.debug(<span class="jxr_string">"FS state before snapshot:"</span>);
-<a class="jxr_linenumber" name="166" href="#166">166</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
-<a class="jxr_linenumber" name="167" href="#167">167</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
-<a class="jxr_linenumber" name="168" href="#168">168</a> 
-<a class="jxr_linenumber" name="169" href="#169">169</a>     <em class="jxr_comment">// take a snapshot of the enabled table</em>
-<a class="jxr_linenumber" name="170" href="#170">170</a>     String snapshotString = <span class="jxr_string">"offlineTableSnapshot"</span>;
-<a class="jxr_linenumber" name="171" href="#171">171</a>     byte[] snapshot = Bytes.toBytes(snapshotString);
-<a class="jxr_linenumber" name="172" href="#172">172</a>     admin.snapshot(snapshotString, STRING_TABLE_NAME, SnapshotDescription.Type.FLUSH);
-<a class="jxr_linenumber" name="173" href="#173">173</a>     LOG.debug(<span class="jxr_string">"Snapshot completed."</span>);
-<a class="jxr_linenumber" name="174" href="#174">174</a> 
-<a class="jxr_linenumber" name="175" href="#175">175</a>     <em class="jxr_comment">// make sure we have the snapshot</em>
-<a class="jxr_linenumber" name="176" href="#176">176</a>     List&lt;SnapshotDescription&gt; snapshots = SnapshotTestingUtils.assertOneSnapshotThatMatches(admin,
-<a class="jxr_linenumber" name="177" href="#177">177</a>       snapshot, TABLE_NAME);
-<a class="jxr_linenumber" name="178" href="#178">178</a> 
-<a class="jxr_linenumber" name="179" href="#179">179</a>     <em class="jxr_comment">// make sure its a valid snapshot</em>
-<a class="jxr_linenumber" name="180" href="#180">180</a>     FileSystem fs = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getFileSystem();
-<a class="jxr_linenumber" name="181" href="#181">181</a>     Path rootDir = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
-<a class="jxr_linenumber" name="182" href="#182">182</a>     LOG.debug(<span class="jxr_string">"FS state after snapshot:"</span>);
-<a class="jxr_linenumber" name="183" href="#183">183</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
-<a class="jxr_linenumber" name="184" href="#184">184</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
-<a class="jxr_linenumber" name="185" href="#185">185</a> 
-<a class="jxr_linenumber" name="186" href="#186">186</a>     SnapshotTestingUtils.confirmSnapshotValid(snapshots.get(0), TABLE_NAME, TEST_FAM, rootDir,
-<a class="jxr_linenumber" name="187" href="#187">187</a>       admin, fs, false, <strong class="jxr_keyword">new</strong> Path(rootDir, HConstants.HREGION_LOGDIR_NAME), snapshotServers);
-<a class="jxr_linenumber" name="188" href="#188">188</a> 
-<a class="jxr_linenumber" name="189" href="#189">189</a>     admin.deleteSnapshot(snapshot);
-<a class="jxr_linenumber" name="190" href="#190">190</a>     snapshots = admin.listSnapshots();
-<a class="jxr_linenumber" name="191" href="#191">191</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="192" href="#192">192</a>   }
-<a class="jxr_linenumber" name="193" href="#193">193</a> 
-<a class="jxr_linenumber" name="194" href="#194">194</a>   @Test
-<a class="jxr_linenumber" name="195" href="#195">195</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSnapshotFailsOnNonExistantTable() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="196" href="#196">196</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
-<a class="jxr_linenumber" name="197" href="#197">197</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
-<a class="jxr_linenumber" name="198" href="#198">198</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="199" href="#199">199</a>     String tableName = <span class="jxr_string">"_not_a_table"</span>;
-<a class="jxr_linenumber" name="200" href="#200">200</a> 
-<a class="jxr_linenumber" name="201" href="#201">201</a>     <em class="jxr_comment">// make sure the table doesn't exist</em>
-<a class="jxr_linenumber" name="202" href="#202">202</a>     <strong class="jxr_keyword">boolean</strong> fail = false;
-<a class="jxr_linenumber" name="203" href="#203">203</a>     <strong class="jxr_keyword">do</strong> {
-<a class="jxr_linenumber" name="204" href="#204">204</a>     <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="205" href="#205">205</a>       admin.getTableDescriptor(Bytes.toBytes(tableName));
-<a class="jxr_linenumber" name="206" href="#206">206</a>       fail = <strong class="jxr_keyword">true</strong>;
-<a class="jxr_linenumber" name="207" href="#207">207</a>           LOG.error(<span class="jxr_string">"Table:"</span> + tableName + <span class="jxr_string">" already exists, checking a new name"</span>);
-<a class="jxr_linenumber" name="208" href="#208">208</a>       tableName = tableName+<span class="jxr_string">"!"</span>;
-<a class="jxr_linenumber" name="209" href="#209">209</a>     } <strong class="jxr_keyword">catch</strong> (TableNotFoundException e) {
-<a class="jxr_linenumber" name="210" href="#210">210</a>       fail = false;
-<a class="jxr_linenumber" name="211" href="#211">211</a>       }
-<a class="jxr_linenumber" name="212" href="#212">212</a>     } <strong class="jxr_keyword">while</strong> (fail);
-<a class="jxr_linenumber" name="213" href="#213">213</a> 
-<a class="jxr_linenumber" name="214" href="#214">214</a>     <em class="jxr_comment">// snapshot the non-existant table</em>
-<a class="jxr_linenumber" name="215" href="#215">215</a>     <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="216" href="#216">216</a>       admin.snapshot(<span class="jxr_string">"fail"</span>, tableName, SnapshotDescription.Type.FLUSH);
-<a class="jxr_linenumber" name="217" href="#217">217</a>       fail(<span class="jxr_string">"Snapshot succeeded even though there is not table."</span>);
-<a class="jxr_linenumber" name="218" href="#218">218</a>     } <strong class="jxr_keyword">catch</strong> (SnapshotCreationException e) {
-<a class="jxr_linenumber" name="219" href="#219">219</a>       LOG.info(<span class="jxr_string">"Correctly failed to snapshot a non-existant table:"</span> + e.getMessage());
-<a class="jxr_linenumber" name="220" href="#220">220</a>     }
-<a class="jxr_linenumber" name="221" href="#221">221</a>   }
-<a class="jxr_linenumber" name="222" href="#222">222</a> 
-<a class="jxr_linenumber" name="223" href="#223">223</a>   @Test(timeout = 15000)
-<a class="jxr_linenumber" name="224" href="#224">224</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testAsyncFlushSnapshot() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="225" href="#225">225</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
-<a class="jxr_linenumber" name="226" href="#226">226</a>     SnapshotDescription snapshot = SnapshotDescription.newBuilder().setName(<span class="jxr_string">"asyncSnapshot"</span>)
-<a class="jxr_linenumber" name="227" href="#227">227</a>         .setTable(STRING_TABLE_NAME).setType(SnapshotDescription.Type.FLUSH).build();
-<a class="jxr_linenumber" name="228" href="#228">228</a> 
-<a class="jxr_linenumber" name="229" href="#229">229</a>     <em class="jxr_comment">// take the snapshot async</em>
-<a class="jxr_linenumber" name="230" href="#230">230</a>     admin.takeSnapshotAsync(snapshot);
-<a class="jxr_linenumber" name="231" href="#231">231</a> 
-<a class="jxr_linenumber" name="232" href="#232">232</a>     <em class="jxr_comment">// constantly loop, looking for the snapshot to complete</em>
-<a class="jxr_linenumber" name="233" href="#233">233</a>     HMaster master = UTIL.getMiniHBaseCluster().getMaster();
-<a class="jxr_linenumber" name="234" href="#234">234</a>     SnapshotTestingUtils.waitForSnapshotToComplete(master, snapshot, 200);
-<a class="jxr_linenumber" name="235" href="#235">235</a>     LOG.info(<span class="jxr_string">" === Async Snapshot Completed ==="</span>);
-<a class="jxr_linenumber" name="236" href="#236">236</a>     HBaseFsck.debugLsr(UTIL.getHBaseCluster().getConfiguration(), FSUtils.getRootDir(UTIL.getConfiguration()));
+<a class="jxr_linenumber" name="58" href="#58">58</a>  <strong class="jxr_keyword">import</strong> org.apache.hadoop.hbase.util.JVMClusterUtil.RegionServerThread;
+<a class="jxr_linenumber" name="59" href="#59">59</a>  <strong class="jxr_keyword">import</strong> org.apache.log4j.Level;
+<a class="jxr_linenumber" name="60" href="#60">60</a>  <strong class="jxr_keyword">import</strong> org.junit.After;
+<a class="jxr_linenumber" name="61" href="#61">61</a>  <strong class="jxr_keyword">import</strong> org.junit.AfterClass;
+<a class="jxr_linenumber" name="62" href="#62">62</a>  <strong class="jxr_keyword">import</strong> org.junit.Before;
+<a class="jxr_linenumber" name="63" href="#63">63</a>  <strong class="jxr_keyword">import</strong> org.junit.BeforeClass;
+<a class="jxr_linenumber" name="64" href="#64">64</a>  <strong class="jxr_keyword">import</strong> org.junit.Test;
+<a class="jxr_linenumber" name="65" href="#65">65</a>  <strong class="jxr_keyword">import</strong> org.junit.experimental.categories.Category;
+<a class="jxr_linenumber" name="66" href="#66">66</a>  
+<a class="jxr_linenumber" name="67" href="#67">67</a>  <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="68" href="#68">68</a>  <em class="jxr_javadoccomment"> * Test creating/using/deleting snapshots from the client</em>
+<a class="jxr_linenumber" name="69" href="#69">69</a>  <em class="jxr_javadoccomment"> * &lt;p&gt;</em>
+<a class="jxr_linenumber" name="70" href="#70">70</a>  <em class="jxr_javadoccomment"> * This is an end-to-end test for the snapshot utility</em>
+<a class="jxr_linenumber" name="71" href="#71">71</a>  <em class="jxr_javadoccomment"> *</em>
+<a class="jxr_linenumber" name="72" href="#72">72</a>  <em class="jxr_javadoccomment"> * TODO This is essentially a clone of TestSnapshotFromClient.  This is worth refactoring this</em>
+<a class="jxr_linenumber" name="73" href="#73">73</a>  <em class="jxr_javadoccomment"> * because there will be a few more flavors of snapshots that need to run these tests.</em>
+<a class="jxr_linenumber" name="74" href="#74">74</a>  <em class="jxr_javadoccomment"> */</em>
+<a class="jxr_linenumber" name="75" href="#75">75</a>  @Category(LargeTests.<strong class="jxr_keyword">class</strong>)
+<a class="jxr_linenumber" name="76" href="#76">76</a>  <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">class</strong> <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">TestFlushSnapshotFromClient</a> {
+<a class="jxr_linenumber" name="77" href="#77">77</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> Log LOG = LogFactory.getLog(TestFlushSnapshotFromClient.<strong class="jxr_keyword">class</strong>);
+<a class="jxr_linenumber" name="78" href="#78">78</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html">HBaseTestingUtility</a> UTIL = <strong class="jxr_keyword">new</strong> <a href="../../../../../org/apache/hadoop/hbase/HBaseTestingUtility.html">HBaseTestingUtility</a>();
+<a class="jxr_linenumber" name="79" href="#79">79</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> <strong class="jxr_keyword">int</strong> NUM_RS = 2;
+<a class="jxr_linenumber" name="80" href="#80">80</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> String STRING_TABLE_NAME = <span class="jxr_string">"test"</span>;
+<a class="jxr_linenumber" name="81" href="#81">81</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] TEST_FAM = Bytes.toBytes(<span class="jxr_string">"fam"</span>);
+<a class="jxr_linenumber" name="82" href="#82">82</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">final</strong> byte[] TABLE_NAME = Bytes.toBytes(STRING_TABLE_NAME);
+<a class="jxr_linenumber" name="83" href="#83">83</a>  
+<a class="jxr_linenumber" name="84" href="#84">84</a>    <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="85" href="#85">85</a>  <em class="jxr_javadoccomment">   * Setup the config for the cluster</em>
+<a class="jxr_linenumber" name="86" href="#86">86</a>  <em class="jxr_javadoccomment">   * @throws Exception on failure</em>
+<a class="jxr_linenumber" name="87" href="#87">87</a>  <em class="jxr_javadoccomment">   */</em>
+<a class="jxr_linenumber" name="88" href="#88">88</a>    @BeforeClass
+<a class="jxr_linenumber" name="89" href="#89">89</a>    <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">void</strong> setupCluster() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="90" href="#90">90</a>      ((Log4JLogger)HBaseServer.LOG).getLogger().setLevel(Level.ALL);
+<a class="jxr_linenumber" name="91" href="#91">91</a>      ((Log4JLogger)HBaseClient.LOG).getLogger().setLevel(Level.ALL);
+<a class="jxr_linenumber" name="92" href="#92">92</a>      ((Log4JLogger)ScannerCallable.LOG).getLogger().setLevel(Level.ALL);
+<a class="jxr_linenumber" name="93" href="#93">93</a>      setupConf(UTIL.getConfiguration());
+<a class="jxr_linenumber" name="94" href="#94">94</a>      UTIL.startMiniCluster(NUM_RS);
+<a class="jxr_linenumber" name="95" href="#95">95</a>    }
+<a class="jxr_linenumber" name="96" href="#96">96</a>  
+<a class="jxr_linenumber" name="97" href="#97">97</a>    <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">void</strong> setupConf(Configuration conf) {
+<a class="jxr_linenumber" name="98" href="#98">98</a>      <em class="jxr_comment">// disable the ui</em>
+<a class="jxr_linenumber" name="99" href="#99">99</a>      conf.setInt(<span class="jxr_string">"hbase.regionsever.info.port"</span>, -1);
+<a class="jxr_linenumber" name="100" href="#100">100</a>     <em class="jxr_comment">// change the flush size to a small amount, regulating number of store files</em>
+<a class="jxr_linenumber" name="101" href="#101">101</a>     conf.setInt(<span class="jxr_string">"hbase.hregion.memstore.flush.size"</span>, 25000);
+<a class="jxr_linenumber" name="102" href="#102">102</a>     <em class="jxr_comment">// so make sure we get a compaction when doing a load, but keep around some</em>
+<a class="jxr_linenumber" name="103" href="#103">103</a>     <em class="jxr_comment">// files in the store</em>
+<a class="jxr_linenumber" name="104" href="#104">104</a>     conf.setInt(<span class="jxr_string">"hbase.hstore.compaction.min"</span>, 10);
+<a class="jxr_linenumber" name="105" href="#105">105</a>     conf.setInt(<span class="jxr_string">"hbase.hstore.compactionThreshold"</span>, 10);
+<a class="jxr_linenumber" name="106" href="#106">106</a>     <em class="jxr_comment">// block writes if we get to 12 store files</em>
+<a class="jxr_linenumber" name="107" href="#107">107</a>     conf.setInt(<span class="jxr_string">"hbase.hstore.blockingStoreFiles"</span>, 12);
+<a class="jxr_linenumber" name="108" href="#108">108</a>     <em class="jxr_comment">// drop the number of attempts for the hbase admin</em>
+<a class="jxr_linenumber" name="109" href="#109">109</a>     conf.setInt(<span class="jxr_string">"hbase.client.retries.number"</span>, 1);
+<a class="jxr_linenumber" name="110" href="#110">110</a>     <em class="jxr_comment">// Enable snapshot</em>
+<a class="jxr_linenumber" name="111" href="#111">111</a>     conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, <strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="112" href="#112">112</a>     conf.set(HConstants.HBASE_REGION_SPLIT_POLICY_KEY,
+<a class="jxr_linenumber" name="113" href="#113">113</a>       ConstantSizeRegionSplitPolicy.<strong class="jxr_keyword">class</strong>.getName());
+<a class="jxr_linenumber" name="114" href="#114">114</a>   }
+<a class="jxr_linenumber" name="115" href="#115">115</a> 
+<a class="jxr_linenumber" name="116" href="#116">116</a>   @Before
+<a class="jxr_linenumber" name="117" href="#117">117</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> setup() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="118" href="#118">118</a>     UTIL.createTable(TABLE_NAME, TEST_FAM);
+<a class="jxr_linenumber" name="119" href="#119">119</a>   }
+<a class="jxr_linenumber" name="120" href="#120">120</a> 
+<a class="jxr_linenumber" name="121" href="#121">121</a>   @After
+<a class="jxr_linenumber" name="122" href="#122">122</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> tearDown() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="123" href="#123">123</a>     UTIL.deleteTable(TABLE_NAME);
+<a class="jxr_linenumber" name="124" href="#124">124</a>     <em class="jxr_comment">// and cleanup the archive directory</em>
+<a class="jxr_linenumber" name="125" href="#125">125</a>     <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="126" href="#126">126</a>       UTIL.getTestFileSystem().delete(<strong class="jxr_keyword">new</strong> Path(UTIL.getDefaultRootDirPath(), <span class="jxr_string">".archive"</span>), <strong class="jxr_keyword">true</strong>);
+<a class="jxr_linenumber" name="127" href="#127">127</a>     } <strong class="jxr_keyword">catch</strong> (IOException e) {
+<a class="jxr_linenumber" name="128" href="#128">128</a>       LOG.warn(<span class="jxr_string">"Failure to delete archive directory"</span>, e);
+<a class="jxr_linenumber" name="129" href="#129">129</a>     }
+<a class="jxr_linenumber" name="130" href="#130">130</a>   }
+<a class="jxr_linenumber" name="131" href="#131">131</a> 
+<a class="jxr_linenumber" name="132" href="#132">132</a>   @AfterClass
+<a class="jxr_linenumber" name="133" href="#133">133</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">static</strong> <strong class="jxr_keyword">void</strong> cleanupTest() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="134" href="#134">134</a>     <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="135" href="#135">135</a>       UTIL.shutdownMiniCluster();
+<a class="jxr_linenumber" name="136" href="#136">136</a>     } <strong class="jxr_keyword">catch</strong> (Exception e) {
+<a class="jxr_linenumber" name="137" href="#137">137</a>       LOG.warn(<span class="jxr_string">"failure shutting down cluster"</span>, e);
+<a class="jxr_linenumber" name="138" href="#138">138</a>     }
+<a class="jxr_linenumber" name="139" href="#139">139</a>   }
+<a class="jxr_linenumber" name="140" href="#140">140</a> 
+<a class="jxr_linenumber" name="141" href="#141">141</a>   <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="142" href="#142">142</a> <em class="jxr_javadoccomment">   * Test simple flush snapshotting a table that is online</em>
+<a class="jxr_linenumber" name="143" href="#143">143</a> <em class="jxr_javadoccomment">   * @throws Exception</em>
+<a class="jxr_linenumber" name="144" href="#144">144</a> <em class="jxr_javadoccomment">   */</em>
+<a class="jxr_linenumber" name="145" href="#145">145</a>   @Test
+<a class="jxr_linenumber" name="146" href="#146">146</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testFlushTableSnapshot() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="147" href="#147">147</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
+<a class="jxr_linenumber" name="148" href="#148">148</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
+<a class="jxr_linenumber" name="149" href="#149">149</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="150" href="#150">150</a> 
+<a class="jxr_linenumber" name="151" href="#151">151</a>     <em class="jxr_comment">// put some stuff in the table</em>
+<a class="jxr_linenumber" name="152" href="#152">152</a>     HTable table = <strong class="jxr_keyword">new</strong> HTable(UTIL.getConfiguration(), TABLE_NAME);
+<a class="jxr_linenumber" name="153" href="#153">153</a>     UTIL.loadTable(table, TEST_FAM);
+<a class="jxr_linenumber" name="154" href="#154">154</a> 
+<a class="jxr_linenumber" name="155" href="#155">155</a>     <em class="jxr_comment">// get the name of all the regionservers hosting the snapshotted table</em>
+<a class="jxr_linenumber" name="156" href="#156">156</a>     Set&lt;String&gt; snapshotServers = <strong class="jxr_keyword">new</strong> HashSet&lt;String&gt;();
+<a class="jxr_linenumber" name="157" href="#157">157</a>     List&lt;RegionServerThread&gt; servers = UTIL.getMiniHBaseCluster().getLiveRegionServerThreads();
+<a class="jxr_linenumber" name="158" href="#158">158</a>     <strong class="jxr_keyword">for</strong> (RegionServerThread server : servers) {
+<a class="jxr_linenumber" name="159" href="#159">159</a>       <strong class="jxr_keyword">if</strong> (server.getRegionServer().getOnlineRegions(TABLE_NAME).size() &gt; 0) {
+<a class="jxr_linenumber" name="160" href="#160">160</a>         snapshotServers.add(server.getRegionServer().getServerName().toString());
+<a class="jxr_linenumber" name="161" href="#161">161</a>       }
+<a class="jxr_linenumber" name="162" href="#162">162</a>     }
+<a class="jxr_linenumber" name="163" href="#163">163</a> 
+<a class="jxr_linenumber" name="164" href="#164">164</a>     LOG.debug(<span class="jxr_string">"FS state before snapshot:"</span>);
+<a class="jxr_linenumber" name="165" href="#165">165</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
+<a class="jxr_linenumber" name="166" href="#166">166</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
+<a class="jxr_linenumber" name="167" href="#167">167</a> 
+<a class="jxr_linenumber" name="168" href="#168">168</a>     <em class="jxr_comment">// take a snapshot of the enabled table</em>
+<a class="jxr_linenumber" name="169" href="#169">169</a>     String snapshotString = <span class="jxr_string">"offlineTableSnapshot"</span>;
+<a class="jxr_linenumber" name="170" href="#170">170</a>     byte[] snapshot = Bytes.toBytes(snapshotString);
+<a class="jxr_linenumber" name="171" href="#171">171</a>     admin.snapshot(snapshotString, STRING_TABLE_NAME, SnapshotDescription.Type.FLUSH);
+<a class="jxr_linenumber" name="172" href="#172">172</a>     LOG.debug(<span class="jxr_string">"Snapshot completed."</span>);
+<a class="jxr_linenumber" name="173" href="#173">173</a> 
+<a class="jxr_linenumber" name="174" href="#174">174</a>     <em class="jxr_comment">// make sure we have the snapshot</em>
+<a class="jxr_linenumber" name="175" href="#175">175</a>     List&lt;SnapshotDescription&gt; snapshots = SnapshotTestingUtils.assertOneSnapshotThatMatches(admin,
+<a class="jxr_linenumber" name="176" href="#176">176</a>       snapshot, TABLE_NAME);
+<a class="jxr_linenumber" name="177" href="#177">177</a> 
+<a class="jxr_linenumber" name="178" href="#178">178</a>     <em class="jxr_comment">// make sure its a valid snapshot</em>
+<a class="jxr_linenumber" name="179" href="#179">179</a>     FileSystem fs = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getFileSystem();
+<a class="jxr_linenumber" name="180" href="#180">180</a>     Path rootDir = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+<a class="jxr_linenumber" name="181" href="#181">181</a>     LOG.debug(<span class="jxr_string">"FS state after snapshot:"</span>);
+<a class="jxr_linenumber" name="182" href="#182">182</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
+<a class="jxr_linenumber" name="183" href="#183">183</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
+<a class="jxr_linenumber" name="184" href="#184">184</a> 
+<a class="jxr_linenumber" name="185" href="#185">185</a>     SnapshotTestingUtils.confirmSnapshotValid(snapshots.get(0), TABLE_NAME, TEST_FAM, rootDir,
+<a class="jxr_linenumber" name="186" href="#186">186</a>       admin, fs, false, <strong class="jxr_keyword">new</strong> Path(rootDir, HConstants.HREGION_LOGDIR_NAME), snapshotServers);
+<a class="jxr_linenumber" name="187" href="#187">187</a> 
+<a class="jxr_linenumber" name="188" href="#188">188</a>     admin.deleteSnapshot(snapshot);
+<a class="jxr_linenumber" name="189" href="#189">189</a>     snapshots = admin.listSnapshots();
+<a class="jxr_linenumber" name="190" href="#190">190</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="191" href="#191">191</a>   }
+<a class="jxr_linenumber" name="192" href="#192">192</a> 
+<a class="jxr_linenumber" name="193" href="#193">193</a>   @Test
+<a class="jxr_linenumber" name="194" href="#194">194</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testSnapshotFailsOnNonExistantTable() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="195" href="#195">195</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
+<a class="jxr_linenumber" name="196" href="#196">196</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
+<a class="jxr_linenumber" name="197" href="#197">197</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="198" href="#198">198</a>     String tableName = <span class="jxr_string">"_not_a_table"</span>;
+<a class="jxr_linenumber" name="199" href="#199">199</a> 
+<a class="jxr_linenumber" name="200" href="#200">200</a>     <em class="jxr_comment">// make sure the table doesn't exist</em>
+<a class="jxr_linenumber" name="201" href="#201">201</a>     <strong class="jxr_keyword">boolean</strong> fail = false;
+<a class="jxr_linenumber" name="202" href="#202">202</a>     <strong class="jxr_keyword">do</strong> {
+<a class="jxr_linenumber" name="203" href="#203">203</a>     <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="204" href="#204">204</a>       admin.getTableDescriptor(Bytes.toBytes(tableName));
+<a class="jxr_linenumber" name="205" href="#205">205</a>       fail = <strong class="jxr_keyword">true</strong>;
+<a class="jxr_linenumber" name="206" href="#206">206</a>           LOG.error(<span class="jxr_string">"Table:"</span> + tableName + <span class="jxr_string">" already exists, checking a new name"</span>);
+<a class="jxr_linenumber" name="207" href="#207">207</a>       tableName = tableName+<span class="jxr_string">"!"</span>;
+<a class="jxr_linenumber" name="208" href="#208">208</a>     } <strong class="jxr_keyword">catch</strong> (TableNotFoundException e) {
+<a class="jxr_linenumber" name="209" href="#209">209</a>       fail = false;
+<a class="jxr_linenumber" name="210" href="#210">210</a>       }
+<a class="jxr_linenumber" name="211" href="#211">211</a>     } <strong class="jxr_keyword">while</strong> (fail);
+<a class="jxr_linenumber" name="212" href="#212">212</a> 
+<a class="jxr_linenumber" name="213" href="#213">213</a>     <em class="jxr_comment">// snapshot the non-existant table</em>
+<a class="jxr_linenumber" name="214" href="#214">214</a>     <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="215" href="#215">215</a>       admin.snapshot(<span class="jxr_string">"fail"</span>, tableName, SnapshotDescription.Type.FLUSH);
+<a class="jxr_linenumber" name="216" href="#216">216</a>       fail(<span class="jxr_string">"Snapshot succeeded even though there is not table."</span>);
+<a class="jxr_linenumber" name="217" href="#217">217</a>     } <strong class="jxr_keyword">catch</strong> (SnapshotCreationException e) {
+<a class="jxr_linenumber" name="218" href="#218">218</a>       LOG.info(<span class="jxr_string">"Correctly failed to snapshot a non-existant table:"</span> + e.getMessage());
+<a class="jxr_linenumber" name="219" href="#219">219</a>     }
+<a class="jxr_linenumber" name="220" href="#220">220</a>   }
+<a class="jxr_linenumber" name="221" href="#221">221</a> 
+<a class="jxr_linenumber" name="222" href="#222">222</a>   @Test(timeout = 15000)
+<a class="jxr_linenumber" name="223" href="#223">223</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testAsyncFlushSnapshot() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="224" href="#224">224</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
+<a class="jxr_linenumber" name="225" href="#225">225</a>     SnapshotDescription snapshot = SnapshotDescription.newBuilder().setName(<span class="jxr_string">"asyncSnapshot"</span>)
+<a class="jxr_linenumber" name="226" href="#226">226</a>         .setTable(STRING_TABLE_NAME).setType(SnapshotDescription.Type.FLUSH).build();
+<a class="jxr_linenumber" name="227" href="#227">227</a> 
+<a class="jxr_linenumber" name="228" href="#228">228</a>     <em class="jxr_comment">// take the snapshot async</em>
+<a class="jxr_linenumber" name="229" href="#229">229</a>     admin.takeSnapshotAsync(snapshot);
+<a class="jxr_linenumber" name="230" href="#230">230</a> 
+<a class="jxr_linenumber" name="231" href="#231">231</a>     <em class="jxr_comment">// constantly loop, looking for the snapshot to complete</em>
+<a class="jxr_linenumber" name="232" href="#232">232</a>     HMaster master = UTIL.getMiniHBaseCluster().getMaster();
+<a class="jxr_linenumber" name="233" href="#233">233</a>     SnapshotTestingUtils.waitForSnapshotToComplete(master, snapshot, 200);
+<a class="jxr_linenumber" name="234" href="#234">234</a>     LOG.info(<span class="jxr_string">" === Async Snapshot Completed ==="</span>);
+<a class="jxr_linenumber" name="235" href="#235">235</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
+<a class="jxr_linenumber" name="236" href="#236">236</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
 <a class="jxr_linenumber" name="237" href="#237">237</a>     <em class="jxr_comment">// make sure we get the snapshot</em>
 <a class="jxr_linenumber" name="238" href="#238">238</a>     SnapshotTestingUtils.assertOneSnapshotThatMatches(admin, snapshot);
 <a class="jxr_linenumber" name="239" href="#239">239</a> 
 <a class="jxr_linenumber" name="240" href="#240">240</a>     <em class="jxr_comment">// test that we can delete the snapshot</em>
 <a class="jxr_linenumber" name="241" href="#241">241</a>     admin.deleteSnapshot(snapshot.getName());
 <a class="jxr_linenumber" name="242" href="#242">242</a>     LOG.info(<span class="jxr_string">" === Async Snapshot Deleted ==="</span>);
-<a class="jxr_linenumber" name="243" href="#243">243</a>     HBaseFsck.debugLsr(UTIL.getHBaseCluster().getConfiguration(), FSUtils.getRootDir(UTIL.getConfiguration()));
-<a class="jxr_linenumber" name="244" href="#244">244</a>     <em class="jxr_comment">// make sure we don't have any snapshots</em>
-<a class="jxr_linenumber" name="245" href="#245">245</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="246" href="#246">246</a>     LOG.info(<span class="jxr_string">" === Async Snapshot Test Completed ==="</span>);
-<a class="jxr_linenumber" name="247" href="#247">247</a> 
-<a class="jxr_linenumber" name="248" href="#248">248</a>   }
-<a class="jxr_linenumber" name="249" href="#249">249</a> 
-<a class="jxr_linenumber" name="250" href="#250">250</a>   <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="251" href="#251">251</a> <em class="jxr_javadoccomment">   * Basic end-to-end test of simple-flush-based snapshots</em>
-<a class="jxr_linenumber" name="252" href="#252">252</a> <em class="jxr_javadoccomment">   */</em>
-<a class="jxr_linenumber" name="253" href="#253">253</a>   @Test
-<a class="jxr_linenumber" name="254" href="#254">254</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testFlushCreateListDestroy() <strong class="jxr_keyword">throws</strong> Exception {
-<a class="jxr_linenumber" name="255" href="#255">255</a>     LOG.debug(<span class="jxr_string">"------- Starting Snapshot test -------------"</span>);
-<a class="jxr_linenumber" name="256" href="#256">256</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
-<a class="jxr_linenumber" name="257" href="#257">257</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
-<a class="jxr_linenumber" name="258" href="#258">258</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="259" href="#259">259</a>     <em class="jxr_comment">// load the table so we have some data</em>
-<a class="jxr_linenumber" name="260" href="#260">260</a>     UTIL.loadTable(<strong class="jxr_keyword">new</strong> HTable(UTIL.getConfiguration(), TABLE_NAME), TEST_FAM);
-<a class="jxr_linenumber" name="261" href="#261">261</a>     <em class="jxr_comment">// and wait until everything stabilizes</em>
-<a class="jxr_linenumber" name="262" href="#262">262</a>     HRegionServer rs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
-<a class="jxr_linenumber" name="263" href="#263">263</a>     List&lt;HRegion&gt; onlineRegions = rs.getOnlineRegions(TABLE_NAME);
-<a class="jxr_linenumber" name="264" href="#264">264</a>     <strong class="jxr_keyword">for</strong> (HRegion region : onlineRegions) {
-<a class="jxr_linenumber" name="265" href="#265">265</a>       region.waitForFlushesAndCompactions();
-<a class="jxr_linenumber" name="266" href="#266">266</a>     }
-<a class="jxr_linenumber" name="267" href="#267">267</a>     String snapshotName = <span class="jxr_string">"flushSnapshotCreateListDestroy"</span>;
-<a class="jxr_linenumber" name="268" href="#268">268</a>     <em class="jxr_comment">// test creating the snapshot</em>
-<a class="jxr_linenumber" name="269" href="#269">269</a>     admin.snapshot(snapshotName, STRING_TABLE_NAME, SnapshotDescription.Type.FLUSH);
-<a class="jxr_linenumber" name="270" href="#270">270</a>     logFSTree(FSUtils.getRootDir(UTIL.getConfiguration()));
-<a class="jxr_linenumber" name="271" href="#271">271</a> 
-<a class="jxr_linenumber" name="272" href="#272">272</a>     <em class="jxr_comment">// make sure we only have 1 matching snapshot</em>
-<a class="jxr_linenumber" name="273" href="#273">273</a>     List&lt;SnapshotDescription&gt; snapshots = SnapshotTestingUtils.assertOneSnapshotThatMatches(admin,
-<a class="jxr_linenumber" name="274" href="#274">274</a>       snapshotName, STRING_TABLE_NAME);
-<a class="jxr_linenumber" name="275" href="#275">275</a> 
-<a class="jxr_linenumber" name="276" href="#276">276</a>     <em class="jxr_comment">// check the directory structure</em>
-<a class="jxr_linenumber" name="277" href="#277">277</a>     FileSystem fs = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getFileSystem();
-<a class="jxr_linenumber" name="278" href="#278">278</a>     Path rootDir = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
-<a class="jxr_linenumber" name="279" href="#279">279</a>     Path snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshots.get(0), rootDir);
-<a class="jxr_linenumber" name="280" href="#280">280</a>     assertTrue(fs.exists(snapshotDir));
-<a class="jxr_linenumber" name="281" href="#281">281</a>     HBaseFsck.debugLsr(UTIL.getHBaseCluster().getConfiguration(),  snapshotDir);
-<a class="jxr_linenumber" name="282" href="#282">282</a>     Path snapshotinfo = <strong class="jxr_keyword">new</strong> Path(snapshotDir, SnapshotDescriptionUtils.SNAPSHOTINFO_FILE);
-<a class="jxr_linenumber" name="283" href="#283">283</a>     assertTrue(fs.exists(snapshotinfo));
-<a class="jxr_linenumber" name="284" href="#284">284</a> 
-<a class="jxr_linenumber" name="285" href="#285">285</a>     <em class="jxr_comment">// check the table info</em>
-<a class="jxr_linenumber" name="286" href="#286">286</a>     HTableDescriptor desc = FSTableDescriptors.getTableDescriptor(fs, rootDir, TABLE_NAME);
-<a class="jxr_linenumber" name="287" href="#287">287</a>     HTableDescriptor snapshotDesc = FSTableDescriptors.getTableDescriptor(fs,
-<a class="jxr_linenumber" name="288" href="#288">288</a>       SnapshotDescriptionUtils.getSnapshotsDir(rootDir), Bytes.toBytes(snapshotName));
-<a class="jxr_linenumber" name="289" href="#289">289</a>     assertEquals(desc, snapshotDesc);
-<a class="jxr_linenumber" name="290" href="#290">290</a> 
-<a class="jxr_linenumber" name="291" href="#291">291</a>     <em class="jxr_comment">// check the region snapshot for all the regions</em>
-<a class="jxr_linenumber" name="292" href="#292">292</a>     List&lt;HRegionInfo&gt; regions = admin.getTableRegions(TABLE_NAME);
-<a class="jxr_linenumber" name="293" href="#293">293</a>     <strong class="jxr_keyword">for</strong> (HRegionInfo info : regions) {
-<a class="jxr_linenumber" name="294" href="#294">294</a>       String regionName = info.getEncodedName();
-<a class="jxr_linenumber" name="295" href="#295">295</a>       Path regionDir = <strong class="jxr_keyword">new</strong> Path(snapshotDir, regionName);
-<a class="jxr_linenumber" name="296" href="#296">296</a>       HRegionInfo snapshotRegionInfo = HRegionFileSystem.loadRegionInfoFileContent(fs, regionDir);
-<a class="jxr_linenumber" name="297" href="#297">297</a>       assertEquals(info, snapshotRegionInfo);
-<a class="jxr_linenumber" name="298" href="#298">298</a>       <em class="jxr_comment">// check to make sure we have the family</em>
-<a class="jxr_linenumber" name="299" href="#299">299</a>       Path familyDir = <strong class="jxr_keyword">new</strong> Path(regionDir, Bytes.toString(TEST_FAM));
-<a class="jxr_linenumber" name="300" href="#300">300</a>       assertTrue(fs.exists(familyDir));
-<a class="jxr_linenumber" name="301" href="#301">301</a>       <em class="jxr_comment">// make sure we have some file references</em>
-<a class="jxr_linenumber" name="302" href="#302">302</a>       assertTrue(fs.listStatus(familyDir).length &gt; 0);
-<a class="jxr_linenumber" name="303" href="#303">303</a>     }
-<a class="jxr_linenumber" name="304" href="#304">304</a> 
-<a class="jxr_linenumber" name="305" href="#305">305</a>     <em class="jxr_comment">// test that we can delete the snapshot</em>
-<a class="jxr_linenumber" name="306" href="#306">306</a>     admin.deleteSnapshot(snapshotName);
-<a class="jxr_linenumber" name="307" href="#307">307</a>     HBaseFsck.debugLsr(UTIL.getHBaseCluster().getConfiguration(), FSUtils.getRootDir(UTIL.getConfiguration()));
-<a class="jxr_linenumber" name="308" href="#308">308</a> 
-<a class="jxr_linenumber" name="309" href="#309">309</a>     <em class="jxr_comment">// make sure we don't have any snapshots</em>
-<a class="jxr_linenumber" name="310" href="#310">310</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="311" href="#311">311</a>     LOG.debug(<span class="jxr_string">"------- Flush-Snapshot Create List Destroy-------------"</span>);
-<a class="jxr_linenumber" name="312" href="#312">312</a>   }
-<a class="jxr_linenumber" name="313" href="#313">313</a> 
-<a class="jxr_linenumber" name="314" href="#314">314</a>   <em class="jxr_javadoccomment">/**</em>
-<a class="jxr_linenumber" name="315" href="#315">315</a> <em class="jxr_javadoccomment">   * Demonstrate that we reject snapshot requests if there is a snapshot currently running.</em>
-<a class="jxr_linenumber" name="316" href="#316">316</a> <em class="jxr_javadoccomment">   */</em>
-<a class="jxr_linenumber" name="317" href="#317">317</a>   @Test(timeout=60000)
-<a class="jxr_linenumber" name="318" href="#318">318</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testConcurrentSnapshottingAttempts() <strong class="jxr_keyword">throws</strong> IOException, InterruptedException {
-<a class="jxr_linenumber" name="319" href="#319">319</a>     <strong class="jxr_keyword">int</strong> ssNum = 10;
-<a class="jxr_linenumber" name="320" href="#320">320</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
-<a class="jxr_linenumber" name="321" href="#321">321</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
-<a class="jxr_linenumber" name="322" href="#322">322</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
-<a class="jxr_linenumber" name="323" href="#323">323</a>     <em class="jxr_comment">// load the table so we have some data</em>
-<a class="jxr_linenumber" name="324" href="#324">324</a>     UTIL.loadTable(<strong class="jxr_keyword">new</strong> HTable(UTIL.getConfiguration(), TABLE_NAME), TEST_FAM);
-<a class="jxr_linenumber" name="325" href="#325">325</a>     <em class="jxr_comment">// and wait until everything stabilizes</em>
-<a class="jxr_linenumber" name="326" href="#326">326</a>     HRegionServer rs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
-<a class="jxr_linenumber" name="327" href="#327">327</a>     List&lt;HRegion&gt; onlineRegions = rs.getOnlineRegions(TABLE_NAME);
-<a class="jxr_linenumber" name="328" href="#328">328</a>     <strong class="jxr_keyword">for</strong> (HRegion region : onlineRegions) {
-<a class="jxr_linenumber" name="329" href="#329">329</a>       region.waitForFlushesAndCompactions();
-<a class="jxr_linenumber" name="330" href="#330">330</a>     }
-<a class="jxr_linenumber" name="331" href="#331">331</a> 
-<a class="jxr_linenumber" name="332" href="#332">332</a>     <em class="jxr_comment">// build descriptions</em>
-<a class="jxr_linenumber" name="333" href="#333">333</a>     SnapshotDescription[] descs = <strong class="jxr_keyword">new</strong> SnapshotDescription[ssNum];
-<a class="jxr_linenumber" name="334" href="#334">334</a>     <strong class="jxr_keyword">for</strong> (<strong class="jxr_keyword">int</strong> i = 0; i &lt; ssNum; i++) {
-<a class="jxr_linenumber" name="335" href="#335">335</a>       SnapshotDescription.Builder builder = SnapshotDescription.newBuilder();
-<a class="jxr_linenumber" name="336" href="#336">336</a>       builder.setTable(STRING_TABLE_NAME);
-<a class="jxr_linenumber" name="337" href="#337">337</a>       builder.setName(<span class="jxr_string">"ss"</span>+i);
-<a class="jxr_linenumber" name="338" href="#338">338</a>       builder.setType(SnapshotDescription.Type.FLUSH);
-<a class="jxr_linenumber" name="339" href="#339">339</a>       descs[i] = builder.build();
-<a class="jxr_linenumber" name="340" href="#340">340</a>     }
-<a class="jxr_linenumber" name="341" href="#341">341</a> 
-<a class="jxr_linenumber" name="342" href="#342">342</a>     <strong class="jxr_keyword">final</strong> CountDownLatch toBeSubmitted = <strong class="jxr_keyword">new</strong> CountDownLatch(ssNum);
-<a class="jxr_linenumber" name="343" href="#343">343</a>     <em class="jxr_comment">// We'll have one of these per thread</em>
-<a class="jxr_linenumber" name="344" href="#344">344</a>     <strong class="jxr_keyword">class</strong> <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">SSRunnable</a> <strong class="jxr_keyword">implements</strong> Runnable {
-<a class="jxr_linenumber" name="345" href="#345">345</a>       SnapshotDescription ss;
-<a class="jxr_linenumber" name="346" href="#346">346</a>       <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">SSRunnable</a>(SnapshotDescription ss) {
-<a class="jxr_linenumber" name="347" href="#347">347</a>         <strong class="jxr_keyword">this</strong>.ss = ss;
-<a class="jxr_linenumber" name="348" href="#348">348</a>       }
-<a class="jxr_linenumber" name="349" href="#349">349</a> 
-<a class="jxr_linenumber" name="350" href="#350">350</a>       @Override
-<a class="jxr_linenumber" name="351" href="#351">351</a>       <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> run() {
-<a class="jxr_linenumber" name="352" href="#352">352</a>         <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="353" href="#353">353</a>           HBaseAdmin admin = UTIL.getHBaseAdmin();
-<a class="jxr_linenumber" name="354" href="#354">354</a>           LOG.info(<span class="jxr_string">"Submitting snapshot request: "</span> + ClientSnapshotDescriptionUtils.toString(ss));
-<a class="jxr_linenumber" name="355" href="#355">355</a>           admin.takeSnapshotAsync(ss);
-<a class="jxr_linenumber" name="356" href="#356">356</a>         } <strong class="jxr_keyword">catch</strong> (Exception e) {
-<a class="jxr_linenumber" name="357" href="#357">357</a>           LOG.info(<span class="jxr_string">"Exception during snapshot request: "</span> + ClientSnapshotDescriptionUtils.toString(
-<a class="jxr_linenumber" name="358" href="#358">358</a>               ss)
-<a class="jxr_linenumber" name="359" href="#359">359</a>               + <span class="jxr_string">".  This is ok, we expect some"</span>, e);
-<a class="jxr_linenumber" name="360" href="#360">360</a>         }
-<a class="jxr_linenumber" name="361" href="#361">361</a>         LOG.info(<span class="jxr_string">"Submitted snapshot request: "</span> + ClientSnapshotDescriptionUtils.toString(ss));
-<a class="jxr_linenumber" name="362" href="#362">362</a>         toBeSubmitted.countDown();
-<a class="jxr_linenumber" name="363" href="#363">363</a>       }
-<a class="jxr_linenumber" name="364" href="#364">364</a>     };
-<a class="jxr_linenumber" name="365" href="#365">365</a> 
-<a class="jxr_linenumber" name="366" href="#366">366</a>     <em class="jxr_comment">// kick each off its own thread</em>
-<a class="jxr_linenumber" name="367" href="#367">367</a>     <strong class="jxr_keyword">for</strong> (<strong class="jxr_keyword">int</strong> i=0 ; i &lt; ssNum; i++) {
-<a class="jxr_linenumber" name="368" href="#368">368</a>       <strong class="jxr_keyword">new</strong> Thread(<strong class="jxr_keyword">new</strong> <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">SSRunnable</a>(descs[i])).start();
-<a class="jxr_linenumber" name="369" href="#369">369</a>     }
-<a class="jxr_linenumber" name="370" href="#370">370</a> 
-<a class="jxr_linenumber" name="371" href="#371">371</a>     <em class="jxr_comment">// wait until all have been submitted</em>
-<a class="jxr_linenumber" name="372" href="#372">372</a>     toBeSubmitted.await();
-<a class="jxr_linenumber" name="373" href="#373">373</a> 
-<a class="jxr_linenumber" name="374" href="#374">374</a>     <em class="jxr_comment">// loop until all are done.</em>
-<a class="jxr_linenumber" name="375" href="#375">375</a>     <strong class="jxr_keyword">while</strong> (<strong class="jxr_keyword">true</strong>) {
-<a class="jxr_linenumber" name="376" href="#376">376</a>       <strong class="jxr_keyword">int</strong> doneCount = 0;
-<a class="jxr_linenumber" name="377" href="#377">377</a>       <strong class="jxr_keyword">for</strong> (SnapshotDescription ss : descs) {
-<a class="jxr_linenumber" name="378" href="#378">378</a>         <strong class="jxr_keyword">try</strong> {
-<a class="jxr_linenumber" name="379" href="#379">379</a>           <strong class="jxr_keyword">if</strong> (admin.isSnapshotFinished(ss)) {
-<a class="jxr_linenumber" name="380" href="#380">380</a>             doneCount++;
-<a class="jxr_linenumber" name="381" href="#381">381</a>           }
-<a class="jxr_linenumber" name="382" href="#382">382</a>         } <strong class="jxr_keyword">catch</strong> (Exception e) {
-<a class="jxr_linenumber" name="383" href="#383">383</a>           LOG.warn(<span class="jxr_string">"Got an exception when checking for snapshot "</span> + ss.getName(), e);
-<a class="jxr_linenumber" name="384" href="#384">384</a>           doneCount++;
-<a class="jxr_linenumber" name="385" href="#385">385</a>         }
-<a class="jxr_linenumber" name="386" href="#386">386</a>       }
-<a class="jxr_linenumber" name="387" href="#387">387</a>       <strong class="jxr_keyword">if</strong> (doneCount == descs.length) {
-<a class="jxr_linenumber" name="388" href="#388">388</a>         <strong class="jxr_keyword">break</strong>;
-<a class="jxr_linenumber" name="389" href="#389">389</a>       }
-<a class="jxr_linenumber" name="390" href="#390">390</a>       Thread.sleep(100);
-<a class="jxr_linenumber" name="391" href="#391">391</a>     }
-<a class="jxr_linenumber" name="392" href="#392">392</a> 
-<a class="jxr_linenumber" name="393" href="#393">393</a>     <em class="jxr_comment">// dump for debugging</em>
-<a class="jxr_linenumber" name="394" href="#394">394</a>     logFSTree(FSUtils.getRootDir(UTIL.getConfiguration()));
-<a class="jxr_linenumber" name="395" href="#395">395</a> 
-<a class="jxr_linenumber" name="396" href="#396">396</a>     List&lt;SnapshotDescription&gt; taken = admin.listSnapshots();
-<a class="jxr_linenumber" name="397" href="#397">397</a>     <strong class="jxr_keyword">int</strong> takenSize = taken.size();
-<a class="jxr_linenumber" name="398" href="#398">398</a>     LOG.info(<span class="jxr_string">"Taken "</span> + takenSize + <span class="jxr_string">" snapshots:  "</span> + taken);
-<a class="jxr_linenumber" name="399" href="#399">399</a>     assertTrue(<span class="jxr_string">"We expect at least 1 request to be rejected because of we concurrently"</span> +
-<a class="jxr_linenumber" name="400" href="#400">400</a>         <span class="jxr_string">" issued many requests"</span>, takenSize &lt; ssNum &amp;&amp; takenSize &gt; 0);
-<a class="jxr_linenumber" name="401" href="#401">401</a>     <em class="jxr_comment">// delete snapshots so subsequent tests are clean.</em>
-<a class="jxr_linenumber" name="402" href="#402">402</a>     <strong class="jxr_keyword">for</strong> (SnapshotDescription ss : taken) {
-<a class="jxr_linenumber" name="403" href="#403">403</a>       admin.deleteSnapshot(ss.getName());
-<a class="jxr_linenumber" name="404" href="#404">404</a>     }
-<a class="jxr_linenumber" name="405" href="#405">405</a>   }
-<a class="jxr_linenumber" name="406" href="#406">406</a> 
-<a class="jxr_linenumber" name="407" href="#407">407</a>   <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">void</strong> logFSTree(Path root) <strong class="jxr_keyword">throws</strong> IOException {
-<a class="jxr_linenumber" name="408" href="#408">408</a>     FSUtils.logFileSystemState(UTIL.getDFSCluster().getFileSystem(), root, LOG);
-<a class="jxr_linenumber" name="409" href="#409">409</a>   }
-<a class="jxr_linenumber" name="410" href="#410">410</a> }
+<a class="jxr_linenumber" name="243" href="#243">243</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
+<a class="jxr_linenumber" name="244" href="#244">244</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
+<a class="jxr_linenumber" name="245" href="#245">245</a>     <em class="jxr_comment">// make sure we don't have any snapshots</em>
+<a class="jxr_linenumber" name="246" href="#246">246</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="247" href="#247">247</a>     LOG.info(<span class="jxr_string">" === Async Snapshot Test Completed ==="</span>);
+<a class="jxr_linenumber" name="248" href="#248">248</a> 
+<a class="jxr_linenumber" name="249" href="#249">249</a>   }
+<a class="jxr_linenumber" name="250" href="#250">250</a> 
+<a class="jxr_linenumber" name="251" href="#251">251</a>   <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="252" href="#252">252</a> <em class="jxr_javadoccomment">   * Basic end-to-end test of simple-flush-based snapshots</em>
+<a class="jxr_linenumber" name="253" href="#253">253</a> <em class="jxr_javadoccomment">   */</em>
+<a class="jxr_linenumber" name="254" href="#254">254</a>   @Test
+<a class="jxr_linenumber" name="255" href="#255">255</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testFlushCreateListDestroy() <strong class="jxr_keyword">throws</strong> Exception {
+<a class="jxr_linenumber" name="256" href="#256">256</a>     LOG.debug(<span class="jxr_string">"------- Starting Snapshot test -------------"</span>);
+<a class="jxr_linenumber" name="257" href="#257">257</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
+<a class="jxr_linenumber" name="258" href="#258">258</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
+<a class="jxr_linenumber" name="259" href="#259">259</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="260" href="#260">260</a>     <em class="jxr_comment">// load the table so we have some data</em>
+<a class="jxr_linenumber" name="261" href="#261">261</a>     UTIL.loadTable(<strong class="jxr_keyword">new</strong> HTable(UTIL.getConfiguration(), TABLE_NAME), TEST_FAM);
+<a class="jxr_linenumber" name="262" href="#262">262</a>     <em class="jxr_comment">// and wait until everything stabilizes</em>
+<a class="jxr_linenumber" name="263" href="#263">263</a>     HRegionServer rs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
+<a class="jxr_linenumber" name="264" href="#264">264</a>     List&lt;HRegion&gt; onlineRegions = rs.getOnlineRegions(TABLE_NAME);
+<a class="jxr_linenumber" name="265" href="#265">265</a>     <strong class="jxr_keyword">for</strong> (HRegion region : onlineRegions) {
+<a class="jxr_linenumber" name="266" href="#266">266</a>       region.waitForFlushesAndCompactions();
+<a class="jxr_linenumber" name="267" href="#267">267</a>     }
+<a class="jxr_linenumber" name="268" href="#268">268</a>     String snapshotName = <span class="jxr_string">"flushSnapshotCreateListDestroy"</span>;
+<a class="jxr_linenumber" name="269" href="#269">269</a>     <em class="jxr_comment">// test creating the snapshot</em>
+<a class="jxr_linenumber" name="270" href="#270">270</a>     admin.snapshot(snapshotName, STRING_TABLE_NAME, SnapshotDescription.Type.FLUSH);
+<a class="jxr_linenumber" name="271" href="#271">271</a>     logFSTree(FSUtils.getRootDir(UTIL.getConfiguration()));
+<a class="jxr_linenumber" name="272" href="#272">272</a> 
+<a class="jxr_linenumber" name="273" href="#273">273</a>     <em class="jxr_comment">// make sure we only have 1 matching snapshot</em>
+<a class="jxr_linenumber" name="274" href="#274">274</a>     List&lt;SnapshotDescription&gt; snapshots = SnapshotTestingUtils.assertOneSnapshotThatMatches(admin,
+<a class="jxr_linenumber" name="275" href="#275">275</a>       snapshotName, STRING_TABLE_NAME);
+<a class="jxr_linenumber" name="276" href="#276">276</a> 
+<a class="jxr_linenumber" name="277" href="#277">277</a>     <em class="jxr_comment">// check the directory structure</em>
+<a class="jxr_linenumber" name="278" href="#278">278</a>     FileSystem fs = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getFileSystem();
+<a class="jxr_linenumber" name="279" href="#279">279</a>     Path rootDir = UTIL.getHBaseCluster().getMaster().getMasterFileSystem().getRootDir();
+<a class="jxr_linenumber" name="280" href="#280">280</a>     Path snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshots.get(0), rootDir);
+<a class="jxr_linenumber" name="281" href="#281">281</a>     assertTrue(fs.exists(snapshotDir));
+<a class="jxr_linenumber" name="282" href="#282">282</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(), snapshotDir, LOG);
+<a class="jxr_linenumber" name="283" href="#283">283</a>     Path snapshotinfo = <strong class="jxr_keyword">new</strong> Path(snapshotDir, SnapshotDescriptionUtils.SNAPSHOTINFO_FILE);
+<a class="jxr_linenumber" name="284" href="#284">284</a>     assertTrue(fs.exists(snapshotinfo));
+<a class="jxr_linenumber" name="285" href="#285">285</a> 
+<a class="jxr_linenumber" name="286" href="#286">286</a>     <em class="jxr_comment">// check the table info</em>
+<a class="jxr_linenumber" name="287" href="#287">287</a>     HTableDescriptor desc = FSTableDescriptors.getTableDescriptor(fs, rootDir, TABLE_NAME);
+<a class="jxr_linenumber" name="288" href="#288">288</a>     HTableDescriptor snapshotDesc = FSTableDescriptors.getTableDescriptor(fs,
+<a class="jxr_linenumber" name="289" href="#289">289</a>       SnapshotDescriptionUtils.getSnapshotsDir(rootDir), Bytes.toBytes(snapshotName));
+<a class="jxr_linenumber" name="290" href="#290">290</a>     assertEquals(desc, snapshotDesc);
+<a class="jxr_linenumber" name="291" href="#291">291</a> 
+<a class="jxr_linenumber" name="292" href="#292">292</a>     <em class="jxr_comment">// check the region snapshot for all the regions</em>
+<a class="jxr_linenumber" name="293" href="#293">293</a>     List&lt;HRegionInfo&gt; regions = admin.getTableRegions(TABLE_NAME);
+<a class="jxr_linenumber" name="294" href="#294">294</a>     <strong class="jxr_keyword">for</strong> (HRegionInfo info : regions) {
+<a class="jxr_linenumber" name="295" href="#295">295</a>       String regionName = info.getEncodedName();
+<a class="jxr_linenumber" name="296" href="#296">296</a>       Path regionDir = <strong class="jxr_keyword">new</strong> Path(snapshotDir, regionName);
+<a class="jxr_linenumber" name="297" href="#297">297</a>       HRegionInfo snapshotRegionInfo = HRegionFileSystem.loadRegionInfoFileContent(fs, regionDir);
+<a class="jxr_linenumber" name="298" href="#298">298</a>       assertEquals(info, snapshotRegionInfo);
+<a class="jxr_linenumber" name="299" href="#299">299</a>       <em class="jxr_comment">// check to make sure we have the family</em>
+<a class="jxr_linenumber" name="300" href="#300">300</a>       Path familyDir = <strong class="jxr_keyword">new</strong> Path(regionDir, Bytes.toString(TEST_FAM));
+<a class="jxr_linenumber" name="301" href="#301">301</a>       assertTrue(fs.exists(familyDir));
+<a class="jxr_linenumber" name="302" href="#302">302</a>       <em class="jxr_comment">// make sure we have some file references</em>
+<a class="jxr_linenumber" name="303" href="#303">303</a>       assertTrue(fs.listStatus(familyDir).length &gt; 0);
+<a class="jxr_linenumber" name="304" href="#304">304</a>     }
+<a class="jxr_linenumber" name="305" href="#305">305</a> 
+<a class="jxr_linenumber" name="306" href="#306">306</a>     <em class="jxr_comment">// test that we can delete the snapshot</em>
+<a class="jxr_linenumber" name="307" href="#307">307</a>     admin.deleteSnapshot(snapshotName);
+<a class="jxr_linenumber" name="308" href="#308">308</a>     FSUtils.logFileSystemState(UTIL.getTestFileSystem(),
+<a class="jxr_linenumber" name="309" href="#309">309</a>       FSUtils.getRootDir(UTIL.getConfiguration()), LOG);
+<a class="jxr_linenumber" name="310" href="#310">310</a> 
+<a class="jxr_linenumber" name="311" href="#311">311</a>     <em class="jxr_comment">// make sure we don't have any snapshots</em>
+<a class="jxr_linenumber" name="312" href="#312">312</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="313" href="#313">313</a>     LOG.debug(<span class="jxr_string">"------- Flush-Snapshot Create List Destroy-------------"</span>);
+<a class="jxr_linenumber" name="314" href="#314">314</a>   }
+<a class="jxr_linenumber" name="315" href="#315">315</a> 
+<a class="jxr_linenumber" name="316" href="#316">316</a>   <em class="jxr_javadoccomment">/**</em>
+<a class="jxr_linenumber" name="317" href="#317">317</a> <em class="jxr_javadoccomment">   * Demonstrate that we reject snapshot requests if there is a snapshot currently running.</em>
+<a class="jxr_linenumber" name="318" href="#318">318</a> <em class="jxr_javadoccomment">   */</em>
+<a class="jxr_linenumber" name="319" href="#319">319</a>   @Test(timeout=60000)
+<a class="jxr_linenumber" name="320" href="#320">320</a>   <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> testConcurrentSnapshottingAttempts() <strong class="jxr_keyword">throws</strong> IOException, InterruptedException {
+<a class="jxr_linenumber" name="321" href="#321">321</a>     <strong class="jxr_keyword">int</strong> ssNum = 10;
+<a class="jxr_linenumber" name="322" href="#322">322</a>     HBaseAdmin admin = UTIL.getHBaseAdmin();
+<a class="jxr_linenumber" name="323" href="#323">323</a>     <em class="jxr_comment">// make sure we don't fail on listing snapshots</em>
+<a class="jxr_linenumber" name="324" href="#324">324</a>     SnapshotTestingUtils.assertNoSnapshots(admin);
+<a class="jxr_linenumber" name="325" href="#325">325</a>     <em class="jxr_comment">// load the table so we have some data</em>
+<a class="jxr_linenumber" name="326" href="#326">326</a>     UTIL.loadTable(<strong class="jxr_keyword">new</strong> HTable(UTIL.getConfiguration(), TABLE_NAME), TEST_FAM);
+<a class="jxr_linenumber" name="327" href="#327">327</a>     <em class="jxr_comment">// and wait until everything stabilizes</em>
+<a class="jxr_linenumber" name="328" href="#328">328</a>     HRegionServer rs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
+<a class="jxr_linenumber" name="329" href="#329">329</a>     List&lt;HRegion&gt; onlineRegions = rs.getOnlineRegions(TABLE_NAME);
+<a class="jxr_linenumber" name="330" href="#330">330</a>     <strong class="jxr_keyword">for</strong> (HRegion region : onlineRegions) {
+<a class="jxr_linenumber" name="331" href="#331">331</a>       region.waitForFlushesAndCompactions();
+<a class="jxr_linenumber" name="332" href="#332">332</a>     }
+<a class="jxr_linenumber" name="333" href="#333">333</a> 
+<a class="jxr_linenumber" name="334" href="#334">334</a>     <em class="jxr_comment">// build descriptions</em>
+<a class="jxr_linenumber" name="335" href="#335">335</a>     SnapshotDescription[] descs = <strong class="jxr_keyword">new</strong> SnapshotDescription[ssNum];
+<a class="jxr_linenumber" name="336" href="#336">336</a>     <strong class="jxr_keyword">for</strong> (<strong class="jxr_keyword">int</strong> i = 0; i &lt; ssNum; i++) {
+<a class="jxr_linenumber" name="337" href="#337">337</a>       SnapshotDescription.Builder builder = SnapshotDescription.newBuilder();
+<a class="jxr_linenumber" name="338" href="#338">338</a>       builder.setTable(STRING_TABLE_NAME);
+<a class="jxr_linenumber" name="339" href="#339">339</a>       builder.setName(<span class="jxr_string">"ss"</span>+i);
+<a class="jxr_linenumber" name="340" href="#340">340</a>       builder.setType(SnapshotDescription.Type.FLUSH);
+<a class="jxr_linenumber" name="341" href="#341">341</a>       descs[i] = builder.build();
+<a class="jxr_linenumber" name="342" href="#342">342</a>     }
+<a class="jxr_linenumber" name="343" href="#343">343</a> 
+<a class="jxr_linenumber" name="344" href="#344">344</a>     <strong class="jxr_keyword">final</strong> CountDownLatch toBeSubmitted = <strong class="jxr_keyword">new</strong> CountDownLatch(ssNum);
+<a class="jxr_linenumber" name="345" href="#345">345</a>     <em class="jxr_comment">// We'll have one of these per thread</em>
+<a class="jxr_linenumber" name="346" href="#346">346</a>     <strong class="jxr_keyword">class</strong> <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">SSRunnable</a> <strong class="jxr_keyword">implements</strong> Runnable {
+<a class="jxr_linenumber" name="347" href="#347">347</a>       SnapshotDescription ss;
+<a class="jxr_linenumber" name="348" href="#348">348</a>       <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">SSRunnable</a>(SnapshotDescription ss) {
+<a class="jxr_linenumber" name="349" href="#349">349</a>         <strong class="jxr_keyword">this</strong>.ss = ss;
+<a class="jxr_linenumber" name="350" href="#350">350</a>       }
+<a class="jxr_linenumber" name="351" href="#351">351</a> 
+<a class="jxr_linenumber" name="352" href="#352">352</a>       @Override
+<a class="jxr_linenumber" name="353" href="#353">353</a>       <strong class="jxr_keyword">public</strong> <strong class="jxr_keyword">void</strong> run() {
+<a class="jxr_linenumber" name="354" href="#354">354</a>         <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="355" href="#355">355</a>           HBaseAdmin admin = UTIL.getHBaseAdmin();
+<a class="jxr_linenumber" name="356" href="#356">356</a>           LOG.info(<span class="jxr_string">"Submitting snapshot request: "</span> + ClientSnapshotDescriptionUtils.toString(ss));
+<a class="jxr_linenumber" name="357" href="#357">357</a>           admin.takeSnapshotAsync(ss);
+<a class="jxr_linenumber" name="358" href="#358">358</a>         } <strong class="jxr_keyword">catch</strong> (Exception e) {
+<a class="jxr_linenumber" name="359" href="#359">359</a>           LOG.info(<span class="jxr_string">"Exception during snapshot request: "</span> + ClientSnapshotDescriptionUtils.toString(
+<a class="jxr_linenumber" name="360" href="#360">360</a>               ss)
+<a class="jxr_linenumber" name="361" href="#361">361</a>               + <span class="jxr_string">".  This is ok, we expect some"</span>, e);
+<a class="jxr_linenumber" name="362" href="#362">362</a>         }
+<a class="jxr_linenumber" name="363" href="#363">363</a>         LOG.info(<span class="jxr_string">"Submitted snapshot request: "</span> + ClientSnapshotDescriptionUtils.toString(ss));
+<a class="jxr_linenumber" name="364" href="#364">364</a>         toBeSubmitted.countDown();
+<a class="jxr_linenumber" name="365" href="#365">365</a>       }
+<a class="jxr_linenumber" name="366" href="#366">366</a>     };
+<a class="jxr_linenumber" name="367" href="#367">367</a> 
+<a class="jxr_linenumber" name="368" href="#368">368</a>     <em class="jxr_comment">// kick each off its own thread</em>
+<a class="jxr_linenumber" name="369" href="#369">369</a>     <strong class="jxr_keyword">for</strong> (<strong class="jxr_keyword">int</strong> i=0 ; i &lt; ssNum; i++) {
+<a class="jxr_linenumber" name="370" href="#370">370</a>       <strong class="jxr_keyword">new</strong> Thread(<strong class="jxr_keyword">new</strong> <a href="../../../../../org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.html">SSRunnable</a>(descs[i])).start();
+<a class="jxr_linenumber" name="371" href="#371">371</a>     }
+<a class="jxr_linenumber" name="372" href="#372">372</a> 
+<a class="jxr_linenumber" name="373" href="#373">373</a>     <em class="jxr_comment">// wait until all have been submitted</em>
+<a class="jxr_linenumber" name="374" href="#374">374</a>     toBeSubmitted.await();
+<a class="jxr_linenumber" name="375" href="#375">375</a> 
+<a class="jxr_linenumber" name="376" href="#376">376</a>     <em class="jxr_comment">// loop until all are done.</em>
+<a class="jxr_linenumber" name="377" href="#377">377</a>     <strong class="jxr_keyword">while</strong> (<strong class="jxr_keyword">true</strong>) {
+<a class="jxr_linenumber" name="378" href="#378">378</a>       <strong class="jxr_keyword">int</strong> doneCount = 0;
+<a class="jxr_linenumber" name="379" href="#379">379</a>       <strong class="jxr_keyword">for</strong> (SnapshotDescription ss : descs) {
+<a class="jxr_linenumber" name="380" href="#380">380</a>         <strong class="jxr_keyword">try</strong> {
+<a class="jxr_linenumber" name="381" href="#381">381</a>           <strong class="jxr_keyword">if</strong> (admin.isSnapshotFinished(ss)) {
+<a class="jxr_linenumber" name="382" href="#382">382</a>             doneCount++;
+<a class="jxr_linenumber" name="383" href="#383">383</a>           }
+<a class="jxr_linenumber" name="384" href="#384">384</a>         } <strong class="jxr_keyword">catch</strong> (Exception e) {
+<a class="jxr_linenumber" name="385" href="#385">385</a>           LOG.warn(<span class="jxr_string">"Got an exception when checking for snapshot "</span> + ss.getName(), e);
+<a class="jxr_linenumber" name="386" href="#386">386</a>           doneCount++;
+<a class="jxr_linenumber" name="387" href="#387">387</a>         }
+<a class="jxr_linenumber" name="388" href="#388">388</a>       }
+<a class="jxr_linenumber" name="389" href="#389">389</a>       <strong class="jxr_keyword">if</strong> (doneCount == descs.length) {
+<a class="jxr_linenumber" name="390" href="#390">390</a>         <strong class="jxr_keyword">break</strong>;
+<a class="jxr_linenumber" name="391" href="#391">391</a>       }
+<a class="jxr_linenumber" name="392" href="#392">392</a>       Thread.sleep(100);
+<a class="jxr_linenumber" name="393" href="#393">393</a>     }
+<a class="jxr_linenumber" name="394" href="#394">394</a> 
+<a class="jxr_linenumber" name="395" href="#395">395</a>     <em class="jxr_comment">// dump for debugging</em>
+<a class="jxr_linenumber" name="396" href="#396">396</a>     logFSTree(FSUtils.getRootDir(UTIL.getConfiguration()));
+<a class="jxr_linenumber" name="397" href="#397">397</a> 
+<a class="jxr_linenumber" name="398" href="#398">398</a>     List&lt;SnapshotDescription&gt; taken = admin.listSnapshots();
+<a class="jxr_linenumber" name="399" href="#399">399</a>     <strong class="jxr_keyword">int</strong> takenSize = taken.size();
+<a class="jxr_linenumber" name="400" href="#400">400</a>     LOG.info(<span class="jxr_string">"Taken "</span> + takenSize + <span class="jxr_string">" snapshots:  "</span> + taken);
+<a class="jxr_linenumber" name="401" href="#401">401</a>     assertTrue(<span class="jxr_string">"We expect at least 1 request to be rejected because of we concurrently"</span> +
+<a class="jxr_linenumber" name="402" href="#402">402</a>         <span class="jxr_string">" issued many requests"</span>, takenSize &lt; ssNum &amp;&amp; takenSize &gt; 0);
+<a class="jxr_linenumber" name="403" href="#403">403</a>     <em class="jxr_comment">// delete snapshots so subsequent tests are clean.</em>
+<a class="jxr_linenumber" name="404" href="#404">404</a>     <strong class="jxr_keyword">for</strong> (SnapshotDescription ss : taken) {
+<a class="jxr_linenumber" name="405" href="#405">405</a>       admin.deleteSnapshot(ss.getName());
+<a class="jxr_linenumber" name="406" href="#406">406</a>     }
+<a class="jxr_linenumber" name="407" href="#407">407</a>   }
+<a class="jxr_linenumber" name="408" href="#408">408</a> 
+<a class="jxr_linenumber" name="409" href="#409">409</a>   <strong class="jxr_keyword">private</strong> <strong class="jxr_keyword">void</strong> logFSTree(Path root) <strong class="jxr_keyword">throws</strong> IOException {
+<a class="jxr_linenumber" name="410" href="#410">410</a>     FSUtils.logFileSystemState(UTIL.getDFSCluster().getFileSystem(), root, LOG);
+<a class="jxr_linenumber" name="411" href="#411">411</a>   }
+<a class="jxr_linenumber" name="412" href="#412">412</a> }
 </pre>
 <hr/><div id="footer">This page was automatically generated by <a href="http://maven.apache.org/">Maven</a></div></body>
 </html>