[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1068: [WIP] Parquet/HFile Log writer and reader

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #1068: [WIP] Parquet/HFile Log writer and reader
URL: https://github.com/apache/incubator-hudi/pull/1068#discussion_r353222499
 
 

 ##########
 File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/logger/InLineHFileReader.java
 ##########
 @@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.utilities.logger;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFile;
+import org.apache.hadoop.hbase.io.hfile.HFileScanner;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.Pair;
+
+public class InLineHFileReader implements InLineReader<Pair<String, String>> {
+
+  HFileScanner scanner;
+
+  InLineHFileReader(Path path, Configuration conf) throws IOException {
+    FileSystem fs = path.getFileSystem(conf);
+    HFile.Reader reader = HFile.createReader(fs, path, new CacheConfig(conf), conf);
+    scanner = reader.getScanner(true, true);
+    scanner.seekTo();
+  }
+
+  @Override
+  public Pair<String, String> read() throws IOException {
+    if (scanner.next()) {
 
 Review comment:
   can you also try a point lookup and benchmark it locally? (write a large 1GB HFile and read out some keys).. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services