[GitHub] [airflow] ianstanton commented on a change in pull request #15477: Chart: Fix passing upgrading strategies to Celery Worker

[GitBox <gi...@apache.org>]

ianstanton commented on a change in pull request #15477:
URL: https://github.com/apache/airflow/pull/15477#discussion_r617956397



##########
File path: chart/templates/workers/worker-deployment.yaml
##########
@@ -46,8 +46,13 @@ spec:
       tier: airflow
       component: worker
       release: {{ .Release.Name }}
-  {{ if .Values.workers.updateStrategy }}
-{{ toYaml .Values.workers.updateStrategy | indent 2 }}
+  {{ if and $persistence .Values.workers.updateStrategy }}
+  updateStrategy:
+    {{- toYaml .Values.workers.updateStrategy | nindent 4 }}
+  {{- end }}
+  {{ if and (not $persistence) (.Values.workers.strategy) }}
+  strategy:
+    {{- toYaml .Values.workers.strategy | nindent 4 }}

Review comment:
       @kaxil What's the reason for using `nindent` here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org