You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/13 00:44:37 UTC
[GitHub] [spark] panbingkun opened a new pull request, #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
panbingkun opened a new pull request, #38637:
URL: https://github.com/apache/spark/pull/38637
### What changes were proposed in this pull request?
This pr aims upgrade sbt-assembly plugin from 1.2.0 to 2.0.0
### Why are the changes needed?
Release notes as follows:
https://github.com/sbt/sbt-assembly/releases/tag/v2.0.0
<img width="1211" alt="image" src="https://user-images.githubusercontent.com/15246973/201500241-f40341b6-bbd2-4224-b18e-f2a696cae23b.png">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
**They are consistent**
## The comparison steps are as follows:
1../build/sbt connect/assembly
2.cd connector/connect/server/target/scala-2.12
3.mkdir tmp & cd tmp
4.cp ../spark-connect-assembly-3.4.0-SNAPSHOT.jar .
5.jar -xvf spark-connect-assembly-3.4.0-SNAPSHOT.jar
6.cd org
7.
(When 1.2.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_1.2.0.txt
(When 2.0.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_2.0.0.txt
8.compare sbt-assembly_1.2.0.txt with bt-assembly_2.0.0.txt
## Result:
<img width="1353" alt="image" src="https://user-images.githubusercontent.com/15246973/205839632-22145053-db82-452d-8488-031134505678.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
They are consistent
1../build/sbt connect/assembly
2.cd connector/connect/server/target/scala-2.12
3.mkdir tmp & cd tmp
4.cp ../spark-connect-assembly-3.4.0-SNAPSHOT.jar .
5.jar -xvf spark-connect-assembly-3.4.0-SNAPSHOT.jar
6.cd org
7.
(When 1.2.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_1.2.0.txt
(When 2.0.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_2.0.0.txt
8.compare sbt-assembly_1.2.0.txt with bt-assembly_2.0.0.txt
<img width="1353" alt="image" src="https://user-images.githubusercontent.com/15246973/205839632-22145053-db82-452d-8488-031134505678.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #38637: [SPARK-41121][BUILD] Upgrade `sbt-assembly` to 2.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38637: [SPARK-41121][BUILD] Upgrade `sbt-assembly` to 2.0.0
URL: https://github.com/apache/spark/pull/38637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38637:
URL: https://github.com/apache/spark/pull/38637#issuecomment-1312615334
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
They are consistent
> When 1.2.0:
<img width="930" alt="image" src="https://user-images.githubusercontent.com/15246973/205833991-afd564b1-7441-42ae-90d9-37f1fffa782d.png">
> After 2.0.0:
<img width="933" alt="image" src="https://user-images.githubusercontent.com/15246973/205834718-3424487f-d66b-4e17-b331-6be20b577e81.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
**They are consistent**
## The comparison steps are as follows:
1../build/sbt connect/assembly
2.cd connector/connect/server/target/scala-2.12
3.mkdir tmp & cd tmp
4.cp ../spark-connect-assembly-3.4.0-SNAPSHOT.jar .
5.jar -xvf spark-connect-assembly-3.4.0-SNAPSHOT.jar
6.sort and compare all "*.class" "*.xml" "*.properties"(name & size)
(When 1.2.0)
find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_1.2.0.txt
find . -name "*.xml" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_xml_1.2.0.txt
find . -name "*.properties" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_properties_1.2.0.txt
(When 2.0.0)
find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_2.0.0.txt
find . -name "*.xml" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_xml_2.0.0.txt
find . -name "*.properties" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_properties_2.0.0.txt
7.compare sbt-assembly_1.2.0.txt with bt-assembly_2.0.0.txt
## Result:
A.class file
<img width="1353" alt="image" src="https://user-images.githubusercontent.com/15246973/205839632-22145053-db82-452d-8488-031134505678.png">
B.xml file
<img width="1238" alt="image" src="https://user-images.githubusercontent.com/15246973/205843551-2fc48b3e-d490-44b8-8460-556846177fd0.png">
C.properties file
<img width="1285" alt="image" src="https://user-images.githubusercontent.com/15246973/205843462-e292fdcb-fe32-4752-9529-8ba9330957d7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
**They are consistent**
## The comparison steps are as follows:
1../build/sbt connect/assembly
2.cd connector/connect/server/target/scala-2.12
3.mkdir tmp & cd tmp
4.cp ../spark-connect-assembly-3.4.0-SNAPSHOT.jar .
5.jar -xvf spark-connect-assembly-3.4.0-SNAPSHOT.jar
6.cd org
7.sort and compare all "*.class"(name & size)
(When 1.2.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_1.2.0.txt
(When 2.0.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_2.0.0.txt
8.compare sbt-assembly_1.2.0.txt with bt-assembly_2.0.0.txt
## Result:
<img width="1353" alt="image" src="https://user-images.githubusercontent.com/15246973/205839632-22145053-db82-452d-8488-031134505678.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1040525670
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
**They are consistent**
## The comparison steps are as follows:
1../build/sbt connect/assembly
2.cd connector/connect/server/target/scala-2.12
3.mkdir tmp & cd tmp
4.cp ../spark-connect-assembly-3.4.0-SNAPSHOT.jar .
5.jar -xvf spark-connect-assembly-3.4.0-SNAPSHOT.jar
6.cd org
7.sort and compare all "*.class"
(When 1.2.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_1.2.0.txt
(When 2.0.0) find . -name "*.class" | sort | xargs ls -al | awk '{print $9" "$5}' > sbt-assembly_2.0.0.txt
8.compare sbt-assembly_1.2.0.txt with bt-assembly_2.0.0.txt
## Result:
<img width="1353" alt="image" src="https://user-images.githubusercontent.com/15246973/205839632-22145053-db82-452d-8488-031134505678.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #38637:
URL: https://github.com/apache/spark/pull/38637#issuecomment-1338818209
> Hi, @panbingkun . Is there any update according to @LuciferYang 's comment?
Done.
They are consistent.
@LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38637:
URL: https://github.com/apache/spark/pull/38637#discussion_r1021393419
##########
project/plugins.sbt:
##########
@@ -25,7 +25,7 @@ libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "9.3"
// checkstyle uses guava 31.0.1-jre.
libraryDependencies += "com.google.guava" % "guava" % "31.0.1-jre"
-addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "1.2.0")
+addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "2.0.0")
Review Comment:
Can you help to check whether the contents of the `connect` assembly jar are consistent before and after the pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #38637: [SPARK-41121][BUILD] Upgrade sbt-assembly from 1.2.0 to 2.0.0
Posted by GitBox <gi...@apache.org>.
panbingkun commented on PR #38637:
URL: https://github.com/apache/spark/pull/38637#issuecomment-1338868436
> Hi, @panbingkun . Is there any update according to @LuciferYang 's comment?
They are consistent.
The comparison process is as above.
@LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #38637: [SPARK-41121][BUILD] Upgrade `sbt-assembly` to 2.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38637:
URL: https://github.com/apache/spark/pull/38637#issuecomment-1339031913
Merged to master for Apache Spark 3.4.0.
Thank you, @panbingkun and @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org