You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/15 12:13:11 UTC
[GitHub] [spark] cloud-fan commented on issue #24233: [SPARK-26356][SQL]
remove SaveMode from data source v2
cloud-fan commented on issue #24233: [SPARK-26356][SQL] remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#issuecomment-492628836
I'd like to move forward this PR with the schema check hack, because of https://github.com/apache/spark/pull/24469#issuecomment-491696938
In addition, this PR
1. makes append mode the default when writing to data source v2
2. keep the hack for file source. Previously the file source relied on `SupportsSaveMode` to support all the save modes. Several tests() rely on it and removing the hack fails these tests. If we want to remove the hack, we should do it in a new PR and update these tests.
What do you think? @rdblue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org