You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Arne Limburg (JIRA)" <ji...@codehaus.org> on 2009/05/23 21:22:42 UTC
[jira] Created: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Doxia generates wrong xdoc when generating book from docbook
------------------------------------------------------------
Key: DOXIA-324
URL: http://jira.codehaus.org/browse/DOXIA-324
Project: Maven Doxia
Issue Type: Bug
Affects Versions: 1.1
Reporter: Arne Limburg
When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Arne Limburg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arne Limburg updated DOXIA-324:
-------------------------------
Attachment: doxia-book-sample.zip
This test demonstrates the problem
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Attachments: doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Arne Limburg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arne Limburg updated DOXIA-324:
-------------------------------
Attachment: AbstractXdocBookSink.patch
I don't know if there is a more elegant way to do it, but the applied patch fixes the problem
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179572#action_179572 ]
Lukas Theussl commented on DOXIA-324:
-------------------------------------
Thanks for testing and the feedback!
So a fix would be to check for the special case of article and emit the anchor after the document start.
However, I have some doubts:
* I checked that an id attribute is legal for article in simplified docbook, but I don't quite see the use case, what is it for?
* we have removed automatic anchor generation from the apt and xdoc parsers (see eg DOXIA-152), I think the docbook should do the same. If the id attribute of an element is preserved, then one can link to that, you don't need an anchor. However, I don't use docbook myself so I'm not too sure if this isn't going to break something I am not aware of. Especially in a point release we should try not to change any expected behavior, but in principle I would vote for removing the anchor insertion.
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Assignee: Lukas Theussl
> Fix For: 1.1.1
>
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=177830#action_177830 ]
Lukas Theussl commented on DOXIA-324:
-------------------------------------
This is a general problem of the docbook parser, see DOXIA-184, it should be fixed there.
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukas Theussl closed DOXIA-324.
-------------------------------
Resolution: Fixed
I have simply removed the anchor generation from the article tag for now, this fixes the build failure. The id is forwarded directly into the sink's head, eg for xdoc it goes into the <document> tag. I have opened DOXIA-334 for the general anchor generation issue.
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Assignee: Lukas Theussl
> Fix For: 1.1.1
>
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Arne Limburg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arne Limburg reopened DOXIA-324:
--------------------------------
Hi Lukas,
thank you for fixing this so fast. But there is still a bug in this piece of code (see the attached test).
I think the call to handleIdAnchor( parser, sink ) in handleStartTag in DocbookParser must go somewhere else in that method.
Thank you anyway, for me it now works since my articles need no id-attribute.
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Assignee: Lukas Theussl
> Fix For: 1.1.1
>
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Arne Limburg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arne Limburg updated DOXIA-324:
-------------------------------
Attachment: doxia-book-sample.zip
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Assignee: Lukas Theussl
> Fix For: 1.1.1
>
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DOXIA-324) Doxia generates wrong xdoc when
generating book from docbook
Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lukas Theussl closed DOXIA-324.
-------------------------------
Assignee: Lukas Theussl
Resolution: Fixed
Fix Version/s: 1.1.1
Fixed in [r781693|http://svn.apache.org/viewvc?view=rev&revision=781693]
Note that your docbook sources are not valid. Doxia requires valid simplified docbook input, ie there should be an <article> root element. Your files should look like this:
{code:xml}
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article PUBLIC "-//OASIS//DTD Simplified DocBook XML V1.1//EN" "http://www.oasis-open.org/docbook/xml/simple/1.1/sdocbook.dtd">
<article>
<section id="section1">
<title>Section 1</title>
<para>This is the first section.</para>
</section>
</article>
{code}
> Doxia generates wrong xdoc when generating book from docbook
> ------------------------------------------------------------
>
> Key: DOXIA-324
> URL: http://jira.codehaus.org/browse/DOXIA-324
> Project: Maven Doxia
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Arne Limburg
> Assignee: Lukas Theussl
> Fix For: 1.1.1
>
> Attachments: AbstractXdocBookSink.patch, doxia-book-sample.zip
>
>
> When generating a book from a docbook input the output is missing the starting document tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira