[jira] [Comment Edited] (TEZ-3224) User payload is not initialized before creating vertex manager plugin

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253018#comment-15253018 ] 

Hitesh Shah edited comment on TEZ-3224 at 4/21/16 11:49 PM:
------------------------------------------------------------

Minor nit: I think CheckUserPayloadVertexManagerPlugin is better off as a static inner class as it is used in one very specific context within the test code. Apart from that, this looks good (jenkins will likely throw a license header audit warning for the new file ).  


was (Author: hitesh):
Minor nit: I think CheckUserPayloadVertexManagerPlugin is better off as a static inner class as it is used in one very specific context within the test code. Apart from that, this looks good.  

> User payload is not initialized before creating vertex manager plugin
> ---------------------------------------------------------------------
>
>                 Key: TEZ-3224
>                 URL: https://issues.apache.org/jira/browse/TEZ-3224
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Zhiyuan Yang
>            Assignee: Zhiyuan Yang
>         Attachments: TEZ-3224.1.patch, TEZ-3224.2.patch
>
>
> In VertexManager constructor, we create VertexManagerPlugin before initializing user payload. 
> {code:java}
> plugin = ReflectionUtils.createClazzInstance(pluginDesc.getClassName(),
>         new Class[] { VertexManagerPluginContext.class }, new Object[] { pluginContext });
> payload = pluginDesc.getUserPayload();
> {code}
> Trying to access user payload in VertexManagerPlugin constructor will result in a NullPointerException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)