You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/02/22 16:44:31 UTC

[Bug 5348] New: ASN plugin -- inconsistent info about required configuration

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348

           Summary: ASN plugin -- inconsistent info about required
                    configuration
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Plugins
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: schneecrash+apache@gmail.com


in v320-trunk's "320.pre",

       # ASN - look up the Autonomous System Number of connecting IP
       # requires additional configuration, see plugin's POD docs
       # loadplugin Mail::SpamAssassin::Plugin::ASN

yet, in

       man Mail::SpamAssassin::Plugin::ASN

find,

       CONFIGURATION
              This plugin has no user-serviceable parts or configurations.

what "additional configuration" is required?

please either clarify, or make consistent.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348


spamassassin@dostech.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From spamassassin@dostech.ca  2007-03-07 12:03 -------
[dos@FC5-VPC trunk]$ svn ci -m "bug 5348: add 25_asn.cf for ASN plugin and
cleanup/clairify plugin POD"
Sending        MANIFEST
Sending        lib/Mail/SpamAssassin/Plugin/ASN.pm
Adding         rules/25_asn.cf
Sending        rules/v320.pre
Transmitting file data ....
Committed revision 515725.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348





------- Additional Comments From schneecrash+apache@gmail.com  2007-02-22 09:35 -------
(In reply to comment #6)
> is there not an XX_asn.cf file?

not that _i_ can find in my distro & update folders/files.

also, a grep on "ASN_LOOKUP" comes up empty.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348





------- Additional Comments From matthias@leisi.net  2007-02-22 08:49 -------
(In reply to comment #1)
> yep, that *is* confusing ;)  need to fix for 3.2.0...

Indeed. No idea how that got there. Actually the whole paragraph

       This plugin has no user-serviceable parts or configurations. The stan-
       dard loading sequence is as follows:

can be removed. Justin, do you need a patch? ;)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348





------- Additional Comments From schneecrash+apache@gmail.com  2007-02-22 09:20 -------
<grumble> documentation written by developers </grumble>

"
	standard loading sequence is as follows:

	   loadplugin      Mail::SpamAssassin::Plugin::ASN

	   ifplugin        Mail::SpamAssassin::Plugin::ASN
	   header          ASN_LOOKUP eval:asn_lookup('asn.routeviews.org', 2)
	   add_header      all ASN _ASN_ _ASNCIDR_
	   endif
"

does this mean that users are supposed to add this themseleves to their
'local.cf', and that, even though the 'loadplugin ...' _is_ in the distro's
320.pre, that it's NOT included in the distro's *.cf's also/already?




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348





------- Additional Comments From matthias@leisi.net  2007-02-22 09:10 -------
(In reply to comment #3)

> might we get some doc as to what that is? rather then just knowing that it ...
> er ... "isn't not" required?

The ASN zone and the number of lookups to perform (see the paragraphs following
the loadplugin...endif lines).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348





------- Additional Comments From parkerm@pobox.com  2007-02-22 09:24 -------
That is a good point, is there not an XX_asn.cf file?  I think there should be,
with a reasonable default configuration and instructions for altering it as a
comment to that file as well as in the plugin docs.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348


jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.2.0




------- Additional Comments From jm@jmason.org  2007-02-22 07:56 -------
yep, that *is* confusing ;)  need to fix for 3.2.0...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5348] ASN plugin -- inconsistent info about required configuration

Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5348





------- Additional Comments From schneecrash+apache@gmail.com  2007-02-22 08:56 -------
> "... This plugin has no user-serviceable parts or configurations.
> The standard loading sequence is as follows: ..." can be removed

ok. that, then, sounds like we're left with the fact that "additional
configuration" *is* required.

might we get some doc as to what that is? rather then just knowing that it ...
er ... "isn't not" required?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.