You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/05/25 15:05:39 UTC
[GitHub] [beam] Abacn opened a new pull request, #26893: [Test only] flink load test with lcg synthetic data
Abacn opened a new pull request, #26893:
URL: https://github.com/apache/beam/pull/26893
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26893: Switch Flink load test with lcg synthetic data
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1564440264
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563582254
Run Load Tests Python Combine Flink Batch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26893: Switch Flink load test with lcg synthetic data
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1565019205
Thank you, this LGTM.
Using a consistnt place for containers for all languages makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563151427
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26893?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#26893](https://app.codecov.io/gh/apache/beam/pull/26893?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7b63e5c) into [master](https://app.codecov.io/gh/apache/beam/commit/d8f0e1786f1c0d6799783a3cb4a145f2a5d8d94d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d8f0e17) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26893 +/- ##
=======================================
Coverage 71.27% 71.27%
=======================================
Files 766 766
Lines 103470 103470
=======================================
Hits 73747 73747
Misses 28184 28184
Partials 1539 1539
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563341002
[Test result](https://ci-beam.apache.org/job/beam_LoadTests_Python_Combine_Flink_Batch_PR/55/console)
python_flink_batch_combine_1_runtime Value: 3235
on master, latest 3 results:
python_flink_batch_combine_1_runtime Value: 5362 5398 5272
It's 40% "improvement", similar to the Dataflow case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563533932
Run Python xlang KafkaIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26893: Switch Flink load test with lcg synthetic data
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563672051
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: Switch Flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1564438766
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #26893: Switch Flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26893:
URL: https://github.com/apache/beam/pull/26893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563554627
It appears that read from SyntheticSource is still slower than read from ReShuffle service. For kafka xlang test:
read from SyntheticSource (lcg) write_runtime Value: 403 s that is 6.7 min
read from ReShuffle service, write_runtime is now < 5 min
Unrelated but there is an improvement on May 13 where the run time for both write and read reduced significantly. Before that write time is 6.5 min
<img width="716" alt="image" src="https://github.com/apache/beam/assets/8010435/27f24057-d48e-4891-8fdf-a2bcd2c2fdcf">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563573286
run seed job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563559281
run seed job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: Switch Flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1565155728
Thanks. Opened #26921 for consolidating docker image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563073351
Run Load Tests Python Combine Flink Batch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #26893: [Test only] flink load test with lcg synthetic data
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26893:
URL: https://github.com/apache/beam/pull/26893#issuecomment-1563557616
Revert kafka test change for now (it was for testing purpose only); mark the PR as ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org