You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "altman08 (via GitHub)" <gi...@apache.org> on 2026/05/12 10:36:09 UTC

[PR] fix(selective_channel): isolate backup responses and add race regress… (brpc)

altman08 opened a new pull request, #3294:
URL: https://github.com/apache/brpc/pull/3294

   …ion test
   
   ### What problem does this PR solve?
   
   Issue Number: resolve 
   
   Problem Summary:
   In SelectiveChannel backup-request flows, two concurrent subcalls may race on response lifecycle and produce inconsistent response data (e.g. unexpected repeated field sizes). In worse timing windows, this can lead to memory corruption and crash during protobuf cleanup (observed in RepeatedPtrFieldBase::DestroyProtos while clearing sub-responses).
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects:
   
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix(selective_channel): isolate backup responses and add race regress… (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3294:
URL: https://github.com/apache/brpc/pull/3294#issuecomment-4437193619

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix(selective_channel): isolate backup responses and add race regress… (brpc)

Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright merged PR #3294:
URL: https://github.com/apache/brpc/pull/3294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org