You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/23 08:30:55 UTC

[GitHub] [incubator-mxnet] grygielski opened a new pull request #19578: [FEATURE] Add BN+ReLU -> BatchNormWithRelu fuse to MKLDNN backend

grygielski opened a new pull request #19578:
URL: https://github.com/apache/incubator-mxnet/pull/19578


   ## Description ##
   This PR adds `BN + ReLU` -> `BatchNormReLU` fuse into MKLDNN backend. It results in speedup of Resnet V2 models since they don't only have `conv+bn+relu` patterns but also `bn+relu` without convolution before it.
   
   Approximate speedups measured on i9 machine:
   ```
   resnet18_v2: 5.0%
   resnet50_v2: 11.6%
   resnet101_v2: 10.9%
   resnet152_v2: 10.4%
   ```
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   ### Changes ###
   - Added `mkldnn_bn_relu_property`
   
   ## Comments ##
   - This fuse can be added also to `MKLDNN_QUANTIZE` backend once we restore quantization files and test it
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #19578: [FEATURE] Add BN+ReLU -> BatchNormWithRelu fuse to MKLDNN backend

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19578:
URL: https://github.com/apache/incubator-mxnet/pull/19578


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] grygielski commented on pull request #19578: [FEATURE] Add BN+ReLU -> BatchNormWithRelu fuse to MKLDNN backend

Posted by GitBox <gi...@apache.org>.
grygielski commented on pull request #19578:
URL: https://github.com/apache/incubator-mxnet/pull/19578#issuecomment-732143878


   @anko-intel @PatricZhao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] grygielski commented on pull request #19578: [FEATURE] Add BN+ReLU -> BatchNormWithRelu fuse to MKLDNN backend

Posted by GitBox <gi...@apache.org>.
grygielski commented on pull request #19578:
URL: https://github.com/apache/incubator-mxnet/pull/19578#issuecomment-732009773


   @mxnet-label-bot add [MKLDNN]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] grygielski edited a comment on pull request #19578: [FEATURE] Add BN+ReLU -> BatchNormWithRelu fuse to MKLDNN backend

Posted by GitBox <gi...@apache.org>.
grygielski edited a comment on pull request #19578:
URL: https://github.com/apache/incubator-mxnet/pull/19578#issuecomment-732143878


   @anko-intel @pengzhao-intel 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19578: [FEATURE] Add BN+ReLU -> BatchNormWithRelu fuse to MKLDNN backend

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19578:
URL: https://github.com/apache/incubator-mxnet/pull/19578#issuecomment-732009215


   Hey @grygielski , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, sanity, clang, windows-gpu, miscellaneous, centos-cpu, unix-gpu, centos-gpu, windows-cpu, unix-cpu, edge]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org