[GitHub] [superset] eschutho commented on a diff in pull request #21684: fix: add logging to alerts and reports to find non-triggering issues

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #21684:
URL: https://github.com/apache/superset/pull/21684#discussion_r986037688


##########
superset/reports/commands/alert.py:
##########
@@ -166,6 +166,9 @@ def _execute_query(self) -> pd.DataFrame:
             logger.warning("A timeout occurred while executing the alert query: %s", ex)
             raise AlertQueryTimeout() from ex
         except Exception as ex:
+            logger.warning(
+                "A general exception occurred while executing the alert query: %s", ex
+            )
             raise AlertQueryError(message=str(ex)) from ex

Review Comment:
   does this exception already log this error?



##########
superset/reports/commands/execute.py:
##########
@@ -436,6 +436,7 @@ def send_error(self, name: str, message: str) -> None:
         """
         header_data = self._get_log_data()
         header_data["error_text"] = message
+        logger.info("header_data infor %s", header_data)

Review Comment:
   typo `infor`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org