[jira] [Commented] (FELIX-3254) manifest goal generates wrong Export-Package when Embed-Dependency

["Stuart McCulloch (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162522#comment-13162522 ] 

Stuart McCulloch commented on FELIX-3254:
-----------------------------------------

Confirmed that the rebuildBundle setting:

  <configuration>
    <rebuildBundle>true</rebuildBundle>
    <instructions>
      <!-- ... -->
    </instructions>
  </configuration>

works and should be used for this use-case.

The original behaviour of the manifest goal (ie. long before 2.3.4 and FELIX-2817) was to take the content of the attached file (or target/classes) and generate a manifest based on that, and that only. The use-case was that you created the content by some other means (ie. not using Embed-Dependency, etc.) and wanted a manifest based on that content. A slightly different use-case came up in FELIX-2817 where people wanted the exact same results as doing bundle:bundle (which does an in-memory build) when they created the manifest - this is the same use-case as the attached project.

There's no solution that I know of which can accommodate both use-cases with the same goal - which is why the flag (rebuildBundle) was added to switch between the 'analyzer' approach that is quick and means you don't have to match the instructions with the content (but it doesn't handle all the Include-Resource instructions) and the 'builder' approach which does a full analysis but means your instructions must describe the content of the bundle.

We could add a warning if people use instructions that don't make sense with rebuildBundle=false - I think that's better than trying to guesstimate the right setting. 
                
> manifest goal generates wrong Export-Package when Embed-Dependency
> ------------------------------------------------------------------
>
>                 Key: FELIX-3254
>                 URL: https://issues.apache.org/jira/browse/FELIX-3254
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.3.6
>            Reporter: Igor Fedorenko
>         Attachments: FELIX-3254.zip
>
>
> manifest goal does not seem to consider Embed-Dependency and _exportcontents when generating Export-Package in 2.3.6. This used to work in 2.3.5 and looks like a regression introduced by FELIX-3206. I'll attach a sample project that demonstrates the problem shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira