[GitHub] [pulsar] eolivelli commented on a change in pull request #8261: Support limits the max tenants of the Pulsar cluster

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #8261:
URL: https://github.com/apache/pulsar/pull/8261#discussion_r504560033



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java
##########
@@ -105,6 +105,12 @@ public void createTenant(
 
         try {
             NamedEntity.checkName(tenant);
+            List<String> tenants = globalZk().getChildren(path(POLICIES), false);
+            int maxTenants = pulsar().getConfiguration().getMaxTenants();
+            //No locks for precise control

Review comment:
       So we can have a race and see that this limit is not enforced.
   probably this is not a big deal (and enforcing it would be very costly) but we should state it clearly at least in the description of this pull request




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org