You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/09/18 23:07:20 UTC

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23441


Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................

KUDU-1261 Fix bug in wire_protocol.cc

This patch sets the type attributes for Nested 1D Array Columns
of types - DECIMAL and VARCHAR.

Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
---
M src/kudu/common/wire_protocol.cc
1 file changed, 8 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/23441/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 22 Sep 2025 05:34:41 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1827/


-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 21 Sep 2025 06:29:31 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23441

to look at the new patch set (#2).

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................

KUDU-1261 Fix bug in wire_protocol.cc

This patch sets the type attributes for Nested 1D Array Columns
of types - DECIMAL and VARCHAR.

Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
2 files changed, 59 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/23441/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1818/


-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Sep 2025 23:07:21 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................

KUDU-1261 Fix bug in wire_protocol.cc

This patch sets the type attributes for Nested 1D Array Columns
of types - DECIMAL and VARCHAR.

Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Reviewed-on: http://gerrit.cloudera.org:8080/23441
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
2 files changed, 59 insertions(+), 6 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

Thank you for the fix!

http://gerrit.cloudera.org:8080/#/c/23441/1/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

PS1: 
I know this bug manifests itself in high-level/integration-level tests, but could you add a small unit test scenario into wire_protocol-test.cc that would fail without this patch?  It might be something similar to ScalarArray1DToPB added earlier or just be a part of the scenario.  That should help catch regressions without involving many other components in the middle.


http://gerrit.cloudera.org:8080/#/c/23441/1/src/kudu/common/wire_protocol.cc@238
PS1, Line 238: attrs_target
nit: rename into 'elem_type', and then re-use it under the 'if (type == DataType::NESTED)' clause without introducing and extra local variable in that scope?



-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Sep 2025 00:23:07 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1827/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 21 Sep 2025 09:11:58 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23441/1/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

PS1: 
> I know this bug manifests itself in high-level/integration-level tests, but
Done


http://gerrit.cloudera.org:8080/#/c/23441/1/src/kudu/common/wire_protocol.cc@238
PS1, Line 238: elem_type = 
> nit: rename into 'elem_type', and then re-use it under the 'if (type == Dat
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 21 Sep 2025 06:30:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1818/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 19 Sep 2025 00:30:08 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1261 Fix bug in wire protocol.cc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23441 )

Change subject: KUDU-1261 Fix bug in wire_protocol.cc
......................................................................


Patch Set 2: Verified+1

unrelated Java test failures of known flaky tests:
  * ASAN: org.apache.kudu.backup.TestKuduBackup 	
  * TSAN: org.apache.kudu.client.TestKuduClient


-- 
To view, visit http://gerrit.cloudera.org:8080/23441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ef6d8490c3452cb87c22eb48c70263853892d11
Gerrit-Change-Number: 23441
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 22 Sep 2025 05:34:38 +0000
Gerrit-HasComments: No