[GitHub] [arrow] mapleFU commented on a diff in pull request #35464: GH-35125: [C++][Acero] Add a self-defined io-executor in QueryOptions

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #35464:
URL: https://github.com/apache/arrow/pull/35464#discussion_r1198564484


##########
cpp/src/arrow/acero/query_context.cc:
##########
@@ -23,10 +23,17 @@ namespace arrow {
 using arrow::internal::CpuInfo;
 namespace acero {
 
+io::IOContext getIoContext(QueryOptions& opts, ExecContext& exec_context) {

Review Comment:
   I think `exec_context` can be make as constant, but `custom_io_executor` should be non-const, so `QueryOptions` cannot have `const`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org