[GitHub] [arrow] mapleFU commented on a diff in pull request #34112: GH-14870: [C++][Parquet] Fix parsing stats from min_value/max_value

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #34112:
URL: https://github.com/apache/arrow/pull/34112#discussion_r1102326408


##########
cpp/src/parquet/column_reader.cc:
##########
@@ -211,10 +211,15 @@ EncodedStatistics ExtractStatsFromHeader(const H& header) {
     return page_statistics;
   }
   const format::Statistics& stats = header.statistics;
-  if (stats.__isset.max) {
+  // Use the new V2 min-max statistics over the former one if it is filled

Review Comment:
   Previously, `page_statistics` will handle min-max separately. This patch changes it to once have all min-max, otherwise, cannot use min-max



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org