You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/16 09:24:13 UTC

[GitHub] [dubbo-go] sunrui1225 opened a new pull request #1592: Config update issue

sunrui1225 opened a new pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592


   issue: https://github.com/apache/dubbo-go/issues/1517
   
   add Process method to root_config implements ConfigurationListener. auto update config by config center event. 
   update registries timeout, rang each registryId(eg: demoZK) , 
   if nacos's registry timeout not equal local root config's registry timeout , update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3505b5f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/b90089d8b8a392f2b771364e4d5641a21c01377c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b90089d) will **increase** coverage by `0.12%`.
   > The diff coverage is `94.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1592      +/-   ##
   ==========================================
   + Coverage   41.14%   41.26%   +0.12%     
   ==========================================
     Files         250      250              
     Lines       14277    14297      +20     
   ==========================================
   + Hits         5874     5900      +26     
   + Misses       7719     7714       -5     
   + Partials      684      683       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `48.57% <0.00%> (-0.47%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `44.38% <100.00%> (+7.73%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
   | [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <0.00%> (+0.13%)` | :arrow_up: |
   | [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `28.57% <0.00%> (+1.71%)` | :arrow_up: |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+15.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b90089d...3505b5f](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sunrui1225 commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r751000958



##########
File path: config/testdata/root_config_test.yml
##########
@@ -0,0 +1,17 @@
+dubbo:
+  registries:
+    demoZK:
+      protocol: zookeeper
+      timeout: 11s
+      address: 127.0.0.1:2181
+  protocols:
+    triple:
+      name: "tri"

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sunrui1225 commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r750203168



##########
File path: config/root_config_test.go
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+	"dubbo.apache.org/dubbo-go/v3/common/yaml"

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3505b5f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/9a12e9948587241529cbd48c25829432f7d01e90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a12e99) will **increase** coverage by `0.00%`.
   > The diff coverage is `94.44%`.
   
   > :exclamation: Current head 3505b5f differs from pull request most recent head 3ec923e. Consider uploading reports for the commit 3ec923e to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##              3.0    #1592    +/-   ##
   ========================================
     Coverage   41.26%   41.26%            
   ========================================
     Files         254      250     -4     
     Lines       14589    14297   -292     
   ========================================
   - Hits         6020     5900   -120     
   + Misses       7871     7714   -157     
   + Partials      698      683    -15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `48.57% <0.00%> (-1.92%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `44.38% <100.00%> (+3.44%)` | :arrow_up: |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `53.73% <0.00%> (-9.29%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-8.61%)` | :arrow_down: |
   | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `50.00% <0.00%> (-6.82%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `31.23% <0.00%> (-3.15%)` | :arrow_down: |
   | [metadata/report/nacos/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L25hY29zL3JlcG9ydC5nbw==) | `37.77% <0.00%> (-2.23%)` | :arrow_down: |
   | [filter/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <0.00%> (-1.25%)` | :arrow_down: |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a12e99...3ec923e](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r750154672



##########
File path: config/root_config_test.go
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+	"dubbo.apache.org/dubbo-go/v3/common/yaml"

Review comment:
       split this import block.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ab9bde) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/b90089d8b8a392f2b771364e4d5641a21c01377c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b90089d) will **increase** coverage by `0.07%`.
   > The diff coverage is `94.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1592      +/-   ##
   ==========================================
   + Coverage   41.14%   41.21%   +0.07%     
   ==========================================
     Files         250      250              
     Lines       14277    14295      +18     
   ==========================================
   + Hits         5874     5892      +18     
     Misses       7719     7719              
     Partials      684      684              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `48.57% <0.00%> (-0.47%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `44.38% <100.00%> (+7.73%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b90089d...8ab9bde](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sunrui1225 commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r771917946



##########
File path: config/root_config.go
##########
@@ -358,3 +360,25 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Infof("CenterConfig process event:\n%+v", event)
+	koan := koanf.New(".")
+	if err := koan.Load(rawbytes.Provider([]byte(event.Value.(string))), yaml.Parser()); err != nil {

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sunrui1225 commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r761872361



##########
File path: config/root_config.go
##########
@@ -358,3 +360,29 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Info("CenterConfig process event:\n%+v", event)

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb5dc84) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/e3768344ecb0d22ac22b7e530070f5c15c1c4e40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e376834) will **increase** coverage by `0.08%`.
   > The diff coverage is `94.11%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1592      +/-   ##
   ==========================================
   + Coverage   41.15%   41.24%   +0.08%     
   ==========================================
     Files         254      254              
     Lines       14590    14607      +17     
   ==========================================
   + Hits         6005     6024      +19     
   + Misses       7888     7886       -2     
     Partials      697      697              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `50.00% <0.00%> (-0.49%)` | :arrow_down: |
   | [config/registry\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZ2lzdHJ5X2NvbmZpZy5nbw==) | `20.51% <100.00%> (+1.66%)` | :arrow_up: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `46.44% <100.00%> (+5.51%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e376834...bb5dc84](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3505b5f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/9a12e9948587241529cbd48c25829432f7d01e90?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a12e99) will **increase** coverage by `0.00%`.
   > The diff coverage is `94.44%`.
   
   > :exclamation: Current head 3505b5f differs from pull request most recent head 8cfc98c. Consider uploading reports for the commit 8cfc98c to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff            @@
   ##              3.0    #1592    +/-   ##
   ========================================
     Coverage   41.26%   41.26%            
   ========================================
     Files         254      250     -4     
     Lines       14589    14297   -292     
   ========================================
   - Hits         6020     5900   -120     
   + Misses       7871     7714   -157     
   + Partials      698      683    -15     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `48.57% <0.00%> (-1.92%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `44.38% <100.00%> (+3.44%)` | :arrow_up: |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `53.73% <0.00%> (-9.29%)` | :arrow_down: |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-8.61%)` | :arrow_down: |
   | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `50.00% <0.00%> (-6.82%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `31.23% <0.00%> (-3.15%)` | :arrow_down: |
   | [metadata/report/nacos/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L25hY29zL3JlcG9ydC5nbw==) | `37.77% <0.00%> (-2.23%)` | :arrow_down: |
   | [filter/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <0.00%> (-1.25%)` | :arrow_down: |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9a12e99...8cfc98c](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3505b5f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/b90089d8b8a392f2b771364e4d5641a21c01377c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b90089d) will **increase** coverage by `0.12%`.
   > The diff coverage is `94.44%`.
   
   > :exclamation: Current head 3505b5f differs from pull request most recent head 6a18599. Consider uploading reports for the commit 6a18599 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1592      +/-   ##
   ==========================================
   + Coverage   41.14%   41.26%   +0.12%     
   ==========================================
     Files         250      250              
     Lines       14277    14297      +20     
   ==========================================
   + Hits         5874     5900      +26     
   + Misses       7719     7714       -5     
   + Partials      684      683       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `48.57% <0.00%> (-0.47%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `44.38% <100.00%> (+7.73%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
   | [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <0.00%> (+0.13%)` | :arrow_up: |
   | [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `28.57% <0.00%> (+1.71%)` | :arrow_up: |
   | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+15.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b90089d...6a18599](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r757464117



##########
File path: config/root_config.go
##########
@@ -358,3 +360,29 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Info("CenterConfig process event:\n%+v", event)

Review comment:
       I think change to logger.Infof is better

##########
File path: config/root_config.go
##########
@@ -358,3 +360,29 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Info("CenterConfig process event:\n%+v", event)
+	koan := koanf.New(".")
+	if err := koan.Load(rawbytes.Provider([]byte(event.Value.(string))), yaml.Parser()); err != nil {
+		logger.Errorf("CenterConfig process load failed, got error %#v", err)
+		return
+	}
+	tempRootConfig := &RootConfig{}
+	if err := koan.UnmarshalWithConf(rc.Prefix(),
+		tempRootConfig, koanf.UnmarshalConf{Tag: "yaml"}); err != nil {
+		logger.Errorf("CenterConfig process unmarshalConf failed, got error %#v", err)
+		return
+	}
+	// update registries timeout, rang each registryId(eg: demoZK) ,
+	// if nacos's registry timeout not equal local root config's registry timeout , update.
+	for _, registryId := range tempRootConfig.getRegistryIds() {
+		tempRegistry := tempRootConfig.Registries[registryId]
+		rcRegistry := rc.Registries[registryId]
+		if tempRegistry != nil && rcRegistry != nil && tempRegistry.Timeout != rcRegistry.Timeout {
+			rc.Registries[registryId].Timeout = tempRegistry.Timeout
+			logger.Infof("CenterConfig process update %s timeout, new value:%s", registryId, rc.Registries[registryId].Timeout)
+		}

Review comment:
       1. 这块代码，你是直接在当前rootConfig 的process函数里改的。这样不太好。
   每一层级只关心自己这一层级的配置。rootConfig函数的process方法应当只负责查看是否当前事件需要被更新，如果需要，则将事件里面的更新的信息下传至子模块中更新，而不是在这一层做。
   因此这一块代码判断和修改的逻辑，应当放到registryConfig 的process方法内做，传入的参数应当为新的registryConfig。
   
   2. registryConfig 的 timeout 修改了，不代表真正应用到了registry 的客户端上，因此需要在registryConfig这一层的process方法来进一步处理。
   @sunrui1225




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r750886417



##########
File path: config/testdata/root_config_test.yml
##########
@@ -0,0 +1,17 @@
+dubbo:
+  registries:
+    demoZK:
+      protocol: zookeeper
+      timeout: 11s
+      address: 127.0.0.1:2181
+  protocols:
+    triple:
+      name: "tri"
+      port: 20000
+  provider:
+    registry-ids:
+      - demoZK
+    services:
+      GreeterProvider:
+        protocol-ids: triple
+        interface: com.apache.dubbo.sample.basic.IGreeter # must be compatible with grpc or dubbo-java

Review comment:
       Maybe, it is better if use our generic interface here. cc @LaurenceLiZhixin 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r754293370



##########
File path: config/root_config.go
##########
@@ -358,3 +360,29 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Info("CenterConfig process event:\n%+v", event)

Review comment:
       logger.Debugf




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-979950306


   这个pr 云老板可以好好关注下 @zhaoyunxing92 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r750886782



##########
File path: config/testdata/root_config_test.yml
##########
@@ -0,0 +1,17 @@
+dubbo:
+  registries:
+    demoZK:
+      protocol: zookeeper
+      timeout: 11s
+      address: 127.0.0.1:2181
+  protocols:
+    triple:
+      name: "tri"

Review comment:
       Remove quotation mark please.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-992412169


   Please use import-formatter to fix the import problem. @sunrui1225 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sunrui1225 commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r771918429



##########
File path: config/root_config.go
##########
@@ -358,3 +360,29 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Info("CenterConfig process event:\n%+v", event)
+	koan := koanf.New(".")
+	if err := koan.Load(rawbytes.Provider([]byte(event.Value.(string))), yaml.Parser()); err != nil {
+		logger.Errorf("CenterConfig process load failed, got error %#v", err)
+		return
+	}
+	tempRootConfig := &RootConfig{}
+	if err := koan.UnmarshalWithConf(rc.Prefix(),
+		tempRootConfig, koanf.UnmarshalConf{Tag: "yaml"}); err != nil {
+		logger.Errorf("CenterConfig process unmarshalConf failed, got error %#v", err)
+		return
+	}
+	// update registries timeout, rang each registryId(eg: demoZK) ,
+	// if nacos's registry timeout not equal local root config's registry timeout , update.
+	for _, registryId := range tempRootConfig.getRegistryIds() {
+		tempRegistry := tempRootConfig.Registries[registryId]
+		rcRegistry := rc.Registries[registryId]
+		if tempRegistry != nil && rcRegistry != nil && tempRegistry.Timeout != rcRegistry.Timeout {
+			rc.Registries[registryId].Timeout = tempRegistry.Timeout
+			logger.Infof("CenterConfig process update %s timeout, new value:%s", registryId, rc.Registries[registryId].Timeout)
+		}

Review comment:
       已经把更新逻辑移至registry层




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-978850866


   cc @zhaoyunxing92 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 commented on a change in pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#discussion_r762780516



##########
File path: config/root_config.go
##########
@@ -358,3 +360,25 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
 	}
 	return nil
 }
+
+// Process receive changing listener's event, dynamic update config
+func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
+	logger.Infof("CenterConfig process event:\n%+v", event)
+	koan := koanf.New(".")
+	if err := koan.Load(rawbytes.Provider([]byte(event.Value.(string))), yaml.Parser()); err != nil {

Review comment:
       这段代码可以考虑下面代码替换
   ```go
   config := NewLoaderConf(WithDelim("."), WithGenre(cc.FileExtension), WithBytes([]byte(strConf)))
   koan := GetConfigResolver(config)
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] sunrui1225 commented on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
sunrui1225 commented on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-988365383


   好的我试一下
   
   发自我的iPhone
   
   > 在 2021年12月6日，16:16，zhaoyunxing ***@***.***> 写道：
   > 
   > 
   > @zhaoyunxing92 commented on this pull request.
   > 
   > In config/root_config.go:
   > 
   > > @@ -358,3 +360,25 @@ func publishMapping(sc exporter.MetadataServiceExporter) error {
   >  	}
   >  	return nil
   >  }
   > +
   > +// Process receive changing listener's event, dynamic update config
   > +func (rc *RootConfig) Process(event *config_center.ConfigChangeEvent) {
   > +	logger.Infof("CenterConfig process event:\n%+v", event)
   > +	koan := koanf.New(".")
   > +	if err := koan.Load(rawbytes.Provider([]byte(event.Value.(string))), yaml.Parser()); err != nil {
   > 这段代码可以考虑下面代码替换
   > 
   > config := NewLoaderConf(WithDelim("."), WithGenre(cc.FileExtension), WithBytes([]byte(strConf)))
   > koan := GetConfigResolver(config)
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592#issuecomment-970098326


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1592](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3505b5f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/e3768344ecb0d22ac22b7e530070f5c15c1c4e40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e376834) will **increase** coverage by `0.10%`.
   > The diff coverage is `94.44%`.
   
   > :exclamation: Current head 3505b5f differs from pull request most recent head bb5dc84. Consider uploading reports for the commit bb5dc84 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1592/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1592      +/-   ##
   ==========================================
   + Coverage   41.15%   41.26%   +0.10%     
   ==========================================
     Files         254      250       -4     
     Lines       14590    14297     -293     
   ==========================================
   - Hits         6005     5900     -105     
   + Misses       7888     7714     -174     
   + Partials      697      683      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `48.57% <0.00%> (-1.92%)` | :arrow_down: |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `44.38% <100.00%> (+3.44%)` | :arrow_up: |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `53.73% <0.00%> (-9.29%)` | :arrow_down: |
   | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `50.00% <0.00%> (-6.82%)` | :arrow_down: |
   | [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `31.23% <0.00%> (-3.15%)` | :arrow_down: |
   | [metadata/report/nacos/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L25hY29zL3JlcG9ydC5nbw==) | `37.77% <0.00%> (-2.23%)` | :arrow_down: |
   | [filter/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <0.00%> (-1.25%)` | :arrow_down: |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.37% <0.00%> (-0.43%)` | :arrow_down: |
   | ... and [47 more](https://codecov.io/gh/apache/dubbo-go/pull/1592/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e376834...bb5dc84](https://codecov.io/gh/apache/dubbo-go/pull/1592?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zhaoyunxing92 merged pull request #1592: Config update issue

Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 merged pull request #1592:
URL: https://github.com/apache/dubbo-go/pull/1592


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org