You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/10 10:01:06 UTC
[GitHub] [maven-scm] nielsbasjes opened a new pull request #134: [SCM-976] GitExe Changelog supports current versions of git
nielsbasjes opened a new pull request #134:
URL: https://github.com/apache/maven-scm/pull/134
My proposed fix for https://issues.apache.org/jira/browse/SCM-976
I'm an Apache Committer (Avro, Flink) so the licensing part should be fine.
If I run the current version on the maven-scm git repo I see:
mvn org.apache.maven.plugins:maven-scm-plugin:2.0.0-M1:changelog
```
[INFO] --- maven-scm-plugin:2.0.0-M1:changelog (default-cli) @ maven-scm ---
[INFO] Executing: /bin/sh -c cd '/home/nbasjes/workspace/Apache/maven-scm' && 'git' 'whatchanged' '--date=iso' '--' '.'
[INFO] Working directory: /home/nbasjes/workspace/Apache/maven-scm
[INFO] Michael Osipov <mi...@apache.org>
null
```
with these changes I see
mvn org.apache.maven.plugins:maven-scm-plugin:2.0.0-M2-SNAPSHOT:changelog
```
[INFO] Executing: /bin/sh -c cd '/home/nbasjes/workspace/Apache/maven-scm' && 'git' 'whatchanged' '--date=iso' '--' '.'
[INFO] Working directory: /home/nbasjes/workspace/Apache/maven-scm
[INFO] Michael Osipov <mi...@apache.org>
Sat Jan 08 21:02:12 CET 2022
[modified]:maven-scm-api/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-client/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-managers/maven-scm-manager-plexus/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-managers/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-plugin/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-provider-hg/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-provider-local/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gittest/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-git/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-standard/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svntest/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/maven-scm-providers-svn/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-providers/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:maven-scm-test/pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[modified]:pom.xml, 4fc34cfa14f2e72506187b03a492ce55ed459d4c
[maven-release-plugin] prepare for next development iteration
[INFO] Michael Osipov <mi...@apache.org>
Sat Jan 08 21:02:01 CET 2022
[modified]:maven-scm-api/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-client/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-managers/maven-scm-manager-plexus/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-managers/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-plugin/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-provider-hg/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-provider-local/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gittest/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-git/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-standard/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svntest/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/maven-scm-providers-svn/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-providers/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:maven-scm-test/pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[modified]:pom.xml, 3a6d9817fe809c43eca588d7c0f4428254eae17c
[maven-release-plugin] prepare release maven-scm-2.0.0-M1
[INFO] Michael Osipov <mi...@apache.org>
Sat Jan 08 20:49:53 CET 2022
[modified]:src/site/apt/guide/index.apt, 6cf3ed02e19db47f20d95dac4a24f2c40121e67f
[modified]:src/site/apt/guide/new_provider.apt, 6cf3ed02e19db47f20d95dac4a24f2c40121e67f
[modified]:src/site/apt/guide/usage.apt, 6cf3ed02e19db47f20d95dac4a24f2c40121e67f
[modified]:src/site/site.xml, 6cf3ed02e19db47f20d95dac4a24f2c40121e67f
Use canonical name 'Maven SCM'
[INFO] Michael Osipov <mi...@apache.org>
Sat Jan 08 20:42:33 CET 2022
[modified]:maven-scm-api/src/main/java/org/apache/maven/scm/command/changelog/ChangeLogScmRequest.java, 8b64075b41174b581be3606aea08a88f9f06f73c
[modified]:maven-scm-api/src/main/java/org/apache/maven/scm/manager/BasicScmManager.java, 8b64075b41174b581be3606aea08a88f9f06f73c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/util/GitUtil.java, 8b64075b41174b581be3606aea08a88f9f06f73c
[modified]:maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/JGitUtils.java, 8b64075b41174b581be3606aea08a88f9f06f73c
[modified]:maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svn-commons/src/main/java/org/apache/maven/scm/provider/svn/util/SvnUtil.java, 8b64075b41174b581be3606aea08a88f9f06f73c
Fix issues reported by Checkstyle
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] nielsbasjes commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1079002929
@michael-o ping ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] pzygielo commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1086282272
ping @michael-o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] pzygielo commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1034806179
@nielsbasjes just to check - could you share result of
```
git config --show-origin --get format.pretty
```
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] pzygielo commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1034792936
I think SCM-976 is caused by
1. probably non-default git configuration in reporter's env for `format`
1. here - by the fact that https://github.com/apache/maven-scm/blob/ba71e03aba8115c3f70c1171edc17b98f347c08d/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java#L202 does not set the format explicitly, and uses the one that might also be altered by the user in configuration.
I also don't think the git built-in formats change between versions.
IMO - instead of proposed changes - it would be better to explicitly use `--format=...` - setting the one that extracting changelog is done from (`medium` now I guess).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] pzygielo commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1073727797
@michael-o @cstamas
Could we have this change reviewed, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1074329223
Please ping me on Friday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] nielsbasjes commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1034911961
> ```
> git config --show-origin --get format.pretty
> ```
$ git config --show-origin --get format.pretty
file:/home/nbasjes/.gitconfig fuller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] nielsbasjes commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #134:
URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1034923791
@pzygielo You were absolutely right. I have updated the pull request to set the format explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org