You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/05 23:29:20 UTC

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2830: Add SHOW CREATE TABLE with initial support for views

andygrove commented on code in PR #2830:
URL: https://github.com/apache/arrow-datafusion/pull/2830#discussion_r914281738


##########
datafusion/proto/src/logical_plan.rs:
##########
@@ -515,11 +515,16 @@ impl AsLogicalPlan for LogicalPlanNode {
                     "Protobuf deserialization error, CreateViewNode has invalid LogicalPlan input.",
                 )))?
                     .try_into_logical_plan(ctx, extension_codec)?;
+                let create_statement = match create_view.create_statement.is_empty() {

Review Comment:
   nit: matching on a `bool` could be simplified to `if`/`else`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org