[jira] [Commented] (THRIFT-1177) Update thrift to reflect changes in Go's networking libraries

["Aalok Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046301#comment-13046301 ] 

Aalok Shah commented on THRIFT-1177:
------------------------------------

It appears in the current stable release (r57.1) of Go, http.Get() returns 3 values.
In the latest development version, http.Get() returns 2 values.
As there is no way to perform conditional compilations (a la #ifdef in C), a version can either work with the stable release or tip, but not both.

I assume the Thrift project prefers working with the latest stable release rather than the fluctuations that can occur on tip.

Thanks for looking at the patch.

> Update thrift to reflect changes in Go's networking libraries
> -------------------------------------------------------------
>
>                 Key: THRIFT-1177
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1177
>             Project: Thrift
>          Issue Type: Dependency upgrade
>          Components: Go - Compiler, Go - Library
>    Affects Versions: 0.7
>            Reporter: Aalok Shah
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: gopatch2-r2.diff, gopatch2.diff
>
>
> Go updated its networking libraries requiring a change to both the thrift code generator and the libraries.
> Additionally, the Go generator did not support arguments/variables that were Go keywords, this needs to be updated to work with Cassandra's thrift since "range" is a Go keyword.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira