[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #25173: Improve EXPORT METADATA add snapshot data

["RaigorJiang (via GitHub)" <gi...@apache.org>]

RaigorJiang commented on code in PR #25173:
URL: https://github.com/apache/shardingsphere/pull/25173#discussion_r1168515276


##########
proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ExportMetaDataExecutor.java:
##########
@@ -110,6 +116,20 @@ private String generateRulesData(final Collection<RuleConfiguration> rules) {
         return result.toString();
     }
     
+    private void generateSnapshotInfo(final ShardingSphereMetaData metaData, final ExportedClusterInfo exportedClusterInfo) {
+        Optional<GlobalClockRule> globalClockRule = metaData.getGlobalRuleMetaData().findSingleRule(GlobalClockRule.class);

Review Comment:
   Please use `getSingleRule` to get global rule, because it always exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org